[Bug 25735] New: Add distinct classes for clear history (.clearsh) links on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25735 Bug ID: 25735 Summary: Add distinct classes for clear history (.clearsh) links on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org As of 19.11 the OPAC navbar has a nice dropdown for logged in users that includes search history and a clearsh link which clears you history. clearsh also exists on the navbar for unauthenticated users. These two clearsh buttons have a very similar HTML structure and it makes it almost impossible to style the two links independently. Some libraries will want to style the background and text colors of each of these clearsh links independent of one another. It would be easy to give each one its own class to make this easy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25735 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 105850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105850&action=edit Bug 25735: Add seperate classes for each clearsh button TEST PLAN: 1. Apply patch 2. Add these two lines to the OPACUserCSS: .clearsh-one {color:green !important;} .clearsh-two {color:red !important;} 3. Refresh OPAC and be logged out, the "Clear" button in the top right should now be green. 4. Refresh OPAC and be logged in, the "Clear" button inside the dropdown on the top right should be red. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25735 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I hadn't notice this patch before because it was still marked "NEW." I think things may have changed a little since this was originally submitted. There is a fairly simple way to differentiate the two links now: /* Color for logged-out users */ .clearsh {color:green !important;} /* Color for logged-in users */ #loggedinuser-menu .clearsh { color:blue !important} I prefer this to adding the -one -two classes because they're not semantically meaningful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25735 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org