[Bug 39514] New: If one basket has uncertain prices, all basket are displayed in red
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Bug ID: 39514 Summary: If one basket has uncertain prices, all basket are displayed in red Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Go to Acquisitions 2. Click 'Search' in the vendor search 3. Click 'Add to basket' next to 'My basket' 4. Click 'From a new (empty) record' 5. Fill out the form - Title: enter a title - Koha item type: choose an item type 5.1. Click 'Add item' - Fund: choose a fund - Uncertain price: check 6. Click 'Save' 7. Go back to Acquisitions 8. Click 'Search' in the vendor search 9. Click 'New' > 'Basket' 10. Enter a basket name 11. Click 'Save' 12. Go back to Acquistions 13. Click 'Search' in the vendor search --> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices 14. Click 'Add to basket' --> Notice everything is in bold and some in red -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com Version|unspecified |25.05 --- Comment #1 from holly@bywatersolutions.com --- Cancelled orders with uncertain prices also cause all baskets for the vendor to display in red. See 36684 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.05 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187657&action=edit Bug 39514: Only mark the affected rows as problematic Before this patch we were setting a variable and nebver unsetting it Now we can add the conditional directly to the row, so don't need a variable To test: 1. Go to Acquisitions 2. Click 'Search' in the vendor search 3. Click 'Add to basket' next to 'My basket' 4. Click 'From a new (empty) record' 5. Fill out the form - Title: enter a title - Koha item type: choose an item type 5.1. Click 'Add item' - Fund: choose a fund - Uncertain price: check 6. Click 'Save' 7. Go back to Acquisitions 8. Click 'Search' in the vendor search 9. Click 'New' > 'Basket' 10. Enter a basket name 11. Click 'Save' 12. Go back to Acquistions 13. Click 'Search' in the vendor search --> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices 14. Click 'Add to basket' --> Notice everything is in bold and some in red 15. Apply patch, reload 16. Only affected basket is in red -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187657|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 187662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187662&action=edit Bug 39514: Only mark the affected rows as problematic Before this patch we were setting a variable and nebver unsetting it Now we can add the conditional directly to the row, so don't need a variable To test: 1. Go to Acquisitions 2. Click 'Search' in the vendor search 3. Click 'Add to basket' next to 'My basket' 4. Click 'From a new (empty) record' 5. Fill out the form - Title: enter a title - Koha item type: choose an item type 5.1. Click 'Add item' - Fund: choose a fund - Uncertain price: check 6. Click 'Save' 7. Go back to Acquisitions 8. Click 'Search' in the vendor search 9. Click 'New' > 'Basket' 10. Enter a basket name 11. Click 'Save' 12. Go back to Acquistions 13. Click 'Search' in the vendor search --> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices 14. Click 'Add to basket' --> Notice everything is in bold and some in red 15. Apply patch, reload 16. Only affected basket is in red Signed-off-by: Samuel <sam.sowanick@corvallisoregon.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sam.sowanick@corvallisorego | |n.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187662|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 190191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190191&action=edit Bug 39514: Only mark the affected rows as problematic Before this patch we were setting a variable and nebver unsetting it Now we can add the conditional directly to the row, so don't need a variable To test: 1. Go to Acquisitions 2. Click 'Search' in the vendor search 3. Click 'Add to basket' next to 'My basket' 4. Click 'From a new (empty) record' 5. Fill out the form - Title: enter a title - Koha item type: choose an item type 5.1. Click 'Add item' - Fund: choose a fund - Uncertain price: check 6. Click 'Save' 7. Go back to Acquisitions 8. Click 'Search' in the vendor search 9. Click 'New' > 'Basket' 10. Enter a basket name 11. Click 'Save' 12. Go back to Acquistions 13. Click 'Search' in the vendor search --> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices 14. Click 'Add to basket' --> Notice everything is in bold and some in red 15. Apply patch, reload 16. Only affected basket is in red Signed-off-by: Samuel <sam.sowanick@corvallisoregon.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 --- Comment #6 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- Have to ask...any chance for a backport on this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Summary|If one basket has uncertain |If one basket has uncertain |prices, all basket are |prices, all baskets are |displayed in red |displayed in red Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |baskets in acquisitions so | |that only baskets with | |uncertain prices are shown | |in red. Previously, if one | |basket had an uncertain | |price, all the baskets in | |the page were shown in red, | |even those without | |uncertain prices, making it | |hard to know where to go to | |fix the price. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 --- Comment #7 from David Nind <david@davidnind.com> --- Thanks for the release note Caroline! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@openfifth.co.uk --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 --- Comment #10 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- That's good news! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|26.05.00,25.11.01 |26.05.00,25.11.01,25.05.12 released in| | --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 25.05.x for 25.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldoldstable |Needs documenting --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not needed for 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39514 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix. No changes needed in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org