[Bug 41427] New: Terminology : branch should be library in FilterSearchResultsByLoggedInBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Bug ID: 41427 Summary: Terminology : branch should be library in FilterSearchResultsByLoggedInBranch Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The term "library" is preferred to "branch" in the staff interface https://wiki.koha-community.org/wiki/Terminology#B Bug 37883 introduced a new system preference with "branch". FilterSearchResultsByLoggedInBranch : Don't/Do add a filter to the location column on staff interface search results to filter items by the logged in user branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 190417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190417&action=edit Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I also find misleading the part "the logged in user branch". I feel like it implies that it will filter the items by the branch of the logged in user. But the feature is to filter items by the branch **where** the user is logged in. Maybe it's just my french-speaking brain misunderstanding the sentence. If possible, I'd like a native english speaker to chime in? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37883 [Bug 37883] Add a filter for staff search results to filter by library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190417|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190418&action=edit Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190418|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 190445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190445&action=edit Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190446&action=edit Bug 41427: (QA follow-up) Add new line at end of file Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology : branch should |Terminology: branch should |be library in |be library in |FilterSearchResultsByLogged |FilterSearchResultsByLogged |InBranch |InBranch QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | Text to go in the| |This fixes the terminology release notes| |and improves the | |description for the | |FilterSearchResultsByLogged | |InBranch system preference | |- branch should be library. --- Comment #6 from David Nind <david@davidnind.com> --- Added a follow-up to add a new line at the end of the file - running qa identified this. However, running prove xt/find-missing-new-lines-at-the-end-of-file.t (see bug 40541) didn't pick up that there was no new line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 41394 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The system preference is in 25.11 and 25.05. If the patch could be backported, it would be great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Bug 41427 depends on bug 37883, which changed state. Bug 37883 Summary: Add a filter for staff search results to filter by library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37883 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1145 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|26.05.00,25.11.01 |26.05.00,25.11.01,25.05.12 released in| | --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 25.05.x for 25.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41427 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Already changed in the manual -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org