[Bug 25159] New: Action logs should be stored in JSON ( and as a diff of the change )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Bug ID: 25159 Summary: Action logs should be stored in JSON ( and as a diff of the change ) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Action logs would be much more readable if we changed the format from a raw Data::Dumper::Dumper string to JSON which we could format nicely in the interface. In addition, we could store changes to database rows ( and other data structures ) as a diff stored in JSON. I think the format from Struct::Diff::diff is nice. Given: my $x = { surname => 'Hall', firstname => 'Kyle', cardnumber => '12345', suffix => "Jr.", }; my $y = { surname => 'Hall', firstname => 'Kyle', cardnumber => '9876543', nickname => "K-dog" }; The diff looks like: { "D": { "cardnumber": { "N": "9876543" }, "nickname": { "A": "K-dog" }, "suffix": { "R": "Jr." } } } Where the D key is the difference, and indicates cardnumber has changed with an N, nickname has been added with an A, and suffix has been removed with an R. With this data we can easily construct a nice diff view ( perhaps green for added, red for removed, and yellow for changes showing the old and new value ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- If we used Scruct::Diff, we should keep the old values, but omit unchanged values $diff = diff($x, $y, noU => 1 ); # omit unchanged items This would give: { "D": { "cardnumber": { "N": "9876543" "O": "12345" }, "nickname": { "A": "K-dog" }, "suffix": { "R": "Jr." } } } So we can display the old and new values for changed fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Yet another benefit would be the ability to run queries against the action log's data if/when the DBMS is JSON aware ( mysql 5.7 / maraia 10.2.3 ). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I like this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- +100 on this idea. Standardizing action logs across modules would be great. Storing both before and after values would be great. Making them all use JSON for easy reporting would be great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- This would be so great. I often have a hard time interpreting the action logs - easily seeing the before and after values would be really helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm going to propose we begin by adding a new column named "diff" to the action_logs table to store this json formatted diff. Once that's in we can work on the viewer as a followup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #7 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Kyle M Hall from comment #6)
I'm going to propose we begin by adding a new column named "diff" to the action_logs table to store this json formatted diff. Once that's in we can work on the viewer as a followup.
That seems like a good low-bar option to get this moving. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's a good idea, our current logs all log a little differently. A 'fresh start' in a new column makes sense to get out of the situation incrementally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153600&action=edit Bug 25159: DB Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153600|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153601&action=edit Bug 25159: DB Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153602&action=edit Bug 25159: Update Schema File [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153603&action=edit Bug 15159: Add ability to specify a pre-modified version of action log data and store as diff Test Plan: 1) sudo cpanm Struct::Diff 2) prove t/db_dependent/Log.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153604&action=edit Bug 15159: Implement diffs in action logs for holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153601|0 |1 is obsolete| | Attachment #153602|0 |1 is obsolete| | Attachment #153603|0 |1 is obsolete| | Attachment #153604|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153606&action=edit Bug 25159: DB Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153607&action=edit Bug 25159: Update Schema File [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153608&action=edit Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff Test Plan: 1) sudo cpanm Struct::Diff 2) prove t/db_dependent/Log.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153609&action=edit Bug 25159: Implement diffs in action logs for holds Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable HoldsLog 5) Perform various hold related actions 6) Observe the diff column is populated by a JSON string of the diff format generated by Struct::Diff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153606|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 153611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153611&action=edit Bug 25159: DB Update Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153607|0 |1 is obsolete| | --- Comment #19 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 153612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153612&action=edit Bug 25159: Update Schema File [DO NOT PUSH] Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153608|0 |1 is obsolete| | --- Comment #20 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 153613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153613&action=edit Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff Test Plan: 1) sudo cpanm Struct::Diff 2) prove t/db_dependent/Log.t Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153609|0 |1 is obsolete| | --- Comment #21 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 153614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153614&action=edit Bug 25159: Implement diffs in action logs for holds Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable HoldsLog 5) Perform various hold related actions 6) Observe the diff column is populated by a JSON string of the diff format generated by Struct::Diff Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Those signoffs are actually mine, produced on a sandbox. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #22)
Those signoffs are actually mine, produced on a sandbox. Thanks!
I'll get those fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153611|0 |1 is obsolete| | Attachment #153612|0 |1 is obsolete| | Attachment #153613|0 |1 is obsolete| | Attachment #153614|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153637&action=edit Bug 25159: DB Update Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153637|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153643&action=edit Bug 25159: DB Update Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153644&action=edit Bug 25159: Update Schema File [DO NOT PUSH] Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153645&action=edit Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff Test Plan: 1) sudo cpanm Struct::Diff 2) prove t/db_dependent/Log.t Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153646&action=edit Bug 25159: Implement diffs in action logs for holds Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable HoldsLog 5) Perform various hold related actions 6) Observe the diff column is populated by a JSON string of the diff format generated by Struct::Diff Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. I am not sure, but maybe we could pass $self and log $self->get_from_store as the original (?) Maybe we will lose flexibility however. 2. What about the switch? Should we continue to log in 'info'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please give feedback when questions are raised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com --- Comment #31 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #29)
1. I am not sure, but maybe we could pass $self and log $self->get_from_store as the original (?) Maybe we will lose flexibility however.
2. What about the switch? Should we continue to log in 'info'?
I don't know enough about 1 to speak to that, but as far as 2 goes, I think yes, we continue logging in info, at least for now as it will show information that isn't changed and the diff will only show updated information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #29)
1. I am not sure, but maybe we could pass $self and log $self->get_from_store as the original (?) Maybe we will lose flexibility however.
I don't think I understand your question. Could you give me some more detail?
2. What about the switch? Should we continue to log in 'info'?
Yes, I think for the time being we should continue to log in `info`. We can EOL the info column at some point in the future, but we should give everyone plenty of advance notice if we ever choose to do so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Kyle M Hall from comment #32)
(In reply to Jonathan Druart from comment #29)
1. I am not sure, but maybe we could pass $self and log $self->get_from_store as the original (?) Maybe we will lose flexibility however.
I don't think I understand your question. Could you give me some more detail?
Replace: + my $original = C4::Context->preference('HoldsLog') ? $self->unblessed : undef; + logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, $self, undef, $original ) With + logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, $self, undef ) And, in logaction, $original = $self->get_from_storage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> ---
Replace: + my $original = C4::Context->preference('HoldsLog') ? $self->unblessed : undef; + logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, $self, undef, $original )
With + logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, $self, undef )
And, in logaction, $original = $self->get_from_storage.
I like it! Let's support both since $infos can be either! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159758&action=edit Bug 25159: (QA follow-up) Allow passing of 'original' as hashref or Koha::Object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153643|0 |1 is obsolete| | --- Comment #36 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164597&action=edit Bug 25159: DB Update Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153644|0 |1 is obsolete| | --- Comment #37 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164598&action=edit Bug 25159: Update Schema File [DO NOT PUSH] Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153645|0 |1 is obsolete| | --- Comment #38 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164599&action=edit Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff Test Plan: 1) sudo cpanm Struct::Diff 2) prove t/db_dependent/Log.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153646|0 |1 is obsolete| | --- Comment #39 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164600&action=edit Bug 25159: Implement diffs in action logs for holds Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable HoldsLog 5) Perform various hold related actions 6) Observe the diff column is populated by a JSON string of the diff format generated by Struct::Diff Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159758|0 |1 is obsolete| | --- Comment #40 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164601&action=edit Bug 25159: (QA follow-up) Allow passing of 'original' as hashref or Koha::Object Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #41 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Tests for this bug are OK but prove t/db_dependent/Log.t fails on following error: # Failed test 'Reduce log size by unblessing Koha objects' # at t/db_dependent/Log.t line 195. encountered object 't::lib::TestBuilder=HASH(0x556b88394790)', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /home/emmi/Koha/C4/Log.pm line 137. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Emmi Takkinen from comment #41)
Tests for this bug are OK but prove t/db_dependent/Log.t fails on following error:
# Failed test 'Reduce log size by unblessing Koha objects' # at t/db_dependent/Log.t line 195. encountered object 't::lib::TestBuilder=HASH(0x556b88394790)', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /home/emmi/Koha/C4/Log.pm line 137.
That unit test is passing for me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #43 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Kyle M Hall from comment #42)
(In reply to Emmi Takkinen from comment #41)
Tests for this bug are OK but prove t/db_dependent/Log.t fails on following error:
# Failed test 'Reduce log size by unblessing Koha objects' # at t/db_dependent/Log.t line 195. encountered object 't::lib::TestBuilder=HASH(0x556b88394790)', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /home/emmi/Koha/C4/Log.pm line 137.
That unit test is passing for me!
I did suspect that this might be a problem in my test environment. Thank you for confirming it :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164597|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165527&action=edit Bug 25159: DB Update Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164598|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165528&action=edit Bug 25159: Update Schema File [DO NOT PUSH] Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164599|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165529&action=edit Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff Test Plan: 1) sudo cpanm Struct::Diff 2) prove t/db_dependent/Log.t Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164600|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165530&action=edit Bug 25159: Implement diffs in action logs for holds Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable HoldsLog 5) Perform various hold related actions 6) Observe the diff column is populated by a JSON string of the diff format generated by Struct::Diff Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164601|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165531&action=edit Bug 25159: (QA follow-up) Allow passing of 'original' as hashref or Koha::Object Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165532&action=edit Bug 25159: (QA follow-up) Tidy changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Long overdue enhancements that Kyle and I discussed way back in 2020! All working well and I'm looking forward to display improvements at the other end. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36698 [Bug 36698] Display 'diff' nicely in action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36699 [Bug 36699] Use 'diff' option in actionlogs more widely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is quite an odd one, I can't seem to run QA tools on the patch set. FAIL C4/Log.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL valid Can't locate Struct/Diff.pm in @INC (you may need to install the Struct::Diff module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.36.0 /usr/local/share/perl/5.36.0 /usr/lib/x86_64-linux-gnu/perl5/5.36 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.36 /usr/share/perl/5.36 /usr/local/lib/site_perl) ... The same tests worked fine all day. Only happens once the patches are applied? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off Keywords| |dependency --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, this introduces a new dependency. We will need the packaging team to have a look at this. +use Struct::Diff qw( diff ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #53 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #52)
Ok, this introduces a new dependency. We will need the packaging team to have a look at this.
+use Struct::Diff qw( diff );
i'll have a go at packaging this one, its missing from debian.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Mason James from comment #53)
(In reply to Katrin Fischer from comment #52)
Ok, this introduces a new dependency. We will need the packaging team to have a look at this.
+use Struct::Diff qw( diff );
i'll have a go at packaging this one, its missing from debian.org
Thanks Mason! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #55 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #53)
(In reply to Katrin Fischer from comment #52)
Ok, this introduces a new dependency. We will need the packaging team to have a look at this.
+use Struct::Diff qw( diff );
i'll have a go at packaging this one, its missing from debian.org
package is pushed to koha-staging repo, ready for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Why did we choose here for a perl module that has no Debian package? Just glancing over cpan I am seeing for instance Data::Compare with a Debian package libdata-compare-perl. And note that Struct::Diff is from 2019 with bus factor 0 and Data::Compare is from 2023 with bus factor 1. I think that we should not just start packaging without asking for good reasons to go for an 'unpackaged' perl module.. (Noting that I do not see any discussion about the choice for this module on the report.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Action logs should be |Action logs should be |stored in JSON ( and as a |stored in JSON (and as a |diff of the change ) |diff of the change) Keywords|rel_24_05_candidate |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I asked the question to myself whilst QAing and couldn't find any comparable module.. Data::Compare isn't one I came across but a quick look now suggests it has very different output and use case.. i.e. it's a simple boolean result of are these things the same whilst Struct::Diff is rather different in that it offers a structured diff output highlight what's changed where. I have actually done this before though come to think about it.. I should see what I used back then.. I was generating JSON::Patch patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|angela.berrett@familysearch | |.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks like I maintained my own JSON::Patch library back then. 8 years ago, wow.. I should really have upstreamed it to cpan. Anywho, I think Struct::Diff, whilst not the nicest output for humans, works pretty well and isn't as badly maintained as you suggest.. it's got a few things depending on it etc.im happy to submit my JSON::Patch library is people would prefer however -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- I chose Struct::Diff because if generated the best format for the use case. I doubt a library like Struct::Diff requires much, if anything, in the way of maintenance. That said I see no problem replacing it with an alternative as long as we don't lose any functionality! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166219&action=edit Bug 25159: (QA follow-up) Make dbrev idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36790 [Bug 36790] 230600052.pl is failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #62 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This is the first step to release notes| |improve and standardize the | |way we log information in | |the action log tables. In | |order to achieve this a new | |column `diff` is added to | |the `action_logs` table. | |This is used to store a | |diff of the changes to an | |object in JSON syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940 [Bug 37940] [OMNIBUS] All modification logged via action logs should include original to create JSON diff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #63 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- If i understand correctly, this doesn't change anything in the interface, correct? If that is the case, there is nothing to change or edit in the manual. Please reopen with more details if I'm wrong! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #63)
If i understand correctly, this doesn't change anything in the interface, correct? If that is the case, there is nothing to change or edit in the manual. Please reopen with more details if I'm wrong!
That is correct! Eventually we will want to build a viewer to see these diffs in the action logs viewer, but for now it's good to have them for devops to access. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #65 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Coming from 38531. - my $diff = ( $original && ref $updated eq 'HASH' ) ? encode_json( diff( $original, $updated, noU => 1 ) ) : undef; + my $diff = undef; + $diff = encode_json( diff( $original->unblessed, $updated, noU => 1 ) ) + if blessed($original) && $original->isa('Koha::Object'); + $diff //= encode_json( diff( $original, $updated, noU => 1 ) ) + if $original && ref $updated eq 'HASH'; Would be nice to add some POD for this change? Bit obscure now imo. Also note that this earlier line does not check $original: if ( $infos->isa('Koha::Item') && $modulename eq 'CATALOGUING' && $actionname eq 'MODIFY' ) { $infos = "item " . Dumper( $original->unblessed ); Feels suboptimal? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #66 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- *** Bug 32306 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37940 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940 [Bug 37940] [OMNIBUS] All modification logged via action logs should include original to create JSON diff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 [Bug 39628] Display 'diff' in action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36698 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36698 [Bug 36698] Display 'diff' nicely in action logs -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org