[Bug 39628] New: Display 'diff' satisfactorily in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Bug ID: 39628 Summary: Display 'diff' satisfactorily in action logs Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: andrew@bywatersolutions.com Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Blocks: 36698 Bug 36698 wants to display the diff nicely. As a stopgap, how about we just make it possible to display them as-is? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36698 [Bug 36698] Display 'diff' nicely in action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 180922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180922&action=edit Bug 39628: Show diff in log viewer and column settings To test: 1 - apply patch 2 - search the log viewer for item edits or something else that records a diff value 3 - see that diff in the new column 4 - confirm the diff value is present in exports and prints 5 - confirm you can use column config to hide that diff value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl Status|Needs Signoff |Failed QA --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Yes, it is good start to show data from diff col. I modified an item and can confirm p. 1-4 test plan, but not p. 5. There is no "Diff" in cols list for "Columns" button. There is no "diff" in configure table (/cgi-bin/koha/admin/columns_settings.pl?module=tools&page=logviewer&table=logst) to hide it by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Roman Dolny from comment #2)
Yes, it is good start to show data from diff col.
I modified an item and can confirm p. 1-4 test plan, but not p. 5.
There is no "Diff" in cols list for "Columns" button. There is no "diff" in configure table (/cgi-bin/koha/admin/columns_settings. pl?module=tools&page=logviewer&table=logst) to hide it by default.
Did you restart_all after applying the patch? I forgot to specify that in the test plan, but I do see Diff in the table config after restarting services. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- (In reply to Andrew Fuerste-Henry from comment #3)
... Did you restart_all after applying the patch? I forgot to specify that in the test plan, but I do see Diff in the table config after restarting services.
I'm pretty sure I did, but now it works... checked twice, with another browser and incognito. Thanks for suggestion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180922|0 |1 is obsolete| | --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 180937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180937&action=edit Bug 39628: Show diff in log viewer and column settings To test: 1 - apply patch 2 - search the log viewer for item edits or something else that records a diff value 3 - see that diff in the new column 4 - confirm the diff value is present in exports and prints 5 - confirm you can use column config to hide that diff value Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180937|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182190&action=edit Bug 39628: Show diff in log viewer and column settings To test: 1 - apply patch 2 - search the log viewer for item edits or something else that records a diff value 3 - see that diff in the new column 4 - confirm the diff value is present in exports and prints 5 - confirm you can use column config to hide that diff value Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA Text to go in the| |Adds a "diff" column to the release notes| |action logs viewer. This | |column will display the old | |(O) and new (N) values of | |the fields that were | |changed, for modules that | |store that information. --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- I agree it's worth displaying the raw diff in the meantime. Thanks, Andrew! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a bit scary looking. Could we agree to hide the column by default in the table configuration settings? (these are also missing, please follow-up!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Keywords| |additional_work_needed --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I need to clarify, the "Diff" was not showing up initially in my column configuration settings above the table. After some restarting etc. it does now. It still might be nice to hide it by default, but leaving that for a simple follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display 'diff' |Display 'diff' in action |satisfactorily in action |logs |logs | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39908 [Bug 39908] Hide diff column by default in log viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> ---
It still might be nice to hide it by default, but leaving that for a simple follow-up.
Follow-up filed: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39908 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Does anyone have a list of "something that records a diff value"? I'm trying to document this and I tried editing an item and editing a patron and even if I unhide the diff column, I only see the regular JSON entry. I tried both in ktd and a "vintage" install of 25.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 188229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188229&action=edit screenshot of item modification log I've attached a screenshot of this diff info as it shows on an item modification. This patch makes it possible to see the diff column in the action logs but does not format it in any way. Previously the diff column was not available here and the diff could only be seen via SQL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 --- Comment #15 from Angela Berrett <angela.berrett@familysearch.org> --- (In reply to Caroline Cyr La Rose from comment #13)
Does anyone have a list of "something that records a diff value"? I'm trying to document this and I tried editing an item and editing a patron and even if I unhide the diff column, I only see the regular JSON entry. I tried both in ktd and a "vintage" install of 25.05.02.
Bug 35645 discusses further cleaning up the JSON so it is easier to read. Now that the JSON is viewable we need it to be readable for those of us who are coding-deficient. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Angela Berrett from comment #15)
(In reply to Caroline Cyr La Rose from comment #13)
Does anyone have a list of "something that records a diff value"? I'm trying to document this and I tried editing an item and editing a patron and even if I unhide the diff column, I only see the regular JSON entry. I tried both in ktd and a "vintage" install of 25.05.02.
Bug 35645 discusses further cleaning up the JSON so it is easier to read. Now that the JSON is viewable we need it to be readable for those of us who are coding-deficient. :)
I filed this bug as a "good enough (and within my coding ability)" alternative to Bug 36698: "Display 'diff' nicely in action logs" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Depends on| |25159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 [Bug 25159] Action logs should be stored in JSON (and as a diff of the change) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org