[Bug 31069] New: Did you mean? in the OPAC - links have <span> tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Bug ID: 31069 Summary: Did you mean? in the OPAC - links have <span> tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org Created attachment 136756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136756&action=edit Screenshot - OPAC search showing <span> tags for Did you mean? In master, when "Did you mean?" is enabled <span> tags are exposed (see attached screenshot). To replicate: 1. Enable "Did you mean?": . go to Administration > Additional parameters > Did you mean? . put a tick in each plugin and save the configuration 2. In the OPAC, search for 'open source' This is showing only in master, and not in 22.05.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Depends on| |30733 Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |victor@tuxayo.net --- Comment #1 from Victor Grousset/tuxayo <victor@tuxayo.net> --- oops, it must be from bug 30733 ^^" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 [Bug 30733] Simplify translatable strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
This is showing only in master, and not in 22.05.x.
We can expect it to be in 22.05.02 since it ships 30733. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 137444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137444&action=edit Bug 31069: fix <span> in OPAC search suggestions (Did you mean) == test plan == 1. Enable "Did you mean?": . go to Administration > Additional parameters > Did you mean? . put a tick in each plugin and save the configuration 2. In the OPAC, search for 'open source' 3. Without the patch you see escaped <span> after "Did you mean:" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30629 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Same fix as bug 30629 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137444|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 137446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137446&action=edit Bug 31069: fix <span> in OPAC search suggestions (Did you mean) == test plan == 1. Enable "Did you mean?": . go to Administration > Additional parameters > Did you mean? . put a tick in each plugin and save the configuration 2. In the OPAC, search for 'open source' 3. Without the patch you see escaped <span> after "Did you mean:" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes <span> tags release notes| |incorrectly appearing | |around the options | |available when 'Did you | |mean?' is enabled (for | |example, 'Search also for | |related subjects'). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This removes <span> tags |This removes <span> tags release notes|incorrectly appearing |incorrectly displayed |around the options |around the links for |available when 'Did you |options available when 'Did |mean?' is enabled (for |you mean?' is enabled (for |example, 'Search also for |example, 'Search also for |related subjects'). |related subjects'). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137446|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137698&action=edit Bug 31069: fix <span> in OPAC search suggestions (Did you mean) == test plan == 1. Enable "Did you mean?": . go to Administration > Additional parameters > Did you mean? . put a tick in each plugin and save the configuration 2. In the OPAC, search for 'open source' 3. Without the patch you see escaped <span> after "Did you mean:" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works, PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |additional_work_needed Status|Pushed to master |ASSIGNED --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This broke tests: t/db_dependent/SuggestionEngine_ExplodedTerms.t Please fix ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137824&action=edit Bug 31069: Remove ExplodedTerms dependency on templates This patch removes the use of templates and CGI in ExplodedTerms by using the Koha::I18N library. The functionality on the package is too simple, and messing with the template paths complexity on the tests was too much, given we have a nice way to have translatable strings at the package level. This patch does that, and cleans up the test file as well, that required complex template and CGI mocking to run properly. To test: 1. Run: $ kshell k$ prove t/db_dependent/SuggestionEngine_ExplodedTerms.t => FAIL: It fails in master 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass 4. Follow the original test plan => SUCCESS: Things work 5. Enjoy the rest of the day and forget this ever happened Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Why did the patch broke SuggestionEngine_ExplodedTerms.t btw? I don't get it and might break other things if I use Koha::I18N in other places to clean up strings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #11)
Why did the patch broke SuggestionEngine_ExplodedTerms.t btw? I don't get it and might break other things if I use Koha::I18N in other places to clean up strings.
It was probably a unique case in the codebase. A template that is used from a .pm file that didn't use get_template_and_user that also had really complex and fragile mocks in the tests... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- wow thanks, no worries then ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |RESOLVED --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Can't reproduce the bug on 21.11. feel free to ask if backport needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- To spare testing time you can check the "Depends on:" field of the ticket. Here it links to bug 30733 which isn't in 21.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org