[Bug 27520] New: Adding new itemtype images to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Bug ID: 27520 Summary: Adding new itemtype images to carredart Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: vfaafia29@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 --- Comment #1 from Victoria Faafia <vfaafia29@gmail.com> --- Created attachment 115624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115624&action=edit patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Victoria Faafia <vfaafia29@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Victoria Faafia <vfaafia29@gmail.com> --- Bug 27520: Adding new itemtype images to carredart This patch adds 3 new itemtype images to carredart: boardgame(domino), zoom-in and zoom-out Test Plan 1. Go to Administration>item types>Modify item type 2. Click on the carredart tab that under choose an icon 3. Check that a these 3 icons have been added -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the itemtype images can be displayed in the OPAC and in the staff interface we currently need to add them in 2 places as one cannot access the image files of the other. Can you also add the files to koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/carredart please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115709&action=edit Bug 27520: (follow-up) Add copy of images to carredart icons in the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115745&action=edit Bug 27520: Adding new itemtype images to carredart This patch adds 3 new itemtype images to carredart: boardgame(domino), zoom-in and zoom-out Test Plan 1. Go to Administration>item types>Modify item type 2. Click on the carredart tab that under choose an icon 3. Check that a these 3 icons have been added Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115709|0 |1 is obsolete| | --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115746&action=edit Bug 27520: (follow-up) Add copy of images to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #7 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. Test Plan 1. Go to Administration>item types>modify item type 2. There should be a lock item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC 6. Repeat steps for all 3 icons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |vfaafia29@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Summary|Adding new itemtype images |Adding new itemtype images |to carredart |boardgame, zoom-in, and | |zoom-out to carredart --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122931&action=edit Bug 27520: Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart This patch adds new versions of the images which were created based on CC0-licensed public domain images: https://commons.wikimedia.org/wiki/File:Zoom_in_out,_Magnifier_icons.svg https://commons.wikimedia.org/wiki/File:Domino_tile_vertical-00-05.svg https://commons.wikimedia.org/wiki/File:Domino_tile_vertical-00-03.svg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27505 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Attachment #122931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Based on bug 27522 comment 22 I have decided to restore the original version of the icons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the| |This enhancement adds release notes| |boardgame, zoom-in and | |zoom-out images to the | |carredart icon set for item | |types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org