https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28633 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21978 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |nick@bywatersolutions.com, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- There was a try at doing this by surrounding name fields by spans, bug 24710, in the template includes, but it became clear that wasn't an option as the no_html option on the includes, used for title elements, precludes us from using said spans. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #2)

patron-title.inc currently allows for the following output formats

* surname (othernames) * <span class="patron-title">title</span> surname, firstname (othernames) * <span class="patron-title">title</span> firtname (othernames) surname * title surname, firstname (othernames) * title firstname (othernames) surname * surname (othernames) (cardnumber) * <span class="patron-title">title</span> surname, firstname (othernames) (cardnumber) * <span class="patron-title">title</span> firtname (othernames) surname (cardnumber) * title surname, firstname (othernames) (cardnumber) * title firstname (othernames) surname (cardnumber) * cardnumber * <span>A patron from library [% Branches.GetName( patron.branchcode ) | html -%]</span>

I like the idea of having clearer definitions on when to use what. Long, short, anonymous? The versions with span and without are for use in the title tag. And you'd probably still want title/no title. Probably would be nice to see how often each is used to see if we could replace one or another or if there is a good reason for them to be needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Sarah, thx for weighing in. Just a note: 22.11 will have 2 new fields: pronouns and middle name. So you will be able to move from title to pronouns if you'd like. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com --- Comment #8 from holly@bywatersolutions.com --- Patron account display: It would be great if there were a way to hide particular name fields from patron account display pages. Example: A library uses "other name" for legal name when a patron goes by a different first name but the library needs to record the legal name as well. Currently, this displays as First (Other) Last. Staff only need to see first name and last name, out of respect for patron privacy and avoiding confusion. The library wants to hide the "other name" from all places where a patron name displays except for the account creation/editing screen. This could potentially be controlled with a system preference, something like "If using the Other Name field in patron records, show/hide Other Name." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #9)

Created attachment 175338 [details] [review] Bug 30568: Add classes to patron title components

to test: 1 - have a patron with data in firstname, surname, middle name, othernames, and preferred name 2 - view patron name in patron record and other places where patron.title is used, confirm lack of HTML markup 3 - apply patch, restart services 4 - reload patron record and other pages around Koha, confirm name display hasn't changed but the composite parts of the name are now marked with classes

I've only done the staff side here, though it shouldn't be hard to do the same on the OPAC. I've gone very minimal here, just inserting spans and classes around the different parts of the name. That should allow the local use of jQuery to further customize and reorder them all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175351&action=edit Bug 30568: Add classes to name components in OPAC To test: 1- have a patron with values in all parts of name (firstname, preferred name, surname, othername, middlename) 2- log into OPAC as patron, observe where are how name is displayed, lack of classes on component parts 3- apply patch 4- reload OPAC pages, observe name looks the same but now has classes when inspected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #12)

This breaks some strings where the no_html flag is passed. For example, go to the hold history for a patron with this applied and view the title element:

<title>Holds history for <span class='preferred_name'>Ronnie</span> <span class='surname'>Ballard</span> <span class='cardnumber'>(23529000139858)</span> › Patrons › Koha</title>

It's attempting to pass in HTML when it shouldn't.

Updated the intranet patch to account for no_html. It doesn't look like a comparable flag exists on the OPAC. Here's the title of a hold history page without my patches: <title>Holds history for Jim Andrew (Ace) Acevedo (23529000035676) › Patrons › Koha</title> "› Patrons › Koha" seems to be there before my code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175351|0 |1 is obsolete| | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175910&action=edit Bug 30568: Add classes to name components in OPAC To test: 1- have a patron with values in all parts of name (firstname, preferred name, surname, othername, middlename) 2- log into OPAC as patron, observe where are how name is displayed, lack of classes on component parts 3- apply patch 4- reload OPAC pages, observe name looks the same but now has classes when inspected Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Anni Mäki-Mantila <anni.maki-mantila@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anni.maki-mantila@turku.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175911|0 |1 is obsolete| | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186505&action=edit Bug 30568: Add classes to component name parts in intranet to test: 1 - have a patron with all name parts 2 - load pages with a variety of name displays, confirm lack of classes 3 - apply patch 4 - reload pages from step 2, confirm there are now classes *except for where the name is called with no_html, like a page title Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Rebased for current main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Brendan Lawlor <blawlor@clamsnet.org> --- As is this breaks links in the staff interface in the patron column of tables where patron-title.inc is included like the holds tab of a bib and the holds queue. It looks like it's caused by a recent change in bug 38714 and the rebase. Specifically starting at line 62: [%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] [%- IF link_to == 'circulation_reserves' -%] <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#reserves"> </a> [%- ELSIF link_to == 'circulation_recalls' -%] <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#recalls"> </a> [%- ELSIF link_to == 'members_pay' -%] <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[%- patron.borrowernumber | uri -%]"> </a> [%- ELSE -%] <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[%- data.borrowernumber | uri -%]"> </a> [%- END -%] [%- END -%] These are rendered as empty links now. Prior to bug 38714 these anchor tags were left open and at then closed at the end of patron-title.inc lke this: [%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] </a> [%- END -%] I think it would be clearest now if that logic to wrap the display name in an anchor tag is brought inside [%- BLOCK display_patron_name -%] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186504|0 |1 is obsolete| | Attachment #186505|0 |1 is obsolete| | --- Comment #21 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 187420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187420&action=edit Bug 30568: Add classes to component name parts in intranet This patch adds a wrapper function in patron-title.inc that can be used to either span, or not if no html requested It replaces the same concept that was used for patron title to test: 1 - have a patron with all name parts 2 - load pages with a variety of name displays, confirm lack of classes 3 - apply patch 4 - reload pages from step 2, confirm there are now classes *except for where the name is called with no_html, like a page title 5 - Check page titles, patron search, placing a hold, patron search and confirm different links and views work as before -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- For all your ROYGBV testing needs: .patron_title { color: red; } .preferred_name { color: orange; } .middle_name { color: yellow; } .othernames { color: green; } .surname { color: blue; } .patronpronouns { color: purple; } -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187421|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187495&action=edit Bug 30568: Add classes to name components in OPAC To test: 1- have a patron with values in all parts of name (firstname, preferred name, surname, othername, middlename) 2- log into OPAC as patron, observe where are how name is displayed, lack of classes on component parts 3- apply patch 4- reload OPAC pages, observe name looks the same but now has classes when inspected Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|andrew@bywatersolutions.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187704&action=edit Bug 30568: Correct reference to patron_title in patron-title.inc In the staff interface we set the class for the patron's title (Mr/Mrs/etc) to "patron_title," but we were making it "patron-title" in the OPAC. This patch standardizes them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187494|0 |1 is obsolete| | --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187740&action=edit Bug 30568: Add classes to component name parts in intranet This patch adds a wrapper function in patron-title.inc that can be used to either span, or not if no html requested It replaces the same concept that was used for patron title to test: 1 - have a patron with all name parts 2 - load pages with a variety of name displays, confirm lack of classes 3 - apply patch 4 - reload pages from step 2, confirm there are now classes *except for where the name is called with no_html, like a page title 5 - Check page titles, patron search, placing a hold, patron search and confirm different links and views work as before Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187660|0 |1 is obsolete| | --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187742&action=edit Bug 30568: Add maybe_span to opac patron-title Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187740|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187785&action=edit Bug 30568: Add classes to component name parts in intranet This patch adds a wrapper function in patron-title.inc that can be used to either span, or not if no html requested It replaces the same concept that was used for patron title to test: 1 - have a patron with all name parts 2 - load pages with a variety of name displays, confirm lack of classes 3 - apply patch 4 - reload pages from step 2, confirm there are now classes *except for where the name is called with no_html, like a page title 5 - Check page titles, patron search, placing a hold, patron search and confirm different links and views work as before Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187742|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187787&action=edit Bug 30568: Add maybe_span to opac patron-title Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|blawlor@clamsnet.org |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #39)

I would like to note that we have currently an interesting tree in the queue (under bug 40995) which improve the JS counterpart (patron-format). The inc file is moved to a standalone JS file, Cypress tests are added, and more places are using it.

I do understand that we want to make the display more flexible, but here we need to keep the 2 versions in sync: they have the same purpose. However we don't include html tags in the JS function yet (why?)

I don't want to block it, but keep in mind that you are not affecting all the occurrences, which introduces more inconsistencies IMO.

A better solution seems to have a new syspref to let libraries provide their desire format, you could pick patron's fields, and add punctuation.

The both (tt and js) versions of the code will use it.

Maybe for a follow-up bug?

Hope that makes sense!

I have filed that follow-up: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41069 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I believe this has broken a selenium test, t/db_dependent/selenium/patrons_search.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Seems like removing one the html filters is what is needed, but the QA tools won't like that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00, 25.05.08 |25.11.00,25.05.08 released in| | -- You are receiving this mail because: You are watching all bug changes.