[Bug 39816] New: Allow embedding `late_since_days`in baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Bug ID: 39816 Summary: Allow embedding `late_since_days`in baskets Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Some places, like the late orders table, display this info. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32266 [Bug 32266] Large amount of late orders slows the service -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181879&action=edit Bug 39816: Allow embedding `late_since_days` in baskets This patch adds the option to embed the return value of the `late_since_days` method in basket objects in the REST API. It does so by just adding it to the list of embeds in the spec. It is added in every place baskets can be returned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181880&action=edit Bug 39816: (follow-up) Harmonize embeds in baskets As I traversed the REST API spec to add the `late_since_days` embed option, I noticed an inconsistency in the embed options we defined in each place a basket is to be returned. This patch makes all the places have the same embed options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m, | |Laura.escamilla@bywatersolu | |tions.com, | |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181879|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181881&action=edit Bug 39816: Allow embedding `late_since_days` in baskets This patch adds the option to embed the return value of the `late_since_days` method in basket objects in the REST API. It does so by just adding it to the list of embeds in the spec. It is added in every place baskets can be returned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181880|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181882&action=edit Bug 39816: (follow-up) Harmonize embeds in baskets As I traversed the REST API spec to add the `late_since_days` embed option, I noticed an inconsistency in the embed options we defined in each place a basket is to be returned. This patch makes all the places have the same embed options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Patch doesn't apply: Applying: Bug 39816: Allow embedding `late_since_days` in baskets Using index info to reconstruct a base tree... M api/v1/swagger/definitions/basket.yaml M api/v1/swagger/paths/acquisitions_baskets.yaml M api/v1/swagger/paths/acquisitions_orders.yaml Falling back to patching base and 3-way merge... Auto-merging api/v1/swagger/paths/acquisitions_orders.yaml Auto-merging api/v1/swagger/paths/acquisitions_baskets.yaml CONFLICT (content): Merge conflict in api/v1/swagger/paths/acquisitions_baskets.yaml Auto-merging api/v1/swagger/definitions/basket.yaml CONFLICT (content): Merge conflict in api/v1/swagger/definitions/basket.yaml error: Failed to merge in the changes. Patch failed at 0001 Bug 39816: Allow embedding `late_since_days` in baskets hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-39816-Allow-embedding-latesincedays-in-baskets-7u_k12.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181881|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182069&action=edit Bug 39816: Allow embedding `late_since_days` in baskets This patch adds the option to embed the return value of the `late_since_days` method in basket objects in the REST API. It does so by just adding it to the list of embeds in the spec. It is added in every place baskets can be returned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181882|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182070&action=edit Bug 39816: (follow-up) Harmonize embeds in baskets As I traversed the REST API spec to add the `late_since_days` embed option, I noticed an inconsistency in the embed options we defined in each place a basket is to be returned. This patch makes all the places have the same embed options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182069|0 |1 is obsolete| | --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 182329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182329&action=edit Bug 39816: Allow embedding `late_since_days` in baskets This patch adds the option to embed the return value of the `late_since_days` method in basket objects in the REST API. It does so by just adding it to the list of embeds in the spec. It is added in every place baskets can be returned. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182070|0 |1 is obsolete| | --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 182330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182330&action=edit Bug 39816: (follow-up) Harmonize embeds in baskets As I traversed the REST API spec to add the `late_since_days` embed option, I noticed an inconsistency in the embed options we defined in each place a basket is to be returned. This patch makes all the places have the same embed options. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Tested with bug 32266, works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182329|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186771&action=edit Bug 39816: Allow embedding `late_since_days` in baskets This patch adds the option to embed the return value of the `late_since_days` method in basket objects in the REST API. It does so by just adding it to the list of embeds in the spec. It is added in every place baskets can be returned. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182330|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186772&action=edit Bug 39816: (follow-up) Harmonize embeds in baskets As I traversed the REST API spec to add the `late_since_days` embed option, I noticed an inconsistency in the embed options we defined in each place a basket is to be returned. This patch makes all the places have the same embed options. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This all works, but I find the term 'last_since_days' really confusing personally.. since what. Anywho.. I'm sure it works so I'll pass it.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 --- Comment #14 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #13)
This all works, but I find the term 'last_since_days' really confusing personally.. since what.
Anywho.. I'm sure it works so I'll pass it..
What do you think of ‘days_late’? I’m really not sure. I just reused what’s in there. Happy to review if there’s a better idea -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Passed QA |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- +1 for "days_late". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow embedding |Allow embedding `days_late` |`late_since_days`in baskets |in baskets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 --- Comment #16 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 187542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187542&action=edit Bug 39816: (QA follow-up) Rename 'late_since_days' to 'days_late' Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This development adds the release notes| |ability to embed | |information on late days on | |the basket objects | |retrieved from the API. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00, 25.05.08 released in| | Status|Pushed to main |Needs documenting --- Comment #18 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Backported to 25.05 thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact 24.11 LTS since there is a method change in Koha/Acquisition/Basket.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39816 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00, 25.05.08 |25.11.00,25.05.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org