[Bug 28073] New: Patron modifications should auto-open panel for referring patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Bug ID: 28073 Summary: Patron modifications should auto-open panel for referring patron record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 27873 The "Pending patron modifications" link from the checkout or patron details page should pass the borrowernumber so that the patron update page can expand the correct panel. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119118&action=edit Bug 28073: Patron modifications should auto-open panel for referring patron record This patch makes it possible to link directly to the correct panel on the "Update patron records" page. The link on the checkout and patron details screen has been updated to read "Patron has pending modifications." Also changed: Moved the "Patron's address in doubt" message so that it is above the table of changed fields. To test, apply the patch and if necessary submit patron modification requests from multiple patrons via the OPAC. - Open the checkout page for one of these patrons. - If you are logged in as a user with permission to edit patron records you should see a message, "Pending modifications: Review pending modifications," which links to the pending modifications page. - Clicking the link should open the page for reviewing pending patron modifications, and the correct panel should be automatically expanded. - If you are logged in as a user without permission to edit patrons you should see the message "Pending modifications: Patron has pending modifications," which isn't linked. - The process should work exactly the same from the patron detail page. - Following the "Pending modifications" link from the staff interface home page or the patrons home page should work as before: The page opens with the first panel expanded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Failed QA --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> ---
- Open the checkout page for one of these patrons. - If you are logged in as a user with permission to edit patron records you should see a message, "Pending modifications: Review pending modifications," which links to the pending modifications page.
On the checkout page, the message (without link) is the same for users with and without the patron modification permission. Except that point, the patch works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Séverine Queune from comment #2)
On the checkout page, the message (without link) is the same for users with and without the patron modification permission.
I can't reproduce this problem. Can you double-check that the "edit_borrowers" permission is the one you're setting, and that you're logging that user out and back in after changing permissions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119118|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 119128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119128&action=edit Bug 28073: Patron modifications should auto-open panel for referring patron record This patch makes it possible to link directly to the correct panel on the "Update patron records" page. The link on the checkout and patron details screen has been updated to read "Patron has pending modifications." Also changed: Moved the "Patron's address in doubt" message so that it is above the table of changed fields. To test, apply the patch and if necessary submit patron modification requests from multiple patrons via the OPAC. - Open the checkout page for one of these patrons. - If you are logged in as a user with permission to edit patron records you should see a message, "Pending modifications: Review pending modifications," which links to the pending modifications page. - Clicking the link should open the page for reviewing pending patron modifications, and the correct panel should be automatically expanded. - If you are logged in as a user without permission to edit patrons you should see the message "Pending modifications: Patron has pending modifications," which isn't linked. - The process should work exactly the same from the patron detail page. - Following the "Pending modifications" link from the staff interface home page or the patrons home page should work as before: The page opens with the first panel expanded. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Problem was on my devbox, works perfectly on sandbox ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, this is BLOCKED right now, we still need a sign-off on bug 27873! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Bug 28073 depends on bug 27873, which changed state. Bug 27873 Summary: Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119128|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123163&action=edit Bug 28073: Patron modifications should auto-open panel for referring patron record This patch makes it possible to link directly to the correct panel on the "Update patron records" page. The link on the checkout and patron details screen has been updated to read "Patron has pending modifications." Also changed: Moved the "Patron's address in doubt" message so that it is above the table of changed fields. To test, apply the patch and if necessary submit patron modification requests from multiple patrons via the OPAC. - Open the checkout page for one of these patrons. - If you are logged in as a user with permission to edit patron records you should see a message, "Pending modifications: Review pending modifications," which links to the pending modifications page. - Clicking the link should open the page for reviewing pending patron modifications, and the correct panel should be automatically expanded. - If you are logged in as a user without permission to edit patrons you should see the message "Pending modifications: Patron has pending modifications," which isn't linked. - The process should work exactly the same from the patron detail page. - Following the "Pending modifications" link from the staff interface home page or the patrons home page should work as before: The page opens with the first panel expanded. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported for 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron modifications should |Make patron modifications |auto-open panel for |auto-open panel for |referring patron record |referring patron record CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org