[Bug 19180] New: Vendor name is missing from breadcrumbs when closing an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Bug ID: 19180 Summary: Vendor name is missing from breadcrumbs when closing an order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When an open basket/order is closed, the breadcrumbs on the page asking about adding the order to a basket group is missing the vendor name in the breadcrumbs in 2 spots: Home › Acquisitions › › Basket Test bug 15347 (1) for -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66517&action=edit Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19118 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- *grumbles about having to set up budgets, funds, AND a vendor* ;) Before: Home › Acquisitions › › Basket test basket (1) for After: Home › Acquisitions › Test › Basket test basket (1) for Test Link works. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66517|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 66562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66562&action=edit Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We are on basket.pl, sending a "name" variable to the template that is actually the "vendor name" can lead to issue. Let's rename it with "bookseller_name" or whatever more meaningful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66603&action=edit Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Error message : fatal: sha1 information is lacking or useless (acqui/basket.pl). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66562|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 67029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67029&action=edit Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66603|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 67030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67030&action=edit Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67030|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 67031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67031&action=edit Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67031|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 67032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67032&action=edit Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Caroline Cyr La Rose from comment #6)
Error message :
fatal: sha1 information is lacking or useless (acqui/basket.pl).
Because someone did a 'basketno | html' tweak to the template file. Easy enough to rebase and compare. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67032|0 |1 is obsolete| | --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 67156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67156&action=edit Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67029|0 |1 is obsolete| | Attachment #67156|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67213&action=edit Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67214&action=edit Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Doesn't apply cleanly to 16.11.x (second patch conflicts), please rebase if you want this to be included. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19180 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I checked - the bug exists in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org