[Bug 36826] New: Incorrect instantiations of CGI ::->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826 Bug ID: 36826 Summary: Incorrect instantiations of CGI ::-> Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Koha/Uploader.pm: my $query = CGI::->new( sub { $self->_hook(@_); }, {}, 0 ); opac/opac-retrieve-file.pl:my $input = CGI::->new; tools/upload.pl:my $input = CGI::->new; This ::-> looks wrong -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #0)
Koha/Uploader.pm: my $query = CGI::->new( sub { $self->_hook(@_); }, {}, 0 ); opac/opac-retrieve-file.pl:my $input = CGI::->new; tools/upload.pl:my $input = CGI::->new;
This ::-> looks wrong
It is not wrong. And theoretically perhaps even safer. But not consistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Indeed it is correct: https://perldoc.perl.org/perlobj#Invoking-Class-Methods -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Marking as invalid or we update for consistency? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
Marking as invalid or we update for consistency?
If those three are the only ones, I would not mind updating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Julian Maurice from comment #2)
Indeed it is correct: https://perldoc.perl.org/perlobj#Invoking-Class-Methods
Learn something new every day... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org