http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7036|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-07 16:47:15 UTC --- Created attachment 7082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7082 Bug 7400: Add auto-completion on auth_finder While typing an authority, will automatically propose authorities (similar to autocompletion for patron search if activated) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tested searching for authorities with and without autocomplete. Note that this is most useful when used in the "Main entry" box instead of the "Main entry ($a only)" box. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-01-19 10:21:50 UTC --- QA comment: You add a new nsb_clean function. This function is already present in cataloguing/ysearch.pl. Isn't better to factorize it in a C4 module ? Why do you comment the "use warning" line ? You can now use Modern::Perl instead of use strict; use warnings; :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> 2012-02-29 15:41:09 UTC --- The nsb_clean function has been added to C4::Charset and removed from the two ysearch.pl Indeed, "use warnings" had no reason to be commented. It has been removed and replaced by "use Modern::Perl" in both ysearch.pl's. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7944|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 7993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7993&action=edit Signed-off patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> --- Uses the Switch module, which I believe is considered deprecated for 5.12+. See http://www.perlmonks.org/?node_id=931583. Since 5.10, there is a built-in switch operator, then given/when syntax. Since Koha is now based on 5.10 minimum, we can safely depend on this. See http://perldoc.perl.org/perlsyn.html#Switch-statements. Marking Failed QA until the dependency on Switch is removed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8120|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8142&action=edit Bug 7400: Add auto-completion on auth_finder While typing an authority, will automatically propose authorities (similar to autocompletion for patron search if activated) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tested searching for authorities with and without autocomplete. Note that this is most useful when used in the "Main entry" box instead of the "Main entry ($a only)" box. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Corrected tabs to spaces in auth-finder-search.inc while resolving merge conflict. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Now that the dependency on Switch has been removed, this code looks good to me. Moves nsb_clean to C4/Charset.pm, which increases usability. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7400 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #11)

patch pushed, but i'm wondering if we should not have a syspref to activate/desactivate all auto-completion things. This one is not managed by any syspref, couldn't it be a performance problem for some libraries ?

I agree first thing I do is disable auto completes as it works the db hard. -- You are receiving this mail because: You are watching all bug changes.