[Bug 8739] New: Partial Fine Payments Saving Amount Paid Incorrectly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Priority: P5 - low Change sponsored?: --- Bug ID: 8739 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Partial Fine Payments Saving Amount Paid Incorrectly Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha When making payments, the amount paid is meant to be stored as a negative number. C4::Accounts::makepayment does this correctly. However C4::Accounts::makepartialpayment saves the amount as a positive number. This means the payment shows up as a fine with no balance outstanding on the borrowers record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12057&action=edit Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Component|Circulation |Patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Can you please add a test plan for this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- * Create two fines * Make a partial payment one fine 1, make a full payment on the other * Look at the fines in koha, one payment will be green, the other red. This reflects the positive or negative signed-ness of the payment. * Apply the patch and repeat. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12057|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12256&action=edit [SIGNED-OFF] Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Confirmed using test plan that the display is corrected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * the makepayement sub also reverse the amount paid: # create new line my $payment = 0 - $amount; my $ins = $dbh->prepare( "INSERT INTO accountlines (borrowernumber, accountno, date, amount, itemnumber, description, accounttype, amountoutstanding, manager_id) VALUES ( ?, ?, now(), ?, ?, 'Payment,thanks', 'Pay', 0, ?)" ); so it's consistent * tiny patch (and it's a bugfix !) * koha-qa.pl OK (there were 2 perlcritic violations, that were not related to this patch, and that i've fixed) passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org