[Bug 42483] New: HoldsQueuePrioritizeBranch description should say hold pickup library instead of patron's home libary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42483 Bug ID: 42483 Summary: HoldsQueuePrioritizeBranch description should say hold pickup library instead of patron's home libary Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com The description for HoldsQueuePrioritizeBranch reads "The holds queue should prioritize filling a hold by matching the patron's home library with an item having a matching (home library / holding library)." However, it actually attempts to match the hold pickup branch to either the item homebranch or the item holdingbranch. It should be reworded. To confirm the current behavior: - have transport cost matrix and LocalHoldsPriority off - Have a patron with home of Branch A - Have a bib with two available items -- Item 1 is homebranch and holdingbranch A -- Item 2 is homebranch and holdingbranch B - place a hold for your patron patron to be picked up at Branch B - build holds queue - see it targets the item at Branch B (hold pickup) rather than the item at branch A (patron home) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42483 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42483 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42483 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198297&action=edit Bug 42483: Correct description of HoldsQueuePrioritizeBranch system preference To test: Confirm behavior: 1: have a patron from Library A 2: have a bib with two items Item 1: homebranch = Library A, holdingbranch = Library B Item 2: homebranch = Library B, holdingbranch = Library A 3: Place a hold on your bib for your patron for pickup at Library B 4: Set HoldsQueuePrioritizeBranch to homebranch 5: Build holds queue 6: Confirm the queue has targeted Item 2 (pickup branch = item homebranch) 7: Set HoldsQueuePrioritizeBranch to holdingbranch 8: Build holds queue 9: Confirm the queue has targeted Item 1 (pickup branch = item holdingbranch) 10: Apply patch 11: Reload HoldsQueuePrioritizeBranch system preference 12: Confirm it now reads "The holds queue should prioritize filling a hold by matching the pickup library with an item ..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42483 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42483 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I attempted to test, but didn't get the results in the test plan (before the patch) (hopefully I've tested correctly): 1. Logged in as koha with Centerville as library. 2. Used: - Mary Burton (Midway - Library A) - Effective Perl programming (139) - Changed item locations: . Item 1 - 39999000005776: Home library = Midway (Library A), Current library = Centerville (Library B) . Item 2 - 39999000005790: Home library = Centerville (Library B), Current library = Midway (Library A) 3. Build holds queue: . misc/cronjobs/holds/build_holds_queue.pl . restart_all (not sure if this is required) 4. For step 6 - HoldsQueuePrioritizeBranch to home library (homebranch = Midway?): Centerville: - Holds queue has targeted Item 1 for pickup at Centerville - 39999000005776 (Current library = Centerville, Home library = Midway) for pickup - "Send to" column has "Centerville" Midway: nothing in the holds queue 5. For step 9 - HoldsQueuePrioritizeBranch to holding library (holdingbranch = Centerville?): Centerville: nothing in the holds queue Midway: - Holds queue has targeted Item 2 for pickup at Centerville - 39999000005790 (Current library = Midway, Home library = Centerville) for pickup - "Send to" column has "Centerville" Current description for HoldsQueuePrioritizeBranch: The holds queue should prioritize filling a hold by matching the patron's home library with an item having a matching - holding library (holdingbranch) - home library (homebranch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42483 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I've retested and get the behavior I've described in my test plan. I've also confirmed in the holds queue code that we're using pickup branch rather than patron home library: https://github.com/Koha-Community/Koha/blob/f0436bd140eeb5f9f690bdd36420a8ff... In my initial bug report I described how to demonstrate that we're using pickup library rather than patron library with two items where homebranch and holdingbranch are the same. I made the test plan more complicated in order to demonstrate different item selection based on the system preference value, but that's not strictly necessary to confirm that it's matching to pickup branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42483 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #4 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this in a sandbox and yes, it seems that it attempts to match the hold pickup branch to homebranch/holdingbranch. I'm not sure if this belongs to this bugs scope, but it also seems that holds queue prioritizes homebranch even when holdingbranch is selected to the HoldsQueuePrioritizeBranch. Holdingbranch is used only when there is no available item with pickup branch matching homebranch. Item 1: homebranch = Library A, holdingbranch = Library B Item 2: homebranch = Library B, holdingbranch = Library A Pickup branch = Library B Holds queue targets Item 1 even when Item 2 is located in Library B. Item 2 is targeted only when Item 1's homebranch is changed to something else. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org