[Bug 21647] New: Clean up SRU fields mapping templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Bug ID: 21647 Summary: Clean up SRU fields mapping templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 19436 Blocks: 20654 The SRU fields mapping administration templates have several issues which need to be cleaned up: - Bootstrap grid - JavaScript to the footer - Markup corrections Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 [Bug 19436] Add SRU support for authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81076&action=edit Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." -- You are receiving this mail because: You are watching all bug changes.
From line 122, column 5; to line 122, column 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- For authorities, these unexplained errors happen in validation. Error: End tag div seen, but there were open elements. form>↩ </div>↩↩↩↩↩↩ Error: Unclosed element main.
From line 62, column 5; to line 62, column 10 id">↩↩ <main>↩ Error: Stray end tag div. From line 129, column 9; to line 129, column 14 ↩↩ </div>↩↩
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81076|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81132&action=edit Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81132|0 |1 is obsolete| | --- Comment #4 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 81341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81341&action=edit Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81341|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81365&action=edit Bug 21647: Clean up SRU fields mapping templates This patch makes corrections to the SRU field mapping templates (bibliographic and authority): - Bootstrap grid - JavaScript to the footer - Other markup corrections To test, apply the patch and go to Administration -> Z39.50/SRU servers - Add or edit an SRU server - Click "Modify" next to the SRU search fields mapping field. - Confirm that the popup window layout is correct. - Confirm that adding information to the form is correctly saved to the SRU server form. - Test this process with SRU server record type set to both "Authority" and "Bibliographic." Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org