[Bug 20435] New: Allow lowercase prefix in inventory value builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Bug ID: 20435 Summary: Allow lowercase prefix in inventory value builder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Cataloging value builders for inventory stocknumberAV.pl and stocknumberam123.pl use a regexp to define if entered text is a prefix or not. It actually only allows uppercase characters. A library may want to catalog with lowercase characters in inventory number and using those value builders. Note that in database the text is not case-sensitive. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 73047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73047&action=edit Bug 20435: Allow lowercase prefix in inventory value builder Cataloging value builders for inventory stocknumberAV.pl and stocknumberam123.pl use a regexp to define if entered text is a prefix or not. It actually only allows uppercase characters. A library may want to catalog with lowercase characters in inventory number and using those value builders. Note that in database the text is not case-sensitive. Test plan: 1) Configure stocknumberAV.pl value builder on an item subfield 2) Create an autorized value category 'INVENTORY' 3) Create in this category a value with code 'UC' and description '10' 4) Create in this category a value with code 'lc' and description '20' 5) Create a new item 6) Focus on stocknumber subfield 7) Enter '123' and click on value builder, the entry stays '123' 8) Enter 'UC' and click on value builder, the entry turn to 'UC 0000000011' 9) Enter 'lc' and click on value builder, the entry turn to 'lc 0000000021' Same for stocknumberam123.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73047|0 |1 is obsolete| | --- Comment #2 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80733&action=edit Bug 20435: Allow lowercase prefix in inventory value builder Cataloging value builders for inventory stocknumberAV.pl and stocknumberam123.pl use a regexp to define if entered text is a prefix or not. It actually only allows uppercase characters. A library may want to catalog with lowercase characters in inventory number and using those value builders. Note that in database the text is not case-sensitive. Test plan: 1) Configure stocknumberAV.pl value builder on an item subfield 2) Create an autorized value category 'INVENTORY' 3) Create in this category a value with code 'UC' and description '10' 4) Create in this category a value with code 'lc' and description '20' 5) Create a new item 6) Focus on stocknumber subfield 7) Enter '123' and click on value builder, the entry stays '123' 8) Enter 'UC' and click on value builder, the entry turn to 'UC 0000000011' 9) Enter 'lc' and click on value builder, the entry turn to 'lc 0000000021' Same for stocknumberam123.pl To elaborate on step #1: Go to Administration->MARC Bibliographic framework Click on the "Action" button to view the framework for the item you will be creating, view MARC structure. Search for Tag 952 (LOCATION AND ITEM INFORMATION (KOHA)) Select Actions->Subfields Edit subfield i for "Inventory Number" In the "Other options" pane, select the plugin to test. Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81367&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81367|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 81367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81367 k Typo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80733|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81368&action=edit Bug 20435: Allow lowercase prefix in inventory value builder Cataloging value builders for inventory stocknumberAV.pl and stocknumberam123.pl use a regexp to define if entered text is a prefix or not. It actually only allows uppercase characters. A library may want to catalog with lowercase characters in inventory number and using those value builders. Note that in database the text is not case-sensitive. Test plan: 1) Configure stocknumberAV.pl value builder on an item subfield 2) Create an autorized value category 'INVENTORY' 3) Create in this category a value with code 'UC' and description '10' 4) Create in this category a value with code 'lc' and description '20' 5) Create a new item 6) Focus on stocknumber subfield 7) Enter '123' and click on value builder, the entry stays '123' 8) Enter 'UC' and click on value builder, the entry turn to 'UC 0000000011' 9) Enter 'lc' and click on value builder, the entry turn to 'lc 0000000021' Same for stocknumberam123.pl To elaborate on step #1: Go to Administration->MARC Bibliographic framework Click on the "Action" button to view the framework for the item you will be creating, view MARC structure. Search for Tag 952 (LOCATION AND ITEM INFORMATION (KOHA)) Select Actions->Subfields Edit subfield i for "Inventory Number" In the "Other options" pane, select the plugin to test. Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit we use a variation of this plugin that allows any prefix - numbers too. The most common use case here is having the year as prefix. 2018/1... But this patch works of course :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org