https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25156 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |bernard.scaife@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 ashley.day@rcm.ac.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ashley.day@rcm.ac.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 180475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180475&action=edit Bug 34025: Make more controlled fields linkable (130, 240, 730 + 7XX $a + $t) [XSLT] MARC21 contain linking fields (130, 240, 730 + 7XX $a + $t) that currently currently are not 'clickable'. This patch adds the links, similarly to the links created for contributors', both in OPAC and staff interface. Test plan: ========== 1. Add some 130, 240, 730 + 7XX $a + $t fields to a record. Note that 730 and 7XX $a + $t fields have to have 2nd indicator set to 2. You can link the fields to authority records. 2. Not that the information displayed from these fields is not 'clickable' neither in OPAC, nor in the staff interface. 3. Apply the patch ; restart all. 4. You should be able to see and use the links now. If the fields are linked to authotiry record and UseAuthoritiesForTracings systempreference is set, the search will be performed with authid identifier. There should be also a magnifying glass icon with a link to the authority record. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |Main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180475|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 180681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180681&action=edit Bug 34025: Make more controlled fields linkable (130, 240, 730 + 7XX $a + $t) [XSLT] MARC21 contain linking fields (130, 240, 730 + 7XX $a + $t) that currently currently are not 'clickable'. This patch adds the links, similarly to the links created for contributors', both in OPAC and staff interface. Test plan: ========== 1. Add some 130, 240, 730 + 7XX $a + $t fields to a record. Note that 730 and 7XX $a + $t fields have to have 2nd indicator set to 2. You can link the fields to authority records. 2. Not that the information displayed from these fields is not 'clickable' neither in OPAC, nor in the staff interface. 3. Apply the patch ; restart all. 4. You should be able to see and use the links now. If the fields are linked to authotiry record and UseAuthoritiesForTracings systempreference is set, the search will be performed with authid identifier. There should be also a magnifying glass icon with a link to the authority record. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183702|0 |1 is obsolete| | --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 183703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183703&action=edit Bug 34025: Changing default link search from au to ti,phr for X30 fields as they are are title type ones. These apply if there is no authorised term linked to for the content -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Bernard <bernard.scaife@openfifth.co.uk> --- Works as described -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183704|0 |1 is obsolete| | --- Comment #9 from Bernard <bernard.scaife@openfifth.co.uk> --- Created attachment 184151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184151&action=edit Bug 34025: Changing default link search from au to ti,phr for X30 fields as they are are title type ones. These apply if there is no authorised term linked to for the content Test plan: ========== 1. Add some 130, 240, 730 + 7XX $a + $t fields to a record. Note that 730 and 7XX $a + $t fields have to have 2nd indicator set to 2. You can link the fields to authority records. Ensure that one of the fields is not linkable to an authority record and leave it unlinked. 2. Note that the information displayed from these fields is not 'clickable' neither in OPAC, nor in the staff interface. 3. Apply the patch ; restart all. 4. You should be able to see and use the links now. If the fields are linked to authotiry record and UseAuthoritiesForTracings systempreference is set, the search will be performed with authid identifier. There should be also a magnifying glass icon with a link to the authority record. 5. The links for any unlinked authority should now point to ti,phr - eg /cgi-bin/koha/catalogue/search.pl?q=ti,phr:%22Uniform%20Bernard%22 instead of au 6. Click that link and ensure it finds at least one record (the one you started with) Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180681|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185830&action=edit Bug 34025: Make more controlled fields linkable (130, 240, 730 + 7XX $a + $t) [XSLT] MARC21 contain linking fields (130, 240, 730 + 7XX $a + $t) that currently currently are not 'clickable'. This patch adds the links, similarly to the links created for contributors', both in OPAC and staff interface. Test plan: ========== 1. Add some 130, 240, 730 + 7XX $a + $t fields to a record. Note that 730 and 7XX $a + $t fields have to have 2nd indicator set to 2. You can link the fields to authority records. 2. Not that the information displayed from these fields is not 'clickable' neither in OPAC, nor in the staff interface. 3. Apply the patch ; restart all. 4. You should be able to see and use the links now. If the fields are linked to authotiry record and UseAuthoritiesForTracings systempreference is set, the search will be performed with authid identifier. There should be also a magnifying glass icon with a link to the authority record. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185832&action=edit Bug 34025: (follow-up) Fix subfield $t handling for 7XX contained works When 7XX fields contain both name ($a) and title ($t) subfields, the link should search for the title rather than the name. This is important for contained works that reference titles within larger works. This patch updates both intranet and OPAC XSLT files to check for the presence of subfield $t and use title search (ti,phr:) instead of author search (au:) when $t is present. Test plan: 1. Find or create a bibliographic record with 7XX fields containing both $a (name) and $t (title) subfields - For example: 700 $a Smith, John $t The Great Adventure 2. View the record detail page in both staff interface and OPAC 3. In the "Contained works" section, click on the link for the 7XX field entry 4. Verify the search is performed as a title search (ti,phr:"The Great Adventure") rather than author search (au:"Smith, John") 5. Confirm the search results show records matching the title from subfield $t 6. Test with records that have 7XX fields with only $a subfields to ensure they still search by author 7. Repeat testing for different 7XX field types (700, 710, 711) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Bernard from comment #13)

Test plan works in all scenarios except for the 130 or 730 (with indicator 2) fields. Same issue in both intranet and opac.

The X30 is rendered as a hyperlink but there is no content embedded in the link to search:

http://127.0.0.1:81/cgi-bin/koha/catalogue/search.pl?q=ti,phr:%22%22

Hi Bernard. That's strange. Could you please reexamine this? It is only now that I could return to this bug. I have added two fields to a record: 130 #0 $a Big Adventures Book $9 1708 730 02 $a Big Adventures Book $9 1708 As far as I can see, correct links are generated in OPAC: http://localhost:8080/cgi-bin/koha/opac-search.pl?q=ti,phr:%22Big%20Adventur... and in staff interface: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=ti,phr:%22Big%20Adv... So, could you please confirm that you put the tile for 130/730 in $a subfield? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) QA tools There is a fail that looks real - can you please check? [FAIL] koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl FAIL xml_valid 690: parser error : Opening and ending tag mismatch: for-each line 657 and a 703: parser error : Opening and ending tag mismatch: span line 656 and xsl:for-each 704: parser error : Opening and ending tag mismatch: if line 655 and span 705: parser error : Opening and ending tag mismatch: template line 18 and if 790: parser error : Opening and ending tag mismatch: a line 712 and xsl:for-each 791: parser error : Opening and ending tag mismatch: for-each line 710 and span 792: parser error : Opening and ending tag mismatch: span line 709 and xsl:if 1723: parser error : Opening and ending tag mismatch: if line 708 and template I tried to spot it, but failed :( 2) Breaking change? In my experience people are quite lenient cataloguing the indicators if they can get away with it - especially here where MARC is still quite a new thing and people first get in touch with it with Koha. - <xsl:for-each select="marc:datafield[@tag=130]|marc:datafield[@tag=240]|marc:datafield[@tag=730][@ind2!=2]"> + <xsl:for-each select="marc:datafield[@tag=130]|marc:datafield[@tag=240]|marc:datafield[@tag=730][@ind2=2]"> This means that 730 with no second indicator will disappear from OPAC view, basically turning around what we did before. Is this strictly necessary? I am not quite sure how the documentation is to be understood in terms of OPAC visibiliy. https://www.loc.gov/marc/bibliographic/bd730.html Second Indicator - Type of added entry Distinguishes between an analytical entry and no information provided. ... 2) Problems in testing 130/30 I have had a look and have maybe an idea of what could have gone wrong in testing: I had assumed at first that the title should go in $t, but after studying the MARC documentation, I see that it's different in these cases: https://www.loc.gov/marc/bibliographic/bdx30.html $a - Uniform title Parenthetical information added to make a title distinctive is not separately subfield coded except in the case of the date of signing added to a uniform title of a treaty (see description of subfield $d). $t - Title of a work Title page title of a work. Subfield $t is _unlikely to be used_ in an X30 field. But this means the test plan needs to be adjusted: "This patch updates both intranet and OPAC XSLT files to check for the presence of subfield $t and use title search (ti,phr:) instead of author search (au:) when $t is present." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185830|0 |1 is obsolete| | Attachment #185831|0 |1 is obsolete| | Attachment #185832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197486&action=edit Bug 34025: Changing default link search from au to ti,phr for X30 fields as they are are title type ones. These apply if there is no authorised term linked to for the content Test plan: ========== 1. Add some 130, 240, 730 + 7XX $a + $t fields to a record. Note that 730 and 7XX $a + $t fields have to have 2nd indicator set to 2. You can link the fields to authority records. Ensure that one of the fields is not linkable to an authority record and leave it unlinked. 2. Note that the information displayed from these fields is not 'clickable' neither in OPAC, nor in the staff interface. 3. Apply the patch ; restart all. 4. You should be able to see and use the links now. If the fields are linked to authotiry record and UseAuthoritiesForTracings systempreference is set, the search will be performed with authid identifier. There should be also a magnifying glass icon with a link to the authority record. 5. The links for any unlinked authority should now point to ti,phr - eg /cgi-bin/koha/catalogue/search.pl?q=ti,phr:%22Uniform%20Bernard%22 instead of au 6. Click that link and ensure it finds at least one record (the one you started with) Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197488&action=edit Bug 34025: (QA follow-up) Restore 730 ind2!=2 filter for Uniform titles The previous patch incorrectly changed the 730 indicator filter from [@ind2!=2] to [@ind2=2], which inverts which 730 fields display. Most 730 fields have a blank second indicator (no information provided), so this change caused them to disappear from the Uniform titles section. This restores the original filter so 730 fields with blank or non-analytical indicators continue to display as Uniform titles. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34025 --- Comment #22 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.