[Bug 36550] New: koha-elasticsearch commit default should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Bug ID: 36550 Summary: koha-elasticsearch commit default should be configurable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au It can be easy to forget the --commit option when running koha-elasticsearch especially across teams. It would be good if we could specify a different default value (rather than 5000) say in /etc/default/koha-common for instance. On a system with memory restrictions, 5000 is way too high, and will lead to incomplete ES indexing, which is quite bothersome to rectify after the fact. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 --- Comment #1 from Robin Sheat <robin@kallisti.net.nz> --- Created attachment 189821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189821&action=edit Bug 36550: allow defaults to be defined for koha-elasticsearch koha-elasticsearch only allows the parameters to be specified on the command line, otherwise it'll fall back to values hard-coded in the script. This allows default parameters to be defined in /etc/default/koha-common when installed with the Debian packages. It also copies the current defaults into the defaults file. Test plan, comprehensive: 1. You will need a package setup with elasticsearch, and some records. 2. Build a package (or copy the files modified in this patch over ones you might already have installed) 3. Modify some ES_* values in /etc/default/koha-community to your liking. 'ES_VERBOSE' might be a good one. 4. Do an elasticsearch reindex and observe that your parameter defaults are respected. Test plan, simple: 1. With a git checkout: * `sudo ln -s .../koha/debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh` * `sudo ln -s .../koha/debian/koha-common.default /etc/default/koha-common` 2. Modify `.../koha/debian/scripts/koha-elasticsearch` around line 200 so that it prints out the variables, and see that it properly respects modifying the defaults and/or setting the command line arguments. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189821|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 189822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189822&action=edit Bug 36550: allow defaults to be defined for koha-elasticsearch koha-elasticsearch only allows the parameters to be specified on the command line, otherwise it'll fall back to values hard-coded in the script. This allows default parameters to be defined in /etc/default/koha-common when installed with the Debian packages. It also copies the current defaults into the defaults file. Test plan, comprehensive: 1. You will need a package setup with elasticsearch, and some records. 2. Build a package (or copy the files modified in this patch over ones you might already have installed) 3. Modify some ES_* values in /etc/default/koha-community to your liking. 'ES_VERBOSE' might be a good one. 4. Do an elasticsearch reindex and observe that your parameter defaults are respected. Test plan, simple: 1. With a git checkout: * `sudo ln -s .../koha/debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh` * `sudo ln -s .../koha/debian/koha-common.default /etc/default/koha-common` 2. Modify `.../koha/debian/scripts/koha-elasticsearch` around line 200 so that it prints out the variables, and see that it properly respects modifying the defaults and/or setting the command line arguments. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |robin@kallisti.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Shouldnt this be marked as enh ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #3)
Shouldnt this be marked as enh ?
Doing so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #4)
(In reply to Marcel de Rooy from comment #3)
Shouldnt this be marked as enh ?
Doing so.
Yeah I suppose so. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |domm@plix.at CC| |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Thomas Klausner <domm@plix.at> --- Worked: I set a default of commit=25 in /etc/default/koha-common and that was picked up correctly. I could still override this value from the command line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189822|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 --- Comment #7 from Thomas Klausner <domm@plix.at> --- Created attachment 196343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196343&action=edit Bug 36550: allow defaults to be defined for koha-elasticsearch koha-elasticsearch only allows the parameters to be specified on the command line, otherwise it'll fall back to values hard-coded in the script. This allows default parameters to be defined in /etc/default/koha-common when installed with the Debian packages. It also copies the current defaults into the defaults file. Test plan, comprehensive: 1. You will need a package setup with elasticsearch, and some records. 2. Build a package (or copy the files modified in this patch over ones you might already have installed) 3. Modify some ES_* values in /etc/default/koha-community to your liking. 'ES_VERBOSE' might be a good one. 4. Do an elasticsearch reindex and observe that your parameter defaults are respected. Test plan, simple: 1. With a git checkout: * `sudo ln -s .../koha/debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh` * `sudo ln -s .../koha/debian/koha-common.default /etc/default/koha-common` 2. Modify `.../koha/debian/scripts/koha-elasticsearch` around line 200 so that it prints out the variables, and see that it properly respects modifying the defaults and/or setting the command line arguments. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |You can now set custom release notes| |defaults for | |koha-elasticsearch in | |/etc/default/koha-common. | |You can still override the | |defaults using the command | |line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Thomas Klausner from comment #6)
Worked: I set a default of commit=25 in /etc/default/koha-common and that was picked up correctly. I could still override this value from the command line.
Cheers, Thomas :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 --- Comment #10 from Robin Sheat <robin@kallisti.net.nz> --- Yay! Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org