[Bug 25222] New: Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Bug ID: 25222 Summary: Add ability to let plugins live in individual subdirectories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org
From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to."
This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25174 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 103311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103311&action=edit Bug 25222: Add ability to let plugins live in individual subdirectories
From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to."
This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103311|0 |1 is obsolete| | --- Comment #2 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 103317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103317&action=edit Bug 25222: Add ability to let plugins live in individual subdirectories
From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to."
This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103317|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 103389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103389&action=edit Bug 25222: Add ability to let plugins live in individual subdirectories
From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to."
This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Passed QA CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. this looks like it adds a new dependency but doesn't specify that in the cpanfile File::Find::Rule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Had a quick chat with Kyle regarding alternatives:
I'm not sure about the approach in bug 25222 - Add ability to let plugins live in individual subdirectories should we require that plugin devs package like this under a top level dir.. or should we actually handle the separation at install time perhaps and create a directory for each plugin there? I can see things ending up very inconsistent with a mix of the two styles otherwise.
We agreed that if it's not a mammoth task it would be cleaner to continue to package plugins the way we currently are, and instead split them up at install time. As such, we're going to have a go at that and I'll hold off pushing this until we've reached a conclusion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 103495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103495&action=edit Bug 25222: (QA follow-up) Make Koha create the subdirectory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 103496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103496&action=edit Bug 25222: (QA follow-up) Update @INC when calling Koha::Plugins::new -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Setting back to signed off.. I've asked Tomas to give the follow-ups a quick once over to check there's nothing I've missed in Kyles work. Thanks for your effort guys, this will be a nice improvement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Not sure how this worked before, but uninstalling a plugin with the patch applied leaves a lot of files in <pluginsdir>. Can it be fixed ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Julian Maurice from comment #9)
Not sure how this worked before, but uninstalling a plugin with the patch applied leaves a lot of files in <pluginsdir>. Can it be fixed ?
I think uninstallation is already broken anyway? Bug 25604 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tomas, you are QA contact here - could you verify that uninstalling works correctly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please check comment#9 and comment#10 - something appears not to be right with uninstalling plugins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this dead in the water? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #13)
Is this dead in the water?
I'm not opposed to continuing work on it if someone can tell me what needs done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- I don't have anything to ad from a QA perspective... but I'm intrigued by this one! In Discourse, the named plugins go into /var/www/discourse/plugins, so you wind up with something like /var/www/discourse/plugins/discourse-jwt/plugin.rb (https://github.com/discourse/discourse-jwt). I found it super convenient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Cook from comment #15)
I don't have anything to ad from a QA perspective... but I'm intrigued by this one!
In Discourse, the named plugins go into /var/www/discourse/plugins, so you wind up with something like /var/www/discourse/plugins/discourse-jwt/plugin.rb (https://github.com/discourse/discourse-jwt). I found it super convenient.
Yeah, that's basically the gist of what we are trying do to here as well! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103389|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #17 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199504&action=edit Bug 25222: Add ability to let plugins live in individual subdirectories
From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to."
This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #18 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199505&action=edit Bug 25222: Correct File::Find::Rule version in cpanfile Patch from commit 9383222 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #19 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199506&action=edit Bug 25222: Add unit tests Patch from commit 02777e7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #20 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199507&action=edit Bug 25222: Give plugin subdirectories precedence over the plugins directory When an existing plugin is upgraded into its own subdirectory, the older flat copy is left behind in the plugins directory, so two copies of the same plugin are discoverable on disk at once. Both would be found, with unpredictable results for which one loads. This is bad. This orders @INC so that individual plugin subdirectories (directories that contain a Koha/Plugin tree) are searched before the plugins directory itself. This causes the newer "subdir" installed version to be loaded instead of the "root dir" version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #21 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199508&action=edit Bug 25222: Install plugins into their own subdirectory Previously an uploaded plugin archive was extracted flat into the plugins directory, mixing every plugin's files together. This adds Koha::Plugins->extract_plugin, which extracts a .kpz into its own subdirectory of the plugins directory, named after the plugin's "main" class. Because the subdirectory name is derived from the plugin class, uploading a new version of a plugin reuses the same subdirectory. The previous copy is removed in full before the new one is extracted, so files dropped from a newer version of the plugin do not leave cruft. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #22 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199509&action=edit Bug 25222: Remove the plugin's subdirectory on uninstall Now that a plugin is installed into its own subdirectory of the plugins directory, uninstalling it should remove that whole subdirectory rather than just the plugin's own module and bundled files, which left an empty directory skeleton behind. Test Plan: 1) Apply all patches 2) Upload a plugin, then uninstall it from Administration > Manage plugins 3) Note its subdirectory under the plugins directory is gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #23 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199510&action=edit Bug 25222: Remove old flat copy of a plugin on upgrade Now that uploads install a plugin into its own subdirectory, the first upgrade of a plugin that was previously installed flat would leave the old "flat" files behind. The new subdirectory copy shadows them in @INC but Koha has no facility to remove them. This makes Koha::Plugins->extract_plugin also remove those flat files from every configured plugins directory at install time just like Koha::Plugins::Handler->delete removes for a flat-installed plugin. For almost all plugins ( early on I had included some libs outside the plugin assets dir in some early plugin versions, that was a mistrake ), this will fully clean up the old version, so no cruft is left when the new version is placed in its own subdirectory. Test Plan: 1) Install a plugin 3) Apply these patches 4) Restart all the things! 5) Upload the same plugin again 6) Note the plugin files in "$pluginsdir/Koha" are gone 7) Note the plugin files are now a sub dir e.g. "$pluginsdir/$plugin_name/Koha" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #24 from David Cook <dcook@prosentient.com.au> --- I've got a lot on at the moment, but I'm going to check back on this one, as I think it's a really good direction to move in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42871 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org