https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #23 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199510&action=edit Bug 25222: Remove old flat copy of a plugin on upgrade Now that uploads install a plugin into its own subdirectory, the first upgrade of a plugin that was previously installed flat would leave the old "flat" files behind. The new subdirectory copy shadows them in @INC but Koha has no facility to remove them. This makes Koha::Plugins->extract_plugin also remove those flat files from every configured plugins directory at install time just like Koha::Plugins::Handler->delete removes for a flat-installed plugin. For almost all plugins ( early on I had included some libs outside the plugin assets dir in some early plugin versions, that was a mistrake ), this will fully clean up the old version, so no cruft is left when the new version is placed in its own subdirectory. Test Plan: 1) Install a plugin 3) Apply these patches 4) Restart all the things! 5) Upload the same plugin again 6) Note the plugin files in "$pluginsdir/Koha" are gone 7) Note the plugin files are now a sub dir e.g. "$pluginsdir/$plugin_name/Koha" -- You are receiving this mail because: You are watching all bug changes.