https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- t/Koha_ExternalContent_OverDrive.t ...... skipped: Need Test::DBIx::Class That's why it does not fail on the other image. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I cannot recreate the failure and the output is not verbose enough. With this patch we could know what is the error. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Jonathan Druart from comment #4)

I cannot recreate the failure and the output is not verbose enough. With this patch we could know what is the error.

Here is the more verbose output with the patch applied: # Failed test 'Invalid RecordedBooks partner credentials' # at t/Koha_ExternalContent_RecordedBooks.t line 29. # 'Can't connect to api.rbdigital.com:80 # Request: # GET http://api.rbdigital.com/v1/libraries/DUMMY/search?all=art # Authorization: Basic DUMMY # User-Agent: libwww-perl/6.08 # # # Response: # 500 Can't connect to api.rbdigital.com:80 # Content-Type: text/plain # Client-Date: Wed, 17 Oct 2018 08:16:37 GMT # Client-Warning: Internal response # # Can't connect to api.rbdigital.com:80 # # Name or service not known at /usr/share/perl5/LWP/Protocol/http.pm line 49. # ' # doesn't match '(?^u:This endpoint can be called by authorized trusted app or trusted partner only)' # Looks like you failed 1 test of 3. t/Koha_ExternalContent_RecordedBooks.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests (less 1 skipped subtest: 1 okay) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Trying from the git checkout on the nightly server I get a pass. Reading the skip reason for test 3 I wonder if that is what is supposed to happen during package build, but does not for some reason. t/Koha_ExternalContent_RecordedBooks.t .. 1..3 ok 1 - use Koha::ExternalContent::RecordedBooks; ok 2 - Invalid RecordedBooks partner credentials ok 3 # skip no RecordedBooks partner credentials ok All tests successful. Files=1, Tests=3, 4 wallclock secs ( 0.04 usr 0.00 sys + 2.50 cusr 0.33 csys = 2.87 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_11_candidate CC| |tomascohen@gmail.com Status|NEW |In Discussion Severity|normal |blocker --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This tests should be moved into db_dependent if external world interaction is expected. This tests could remain in t/ if WebService::ILS behaviour was completely mocked. As-is, they block package building. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #13 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Apologies, at the time I wrote it it was not breaking things, and it was useful for me to make sure it integrates well. I could try to make it more friendly, just not sure if my test credentials are still valid. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #15 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Tomás Cohen Arazi from comment #14)

The tests in t/db_dependent/Koha_ExternalContent_RecordedBooks.t work, I haven't checked how much they cover the functionality, though.

Without credentials - very little if any. With credentials reasonable amount. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #17 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Julian Maurice from comment #16)

Just a thought: why not just skip the test if network is unavailable ? Something like this: https://metacpan.org/pod/LWP::Online#Test-Mode

I don't think it is a network issue on my end.

# 500 Can't connect to oauth.overdrive.com:443

indicates we get out of the build machine, but not into the server, doesn't it? Other network tasks during build work ok. I'll have another look what is going on. RecordedBooks is fixed with deleting the file. OverDrive would be skipped during package build if moved to db_dependent. But I don't know if it is the correct solution. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #19 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Julian Maurice from comment #16)

Just a thought: why not just skip the test if network is unavailable ? Something like this: https://metacpan.org/pod/LWP::Online#Test-Mode

(In reply to Tomás Cohen Arazi from comment #9)

This tests should be moved into db_dependent if external world interaction is expected.

So, which one should it be for t/Koha_ExternalContent_OverDrive.t? I'd be in favour of moving the test, but I'd be ok with adding the dependency too. Any preferences? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82352|0 |1 is obsolete| | --- Comment #21 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 82398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82398&action=edit Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t This patch removes this file. The included tests are similar to those in the db_dependent section, with the difference that this have some things mocked. But the tests still require name resolution and connecting to the RB servers. This situation breaks package building without any noticeable gain. The feature could be better tested by mocking WebService::ILS calls (so no external world contact), but it belongs to a separate bug report. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82400&action=edit Bug 21567: Remove Koha_ExternalContent_RecordedBooks.t This patch removes this file. The included tests are similar to those in the db_dependent section, with the difference that this have some things mocked. But the tests still require name resolution and connecting to the RB servers. This situation breaks package building without any noticeable gain. The feature could be better tested by mocking WebService::ILS calls (so no external world contact), but it belongs to a separate bug report. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #27 from Mirko Tietgen <mirko@abunchofthings.net> --- Also needed in 17.11, adding Fridolin. -- You are receiving this mail because: You are watching all bug changes.