[Bug 21649] New: Add child button in the staff client is no longer automatically populating the parent address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Bug ID: 21649 Summary: Add child button in the staff client is no longer automatically populating the parent address Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: margaret@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In 18.05 when a staff member clicks the Add Child button on a Parent's/Guardian's account the main address is not populated on the new patron page. Other details carry over but the main address is empty. I tested on a 17.11 instance and the feature works correctly there. To Replicate: 1) Install/be running 18.05.04 2) Create or find an adult patron account you want to test with; make sure they have an address - street, city, etc. 3) On the Details tab of the patron's record click on the "+Add child" button. 4) See that the main address text boxes are empty on the /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=... page. The Guarantor information and Contact information seems to come over, but Address does not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 82510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82510&action=edit Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 21843 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82510|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82570&action=edit Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82570|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 82571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82571&action=edit Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Todd <tgoatley@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82571|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 82572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82572&action=edit Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Todd <tgoatley@gmail.com> Signed-off-by: Todd <tgoatley@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82572|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82597&action=edit Bug 21649: Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Todd <tgoatley@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> It works, but the code is ugly and hard to maintain. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|Trivial patch |Small patch --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial is not the right qualification if you look for $patron, $newdata etc. in memberentry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Will this be applied to 18.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- This patch does not work for 18.05, not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83020&action=edit Bug 21649: [18.05.X] Pass guarantee info to template when adding child To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #11)
Created attachment 83020 [details] [review] Bug 21649: [18.05.X] Pass guarantee info to template when adding child
To test: 1 - Find an adult patron 2 - Click 'Add child' 3 - Note address/phone info does not carry over 4 - Apply patch 5 - Repeat 6 - Note information populates
This should be tested - in 18.05 we are creating a new patron object when creating a new one - testing for borrowernumber seems to confirm it is an 'empty' patron and allow for the pass of the guarantor info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05 for 18.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 18789 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org