[Bug 26626] New: When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Bug ID: 26626 Summary: When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This can lead to accidental cancellation if one is simply trying to dismiss the modal and has learned that the X option is often 'ignore' I would suggest replacing 'Ignore/Cancel' with 'Dismiss' and moving the 'Cancel' option to the left of 'Confirm hold' To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'cancel', but pretend you thought it was 'Ignore' 10 - The book comes up on the holds queue, but no one can find it, because it is on the holds shelf 11 - Then staff do find it, but they hold it for the next patron 12 - The original patron comes in to library, but you won't give them the book, because someone else has the hold now 13 - Drama ensues... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Brenda <bowens@washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowens@washoecounty.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123368&action=edit Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123373&action=edit Dialog with revised icons I think the minus symbol isn't very understandable. What about using the "trash" icon (which we use in other situations for "delete") for the cancel operation? See the attached mockup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I like the idea of promoting icon consistency. I'm happy to defer to Owen on questions of minuses and garbage cans :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Owen Leonard from comment #2)
Created attachment 123373 [details] Dialog with revised icons
I think the minus symbol isn't very understandable. What about using the "trash" icon (which we use in other situations for "delete") for the cancel operation? See the attached mockup.
That sounds good to me! Did you code it already, or shall I attempt? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I don't have a patch, so please attempt! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123368|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123462&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123368|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #5)
I don't have a patch, so please attempt!
Never mind I did a patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123368|0 |1 is obsolete| | --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 123698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123698&action=edit Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123462|0 |1 is obsolete| | --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 123699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123699&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #10 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- This works and the visual presentation is very clear. I like using the x for Ignore and the trash can for Cancel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |joonas.kylmala@iki.fi --- Comment #11 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123698|0 |1 is obsolete| | Attachment #123699|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139470&action=edit Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139471&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139472&action=edit Bug 26626: (follow-up) Be consistent with icon and accesskeys -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31419 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139470|0 |1 is obsolete| | Attachment #139471|0 |1 is obsolete| | Attachment #139472|0 |1 is obsolete| | --- Comment #15 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 139540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139540&action=edit Bug 26626: Add 'Ignore' option to confirmed holds modal This patch adds 'Ignore' to the 'Hold already waiting' modal To test: To recreate: 1 - Place a hold for pickup at library A 2 - Checkin the item at Library A 3 - Note the modal has 'Ignore' option 4 - Click it, nothing happens 5 - Check in the item again, same modal 6 - Click 'Confirm' 7 - Check in the item again 8 - Now 'Ignore' is replaced by 'Cancel' 9 - Click 'Confirm' to dismiss modal 10 - Apply patch 11 - Check the item in again 12 - Note 'Ignore' button before 'Cancel' button with '-' icon 13 - Go to biblio holds page 14 - Revert waiting status 15 - Check item in again 16 - Note ignore now has '-' (minus) icon Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #16 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 139541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139541&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #17 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 139542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139542&action=edit Bug 26626: (follow-up) Be consistent with icon and accesskeys Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | CC| |lucas@bywatersolutions.com --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #20 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org