[Bug 31401] New: Administration sidebar shows 'Classification sources' when it should be 'Classification configuration'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Bug ID: 31401 Summary: Administration sidebar shows 'Classification sources' when it should be 'Classification configuration' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We changed the heading and the administration start page to say 'Classification configuration' but missed changing the administration sidebar as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Administration sidebar |Update administration |shows 'Classification |sidebar to match entries on |sources' when it should be |administration start page |'Classification | |configuration' | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some more discrepancies between the admin start page and the sidebar, will detail in the commit message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139436&action=edit Bug 31401: Update administration sidebar to match entries on administration start page This makes sure that all entries on the administration start page have a matching entry in the administration sidebar that shows on the left side if you are on any of the administration sub pages. Changes made: * Rename 'Classification sources' to 'Classification configuration' * Make Plugins entry show and appear in correct spot This relied on the variable plugins_enabled that wasn't available in all the different templates. I therefore moved it to Auth.pm and cleaned up the code for the admin start page. * Move 'MARC overlay rules' and rename to 'Record overlay rules' To test: * Make sure plugins are enabled and visible on admin start page * Compare admin start page and sidebar * Sequence should be the same * All entries should appear on both pages * Naming should be the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139436|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 139445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139445&action=edit Bug 31401: Update administration sidebar to match entries on administration start page This makes sure that all entries on the administration start page have a matching entry in the administration sidebar that shows on the left side if you are on any of the administration sub pages. Changes made: * Rename 'Classification sources' to 'Classification configuration' * Make Plugins entry show and appear in correct spot This relied on the variable plugins_enabled that wasn't available in all the different templates. I therefore moved it to Auth.pm and cleaned up the code for the admin start page. * Move 'MARC overlay rules' and rename to 'Record overlay rules' To test: * Make sure plugins are enabled and visible on admin start page * Compare admin start page and sidebar * Sequence should be the same * All entries should appear on both pages * Naming should be the same Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I've signed off, but noted that when you go into Administration > Plugins > Manage plugins that the sidebar for Tools appears (it is listed under Additional tools > Tool plugins - I vaguely recall plugins was located there at some stage...). I'm going to assume that this should be a separate bug (if it isn't already). Everything else looks great and matches up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Plugins appear on both start pages - administration and tools. But the files themselves live in the tools section. That's why you land there, when you click on it. It's a little similar to the funds/budgets that live in admin, but are also on the sidebar in acq. I just repaired the Plugins entry, it was always supposed to show but didn't because of a problem with the plugins_enable variable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139445|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140151&action=edit Bug 31401: Update administration sidebar to match entries on administration start page This makes sure that all entries on the administration start page have a matching entry in the administration sidebar that shows on the left side if you are on any of the administration sub pages. Changes made: * Rename 'Classification sources' to 'Classification configuration' * Make Plugins entry show and appear in correct spot This relied on the variable plugins_enabled that wasn't available in all the different templates. I therefore moved it to Auth.pm and cleaned up the code for the admin start page. * Move 'MARC overlay rules' and rename to 'Record overlay rules' To test: * Make sure plugins are enabled and visible on admin start page * Compare admin start page and sidebar * Sequence should be the same * All entries should appear on both pages * Naming should be the same Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140152&action=edit Bug 31401: (QA follow-up) Remove Koha.ArePluginsEnabled, it is no longer needed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org