[Bug 28134] New: Replace use of input type number in onboarding templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Bug ID: 28134 Summary: Replace use of input type number in onboarding templates Change sponsored?: --- Product: Koha Version: master Hardware: All URL: https://wiki.koha-community.org/wiki/Coding_Guidelines #ACC2:_Input_type_.22number.22_should_be_avoided OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: aleisha@catalyst.net.nz, caroline.cyr-la-rose@inlibro.com, gmcharlt@gmail.com, jamespfk@gmail.com, martin.renvoize@ptfs-europe.com, testopia@bugs.koha-community.org Blocks: 26926 Inputs of type="number" need updating to adhere to ACC2 in onboarding templates koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 [Bug 26926] Omnibus: Update all occurrences of <input type="number"> to apply ACC2 coding guideline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119449&action=edit Bug 28134: Replace use of input type number in onboarding templates This patch changes the instances of input of type="number" to input type="text" with attributes inputmode="numeric" and pattern="[0-9]*" To test, apply the patch and run through the process of installing Koha. When you reach onboarding step 2, "Create a patron category," check the enrollment period -> "In months" field. The field should not accept any input except numbers. Continue onboarding until step 5, "Create a new circulation rule." On this page, check that these fields accept only numbers: - Current checkouts allowed - Loan period - Renewals allowed - Renewals period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119449|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119451&action=edit Bug 28134: Replace use of input type number in onboarding templates This patch changes the instances of input of type="number" to input type="text" with attributes inputmode="numeric" and pattern="[0-9]*" To test, apply the patch and run through the process of installing Koha. When you reach onboarding step 2, "Create a patron category," check the enrollment period -> "In months" field. The field should not accept any input except numbers. Continue onboarding until step 5, "Create a new circulation rule." On this page, check that these fields accept only numbers: - Current checkouts allowed - Loan period - Renewals allowed - Renewals period - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119451|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120435&action=edit Bug 28134: Replace use of input type number in onboarding templates This patch changes the instances of input of type="number" to input type="text" with attributes inputmode="numeric" and pattern="[0-9]*" To test, apply the patch and run through the process of installing Koha. When you reach onboarding step 2, "Create a patron category," check the enrollment period -> "In months" field. The field should not accept any input except numbers. Continue onboarding until step 5, "Create a new circulation rule." On this page, check that these fields accept only numbers: - Current checkouts allowed - Loan period - Renewals allowed - Renewals period - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Catches all cases and works as expected.. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think we can safely use my SO as a PQA. This is a trivial fix on a set of integer inputs so no ambiguity around decimal handling. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org