https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- (In reply to Owen Leonard from comment #2)

I like this change but shouldn't the date formatting be done in the template using '$KohaDates with_hours => 1' ?

+1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #6 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Thank you all for your work on this request. I can verify that the provided patch works as expected! [FYI, for Koha 3.20 the patch needs one line less, because 'Hold waiting too long' is not available] Having said that, unless you print slips with the text from the description, I think it would be more generic to simply change the date column to show hours/minutes in ALL fine lines. Following Owen's suggestion, it would be something like this: - <td><span title="[% account.date %]">[% account.date |$KohaDates %]</span></td> + <td><span title="[% account.timestamp %]">[% account.timestamp |$KohaDates with_hours => 1 %]</span></td> What do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18790 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66826&action=edit Bug 16486: [FOLLOW-UP] Putting time in date column In reply to Comment 6, I have moved the time into a column separate from the description. Unfortunately the timestamp has the date and the time, so I figured it was easier to just have them in the same column and replace the original date column. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66827&action=edit Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places As suggested in Comment 7. The timestamp has also been added to printfeercpt.tt, printinvoice.tt, and opac-account.tt To test: 1) In Staff side, go to member account, go to Fines, go to Account tab 2) Click the Print button next to a payment 3) Confirm timestamp shows on print slip 4) Create a manual invoice 5) Go back to the Account tab 6) Click the Print button next to the invoice 7) Confirm timestamp shows on print slip 8) Log into OPAC 9) Go to your fines 10) Confirm timestamp shows Ready to test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Dominic Pichette from comment #11)

I had this error trying to access the account tab in fines:

Hi Dominic, When you find an issue, you can switch the status to Failed QA. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62995|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 67537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67537&action=edit Bug 16486: Display the timestamp for account payments/writeoffs To test: 1) Apply patch 2) Go to the patron account page, Fines tab 3) Click Account tab 4) Confirm timestamp shows next to payments and writeoffs 5) Go to Admin -> TimeFormat syspref, change the format 6) Refresh the fines page, confirm time format changes Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Found a conflict in the first patch so fixed it. (In reply to Dominic Pichette from comment #11)

I had this error trying to access the account tab in fines:

Global symbol "$input" requires explicit package name (did you forget to declare "my $input"?) at /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 41. syntax error at /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 44, near "1cc607141dd67a2373996a1cf5116b1334354420

" Global symbol "$input" requires explicit package name (did you forget to declare "my $input"?) at /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 56. Execution of /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl aborted due to compilation errors.

Thank you for testing but I was unable to reproduce these errors, everything still works as expected for me. Can you please test again and make sure your master is up to date? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.pouchol@biblibre.com --- Comment #16 from Simon Pouchol <simon.pouchol@biblibre.com> --- Hey, I tried testing, and got this error message upon trying to apply the patch : fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt). error: could not build fake ancestor Patch failed at 0001 Bug 16486: [FOLLOW-UP] Putting time in date column Unsure what it means, whether it's my setup or the patches not working. (my master is up to date) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #17)

Are the patches still in the right order ?

oops no they are not - i will fix this -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66826|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68303&action=edit Bug 16486: [FOLLOW-UP] Putting time in date column In reply to Comment 6, I have moved the time into a column separate from the description. Unfortunately the timestamp has the date and the time, so I figured it was easier to just have them in the same column and replace the original date column. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68304|0 |1 is obsolete| | --- Comment #22 from Simon Pouchol <simon.pouchol@biblibre.com> --- Created attachment 68316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68316&action=edit Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places As suggested in Comment 7. The timestamp has also been added to printfeercpt.tt, printinvoice.tt, and opac-account.tt To test: 1) In Staff side, go to member account, go to Fines, go to Account tab 2) Click the Print button next to a payment 3) Confirm timestamp shows on print slip 4) Create a manual invoice 5) Go back to the Account tab 6) Click the Print button next to the invoice 7) Confirm timestamp shows on print slip 8) Log into OPAC 9) Go to your fines 10) Confirm timestamp shows Works as intended. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #20)

Created attachment 68303 [details] [review] Bug 16486: [FOLLOW-UP] Putting time in date column

In reply to Comment 6, I have moved the time into a column separate from the description. Unfortunately the timestamp has the date and the time, so I figured it was easier to just have them in the same column and replace the original date column.

I think the date column has different info than the timestamp and shouldn't be replaced for all instances - for things like lost fees or account fees date is when it was created - if a partial payment is applied that updates timestamp but not date We should probably have both columns available, or show both info: Original date: 2017-07-07 Updated: 2017-10-21 12:12:38 or 2017-10-21 12:12:38 (2017-07-07) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 70578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70578&action=edit Bug 16486: [FOLLOW-UP] Show original date and timestamp for fines This patch has two columns in fines tables, one showing the original date and one showing the timestamp (when the patch was last updated) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68303|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 70580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70580&action=edit Bug 16486: [FOLLOW-UP] Putting time in date column In reply to Comment 6, I have moved the time into a column separate from the description. Unfortunately the timestamp has the date and the time, so I figured it was easier to just have them in the same column and replace the original date column. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70578|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 70583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70583&action=edit Bug 16486: [FOLLOW-UP] Show original date and timestamp for fines This patch has two columns in fines tables, one showing the original date and one showing the timestamp (when the patch was last updated) Fixed merge conflicts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #29 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Aleisha Amohia from comment #28)

Created attachment 70583 [details] [review] Bug 16486: [FOLLOW-UP] Show original date and timestamp for fines

This patch has two columns in fines tables, one showing the original date and one showing the timestamp (when the patch was last updated)

Fixed merge conflicts

Hi Aleisha, I tested on a sandbox and it works very well. But I was wondering if the column Updated should not appear also in the report Cash register statistics (reports/cash_register_stats.pl)? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #31 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #32 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70687&action=edit Bug 16486: Display the timestamp for account payments/writeoffs To test: 1) Apply patch 2) Go to the patron account page, Fines tab 3) Click Account tab 4) Confirm timestamp shows next to payments and writeoffs 5) Go to Admin -> TimeFormat syspref, change the format 6) Refresh the fines page, confirm time format changes Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #34 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70689&action=edit Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places As suggested in Comment 7. The timestamp has also been added to printfeercpt.tt, printinvoice.tt, and opac-account.tt To test: 1) In Staff side, go to member account, go to Fines, go to Account tab 2) Click the Print button next to a payment 3) Confirm timestamp shows on print slip 4) Create a manual invoice 5) Go back to the Account tab 6) Click the Print button next to the invoice 7) Confirm timestamp shows on print slip 8) Log into OPAC 9) Go to your fines 10) Confirm timestamp shows Works as intended. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #36 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70691&action=edit Bug 16486: Adding timestamp column to cash register statistics To test: 1) Go to Reports -> Cash Register 2) Fill in some fields and submit the report 3) Confirm the timestamp (updated) column is correct 4) Confirm there are no warns Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70689|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 74045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74045&action=edit Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places As suggested in Comment 7. The timestamp has also been added to printfeercpt.tt, printinvoice.tt, and opac-account.tt To test: 1) In Staff side, go to member account, go to Fines, go to Account tab 2) Click the Print button next to a payment 3) Confirm timestamp shows on print slip 4) Create a manual invoice 5) Go back to the Account tab 6) Click the Print button next to the invoice 7) Confirm timestamp shows on print slip 8) Log into OPAC 9) Go to your fines 10) Confirm timestamp shows Works as intended. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If the rebase was not very severe, it's ok if you put this back to 'signed off' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleisha, QA script passes with the exception of the commit message descriptions. Could you please fix with the next iteraton? (https://wiki.koha-community.org/wiki/Commit_messages) 1) borraccount.tt + <th class="title-string">Original date</th> + <th class="title-string">Updated</th> Maybe make this "Created" or "Creation date" and "Updated". Not sure original date will be understood, thinking of translation too. Why the change from Writeoff to Written off? The last table row (total due) is not correctly formatted with the patch (empty last cell). 2) printfeercpt.tt Table layout is broken by the patch here too. Same for terminology as above. 3) cash_register_stats.tt Table layout is broken here too (last total row). Stopping here. Please consider if changing the description would make sense and recheck the other changed templates for layout problems too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70687|0 |1 is obsolete| | Attachment #70688|0 |1 is obsolete| | Attachment #74045|0 |1 is obsolete| | Attachment #74046|0 |1 is obsolete| | Attachment #74047|0 |1 is obsolete| | --- Comment #45 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 103534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103534&action=edit Bug 16486: Display the timestamp when an accountline is updated This patch updates the Date field to be 'Created' and adds a new column 'Updated' which shows the timestamp of the accountline. To test: 1) Update database, restart services 2) Test the following staff client pages: - Reports -> Cash register - Patron Accounting tab -> Transactions - Create a manual invoice. Click 'Print' on the transactions tab to generate Invoice slip - Make a payment. Click 'Print' on the transactions tab to generate Receipt slip 3) Test the OPAC: - your charges Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103534|0 |1 is obsolete| | --- Comment #46 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 103938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103938&action=edit Bug 16486: Display the timestamp when an accountline is updated This patch updates the Date field to be 'Created' and adds a new column 'Updated' which shows the timestamp of the accountline. To test: 1) Update database, restart services 2) Test the following staff client pages: - Reports -> Cash register - Patron Accounting tab -> Transactions - Create a manual invoice. Click 'Print' on the transactions tab to generate Invoice slip - Make a payment. Click 'Print' on the transactions tab to generate Receipt slip 3) Test the OPAC: - your charges Sponsored-by: Catalyst IT Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 103938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103938 Bug 16486: Display the timestamp when an accountline is updated Review of attachment 103938: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16486&attachment=103938) ----------------------------------------------------------------- Some first notes here: 1) Database updates $dbh->do(q{DELETE FROM letter WHERE code = 'ACCOUNT_DEBIT'}); This means we'd be destroying any customized templates the libraries have created themselves and also will force them back to English if they have translated them. I think we should remove these and leave the templates for existing installations as they are. We could add a sample template including the new information to the notices sample page on the wiki maybe 2) Needs a little rebase - es-ES is now using the .yml files to create translations. 3) Cash register changes work well, but the column should also be added to the CSV export to make them match. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117232|0 |1 is obsolete| | --- Comment #49 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 117233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117233&action=edit Bug 16486: Display the timestamp when an accountline is updated This patch updates the Date field to be 'Created' and adds a new column 'Updated' which shows the timestamp of the accountline. To test: 1) Apply patch, restart services 2) Test the following staff client pages: - Reports -> Cash register - Patron Accounting tab -> Transactions - Create a manual invoice. Click 'Print' on the transactions tab to generate Invoice slip - Make a payment. Click 'Print' on the transactions tab to generate Receipt slip 3) Test the OPAC: - your charges Sponsored-by: Catalyst IT Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117233|0 |1 is obsolete| | --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117348&action=edit Bug 16486: Display the timestamp when an accountline is updated This patch updates the Date field to be 'Created' and adds a new column 'Updated' which shows the timestamp of the accountline. To test: 1) Apply patch, restart services 2) Test the following staff client pages: - Reports -> Cash register - Patron Accounting tab -> Transactions - Create a manual invoice. Click 'Print' on the transactions tab to generate Invoice slip - Make a payment. Click 'Print' on the transactions tab to generate Receipt slip 3) Test the OPAC: - your charges Sponsored-by: Catalyst IT Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #52 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Martin Renvoize from comment #51)

Sorry Aliesha, I didn't spot this one in the tree... else I'd have tried to fold it into the now pushed bug 26734.. it was only upon going to update the wiki pages at Katrins request I saw a link to this bug.

Would you like me to have a go at rebasing for you or are you OK to take a look.. it appears that it stopped applying prior to my patch but I feel a bit guilty having made it even harder.

No worries. Yes please if you can try rebasing that would be awesome, I'm not sure when I'll have time to revisit this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117348|0 |1 is obsolete| | --- Comment #53 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 120479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120479&action=edit Bug 16486: Display the timestamp when an accountline is updated This patch updates the Date field to be 'Created' and adds a new column 'Updated' which shows the timestamp of the accountline. To test: 1) Apply patch, restart services 2) Test the following staff client pages: - Reports -> Cash register - Patron Accounting tab -> Transactions - Create a manual invoice. Click 'Print' on the transactions tab to generate Invoice slip - Make a payment. Click 'Print' on the transactions tab to generate Receipt slip 3) Test the OPAC: - your charges Sponsored-by: Catalyst IT Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch updates the |This patch updates the release notes|information viewed in Koha |information viewed in Koha |about accountlines. The |about accountlines. The |current 'Date' field is |current 'Date' field is |renamed 'Created', and a |renamed 'Created', and a |new column 'Updated' is |new column 'Updated' is |added, which shows the |added, which shows the |timestamp (time last |timestamp (time last |updated in the database) of |updated in the database) of |the accountline. |the accountline. | |It does | |not affect existing | |installations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #57 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.