[Bug 25477] New: The responsive design in opac-main.tt should be correct
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Bug ID: 25477 Summary: The responsive design in opac-main.tt should be correct Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: timothy_alexis.vass@ub.lu.se QA Contact: testopia@bugs.koha-community.org Currently these are the possible layouts in opac-main.tt ---A--- OpacNav/OpacNavBottom: span2 Main: span7 Login/OpacNavRight: span3 ---B--- OpacNav/OpacNavBottom: span2 Main: span10 ---C--- Main: span9 Login/OpacNavRight: span3 ---D--- Main: span12 Possibilities to improve are found here: @media (min-width:768px) and (max-width:979px): The layouts A, B and C are too narrow. @media (max-width:767px): Right column gets positioned at the bottom. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #1 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104822&action=edit Koha-community at Width: 800px -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #2 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104823&action=edit Koha-community at Width: 740px -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #3 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104824&action=edit Koha-community at Width: 888px with content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #4 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104825&action=edit Koha-community at Width: 720px with content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #5 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104827&action=edit Proposal: Set #wrap { padding: 0 } and change layout to span8+span4 This layout almost looks good with: #wrap { padding: 0; } Main: span8 Login/OpacNavRight/OpacNav/OpacNavBottom: span4 ---Required changes--- opac-tmpl/bootstrap/en/modules/opac-main.tt opac-tmpl/bootstrap/css/opac_19.0504000.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #6 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104828&action=edit Proposal would require corrections between width 767px and 840px -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104828|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #7 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104829&action=edit Bug 25477: The responsive design in opac-main.tt should be correct @media (min-width:768px) and (max-width:979px): The layouts with columns are too narrow. This patch changes the layout to be span8+span4 and puts OpacNav/OpacNavBottom under Login/OpacNavRight in the right column. To test: 1) Navigate to cgi-bin/koha/opac-main.pl with content in OpacNav/OpacNavBottom and Login/OpacNavRight, or look at the attached screenshots: https://bugs.koha-community.org/bugzilla3/attachment.cgi?bugid=25477&action=viewall&hide_obsolete=1 2) Apply patch. 3) Try different screen widths at 678px and above. 4) Sign off. Sponsored-by: Lunds Universitetsbibliotek -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |timothy_alexis.vass@ub.lu.s | |e --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Don't forget to assign bugs to yourself when you plan to submit a patch. Mark the bug "Needs signoff" when your patch is ready to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Without seeing what our proposed change would do, I assumed based on your comments that you were going to adjust the layout in some way while keeping the existing layout options. I don't think it's a viable solution to change the layout in a way that eliminates the existing choices. Also, your patch adds dummy text to opac-main.tt. If you'd like to test your layouts with dummy text during development you can use the OpacMainUserBlock news location to define content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #10 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104889&action=edit Real case scenario 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #11 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104890&action=edit Real case scenario example 2a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #12 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104891&action=edit Real case scenario example 2b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #13 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Thank you Owen for the clear guidance and for kindly pointing out the specifics. Thank you also so much for sharing the knowledge about the OpacMainUserBlock news location to define content. Actual information is to be presented in these columns and they are simply too narrow, resulting in 2-3 words per row. I have added 3 more screenshots to show what this looks like in a real case scenario. Because the sidebar needs to present a useful amount of content, which logically requires a certain amount of width, span4 for both the sidebars. Is this possible to achieve the required width other than a span8+span4 layout? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104829|0 |1 is obsolete| | --- Comment #14 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 104893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104893&action=edit Bug 25477: The responsive design in opac-main.tt should be correct @media (min-width:768px) and (max-width:979px): The layouts with columns are too narrow. This patch changes the layout to be span8+span4 and puts OpacNav/OpacNavBottom under Login/OpacNavRight in the right column. To test: 1) Navigate to cgi-bin/koha/opac-main.pl with content in OpacNav/OpacNavBottom and Login/OpacNavRight, or look at the attached screenshots: https://bugs.koha-community.org/bugzilla3/attachment.cgi?bugid=25477&action=viewall&hide_obsolete=1 2) Apply patch. 3) Try different screen widths at 678px and above. 4) Sign off. Sponsored-by: Lunds Universitetsbibliotek -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #15 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Options are nice, of course. But only when all available options are fully functional. I suggest we go forward with this. To replace the 3-column layout completely, since it is broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Hi Timothy, Two things, firstly this patch no longer cleanly applies to master and is in need of a rebase. Secondly, I worry that changing bootstrap classes like this will be problematic for existing Koha users who have their OPAC's set up in a certain way. Is this a consideration? Keep in mind I say that without having tested this patch because it won't clean apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #17 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- I found this issue and proposed this solution, which is the only viable one I can find, as it fixes all the layout requirements. If it's not desired or if you have a better solution, then you can go ahead and close the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org