https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26267 --- Comment #1 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 108801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108801&action=edit Bug 26267: Add jQuery validator to memberentrygen.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26267 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Looks good, but it's not necessary to have the $(document).ready part: $(document).ready(function() { $("#entryform").validate({ It's already inside a $(document).ready block. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26267 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108801|0 |1 is obsolete| | --- Comment #4 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 108976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108976&action=edit Bug 26267: Add jQuery validator to memberentrygen.tt To test: 1) Add a new patron. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26267 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26267 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Hi, I don't understand what this patch does, If I try to do steps 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. in the page /cgi-bin/koha/members/memberentry.pl I have the same result "Please enter the same password as above" with and without this patch. Is the difference somewhere else / how I confirm validation happens? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26267 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #7 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- I see now that in memberentrygen.tt that the validator is already included like this: [% Asset.js("js/members.js") | $raw %] Rather than inline, like in the other templates. -- You are receiving this mail because: You are watching all bug changes.