[Bug 33054] New: Koha/Acquisition/Order.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Bug ID: 33054 Summary: Koha/Acquisition/Order.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Koha_Master/2396 koha_1 | # Failed test 'The item is no longer present' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 693. koha_1 | # got: 'Koha::Item=HASH(0x5635919db9a8)' koha_1 | # expected: undef koha_1 | koha_1 | # Failed test 'No messages' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 696. koha_1 | # got: '1' koha_1 | # expected: '0' koha_1 | koha_1 | # Failed test 'The item is no longer present' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 728. koha_1 | # got: 'Koha::Item=HASH(0x563591a190f0)' koha_1 | # expected: undef koha_1 | koha_1 | # Failed test 'Cannot delete biblio and it gets notified' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 732. koha_1 | # got: 'error_delitem' koha_1 | # expected: 'error_delbiblio_items' koha_1 | koha_1 | # Failed test 'The item is no longer present' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 776. koha_1 | # got: 'Koha::Item=HASH(0x5635919db468)' koha_1 | # expected: undef koha_1 | koha_1 | # Failed test 'Cannot delete biblio and it gets notified' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 779. koha_1 | # got: 'error_delitem' koha_1 | # expected: 'error_delbiblio_active_orders' koha_1 | koha_1 | # Failed test 'The item is no longer present' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 820. koha_1 | # got: 'Koha::Item=HASH(0x563591a450a0)' koha_1 | # expected: undef koha_1 | koha_1 | # Failed test 'Cannot delete biblio and it gets notified' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 823. koha_1 | # got: 'error_delitem' koha_1 | # expected: 'error_delbiblio_subscriptions' koha_1 | koha_1 | # Failed test 'The item is not present' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 853. koha_1 | # got: 'Koha::Item=HASH(0x563591a16320)' koha_1 | # expected: undef koha_1 | koha_1 | # Failed test 'The biblio is not present' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 854. koha_1 | # got: 'Koha::Biblio=HASH(0x563591a69bd8)' koha_1 | # expected: undef koha_1 | koha_1 | # Failed test 'No errors' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 856. koha_1 | # got: '2' koha_1 | # expected: '0' koha_1 | koha_1 | # Failed test 'The item is no longer present' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 905. koha_1 | # got: 'Koha::Item=HASH(0x563591a7a1e8)' koha_1 | # expected: undef koha_1 | koha_1 | # Failed test 'Cannot delete on loan item' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 910. koha_1 | # got: '680' koha_1 | # expected: '681' koha_1 | koha_1 | # Failed test 'Item on loan notified' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 911. koha_1 | # got: 'not_same_branch' koha_1 | # expected: 'book_on_loan' koha_1 | koha_1 | # Failed test 'Cannot delete reserved and found item' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 913. koha_1 | # got: '681' koha_1 | # expected: '682' koha_1 | koha_1 | # Failed test 'Item reserved notified' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 914. koha_1 | # got: 'book_on_loan' koha_1 | # expected: 'book_reserved' koha_1 | koha_1 | # Failed test 'Cannot delete on loan item' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 915. koha_1 | # got: 'error_delitem' koha_1 | # expected: 'error_delbiblio_items' koha_1 | # Looks like you planned 54 tests but ran 51. koha_1 | # Looks like you failed 17 tests of 51 run. koha_1 | koha_1 | # Failed test 'cancel() tests' koha_1 | # at t/db_dependent/Koha/Acquisition/Order.t line 940. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 [Bug 20256] Add ability to limit editing of items to home library or library group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |kyle@bywatersolutions.com CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 147234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147234&action=edit Bug 33054: Remove use of can_edit_items Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Acquisition/Order.t 3) git grep "can_edit_item(" should return no results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Did you understand why the failure was occurring randomly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147396&action=edit Bug 33054: Fix unit tests This patch fixes the tests by making sure: - The branch in userenv matches the home/holding branch so there are no circ rules getting in the middle - Gives the user superlibrarian permissions for the same reasons above. To test: 1. Run: $ ktd --shell k$ for i in $(seq 1 20 ); do prove t/db_dependent/Koha/Acquisition/Order.t ; done => FAIL: Notice it fails quite often. You can ctrl+c to interrupt once it has failed at least once. 2. Apply this patch 3. Repeat 1 => SUCCESS: it doesn't fail a single time 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org