[Bug 31563] New: Numbers on claims tab not showing in translated templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Bug ID: 31563 Summary: Numbers on claims tab not showing in translated templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When looking at the patron account details or checkouts tab in the staff interface, the tab Claims is missing the numbers in translated templates. Verified on master for German and Greek. I had filed bug 26561 about this a while ago, but the issue reappered and I don't see how to fix it in the po files. Also we have a second language where it's broken now. I wonder if it's the problem with 0 in templates showing here again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140631&action=edit Screenshot of German interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This shows that the 0 are lost in the translation process: English: <li role="presentation"> <a href="#return-claims" id="return-claims-tab" aria-controls="return-claims" role="tab" data-toggle="tab"> Claims (<span title="Resolved claims" class="label label-default" id="return-claims-count-resolved">0</span> <span title="Unresolved claims" class="label label-default" id="return-claims-count-unresolved">0</span>) </a> </li> French: <li role="presentation"> <a href="#return-claims" id="return-claims-tab" aria-controls="return-claims" role="tab" data-toggle="tab"> Réclamations (<span class="label label-default" id="return-claims-count-resolved" title="Réclamations résolues"></span>) <span class="label label-default" id="return-claims-count-unresolved" title="Réclamations non résolues"></span></a> </li> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30991 Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146462&action=edit Bug 31563: Make zero claims show correctly for translations A tag that only contains 0 is turned into an empty tag by the translation scripts. This turns "Claims ( 0 0 )" into "Claims ( )" in translated templates. To test: * Install an additional language (fr-FR, es-ES) and activate it in the system preferences * Look at the checkouts and details tabs in any patron account in the staff interface * Verify the claims tab shows without the zeros as described above * Apply the patch * Update the translation so the templates are recreated with the change * Verify that the 0 0 now show correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146462|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146518&action=edit Bug 31563: Make zero claims show correctly for translations A tag that only contains 0 is turned into an empty tag by the translation scripts. This turns "Claims ( 0 0 )" into "Claims ( )" in translated templates. To test: * Install an additional language (fr-FR, es-ES) and activate it in the system preferences * Look at the checkouts and details tabs in any patron account in the staff interface * Verify the claims tab shows without the zeros as described above * Apply the patch * Update the translation so the templates are recreated with the change * Verify that the 0 0 now show correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Works perfectly, thanks Katrin! I hadn't noticed, but it goes as least as far as 22.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #5)
Works perfectly, thanks Katrin!
I hadn't noticed, but it goes as least as far as 22.05.
Thanks to you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146518|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147170&action=edit Bug 31563: Make zero claims show correctly for translations A tag that only contains 0 is turned into an empty tag by the translation scripts. This turns "Claims ( 0 0 )" into "Claims ( )" in translated templates. To test: * Install an additional language (fr-FR, es-ES) and activate it in the system preferences * Look at the checkouts and details tabs in any patron account in the staff interface * Verify the claims tab shows without the zeros as described above * Apply the patch * Update the translation so the templates are recreated with the change * Verify that the 0 0 now show correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- That's definitely a bug in the translation script, but I am lazy to dig into it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147170|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147223&action=edit Bug 31563: Make zero claims show correctly for translations A tag that only contains 0 is turned into an empty tag by the translation scripts. This turns "Claims ( 0 0 )" into "Claims ( )" in translated templates. To test: * Install an additional language (fr-FR, es-ES) and activate it in the system preferences * Look at the checkouts and details tabs in any patron account in the staff interface * Verify the claims tab shows without the zeros as described above * Apply the patch * Update the translation so the templates are recreated with the change * Verify that the 0 0 now show correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looks like I broke jenkins. Providing a follow up for missing filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147409&action=edit Bug 31563: (follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. I noticed this, but didn't know it would break the tests. It is obviously a false negative as we are setting the variable a couple lines above and doesn't need the filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #13)
Follow-up pushed to master.
I noticed this, but didn't know it would break the tests. It is obviously a false negative as we are setting the variable a couple lines above and doesn't need the filter.
All variables displayed must be filtered. There is no false negative here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply clean in 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org