https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162270&action=edit Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162273|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162319&action=edit Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30719 |36241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 [Bug 30719] ILL should provide the ability to create batch requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36241 [Bug 36241] ILL Batches are broken -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162319|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162810&action=edit Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) - Install a metadata enrichment plugin, e.g.: https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Failed QA --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pagination works are advertised with this patch. I had to use your data faker script [1] in order to test. But when I scroll down on the page, some weird behavior is trying to scroll up again. Please check. [1] https://github.com/ammopt/koha-ill-dev/blob/master/fake_data.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162810|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163025&action=edit Bug 36130: Fetch all batches for the table Test plan, ktd: - Add 'FreeForm' backend and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) - Install a metadata enrichment plugin, e.g.: https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases - Add 21 batches, run the following command in kshell: for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev - Visit ILL batches page: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list - Notice only 20 batches show. - Apply patch. Notice 20 batches show but now there is a page 2 link. - Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #7)

But when I scroll down on the page, some weird behavior is trying to scroll up again. Please check.

I decided to file a separate bug for that, as it is not introduced by this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Fridolin Somers from comment #11)

Depends on Bug 36241 not in 23.11.x

Hey, sorry Frido I added the dependency because at the time I submitted the bug bug 36241 was required to follow the test plan. This actually depends on bug 30719 which is in 23.11.x so this should ideally be backported. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36130 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.