https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #1 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 182753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182753&action=edit Bug 39977 - Prevent reserves of items the users have already on their possession This patch preventes users from placing a hold on item they haved checked out. 1 Turn system preference AllowHoldsOnPatronsPossessions to Allow. 2 Check out an item from a record with more than one item. 3 Try to put a hold on that record with the same user that checked out the item. You will see that you can select the item the user already has. 4 Apply patch, restart services 5 Repeat step 3. Now you cannot select the item the user has checked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Does the test plan really make sense? 1 Turn system preference AllowHoldsOnPatronsPossessions to Allow. So a hold on the item in my possession should be allowed. But your test plan ends with: 3 Try to put a hold on that record with the same user that checked out the item. You will see that you can select the item the user already has. 4 Apply patch, restart services 5 Repeat step 3. Now you cannot select the item the user has checked out. I don't think that is correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's a change in behavior not everyone might agree with. This feature has been existing for a long while now, so it might be an unwanted change for some if it hasn't been reported as a problem so far. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #6 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- We have libraries tht have AllowHoldsOnPatronsPossessions set to Allow and it would be nice if it remained the same as before. Maybe a third option as suggested? I do not see why we should prevent patrons to make hold on the very same item they already have checked out. It is not our place to say that they cannot do it. If they need the same item, they can have it. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182753|0 |1 is obsolete| | --- Comment #8 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 202091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202091&action=edit Add third option to AllowHoldsOnPatronsPossessions: allow holds on other copies but not on the specific item checked out to the patron This patch adds a third value to AllowHoldsOnPatronsPossessions , updating the choice labels to describe all three options: * allow holds on any item (existing behaviour, value 1) * allow holds on other items only (new, value 2) — holds on the bibliographic record are allowed, but CanItemBeReserved returns alreadypossession if the patron already has that specific item checked out * do not allow holds (existing behaviour, value 0) The item-level check uses Koha::Checkouts to look up whether the specific item is currently issued to the requesting patron. The bib-level check in CanBookBeReserved is unchanged: with value 2 it evaluates as truthy, so no bib-level block is applied, and other copies remain holdable. The template reserve/request.tt is also updated to display a human-readable message ("Item is checked out to this patron") instead of the raw alreadypossession status key, which previously fell through to the catch-all and was rendered verbatim. Tests: the existing AllowHoldOnPatronPossession test subtest in t/db_dependent/Reserves.t is extended with 3 new cases covering value 2 (bib-level allowed, checked-out item blocked, second copy allowed). Greetings, Adolfo. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #9 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 203869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203869&action=edit Bug 39977: Prevent placing holds on items already checked out to a patron AllowHoldsOnPatronsPossessions currently only offers Allow or Don't Allow at the bibliographic level. When set to Allow, it is possible to place an item-level hold on the specific item a patron already has checked out, which is nonsensical. This patch adds a third option: allow holds on the bibliographic record (so other copies remain holdable), but block placing a hold on the specific item the patron already has checked out. Steps to follow: 1. Check out Item A (copy 1 of a bib) to a patron, and ensure a second copy (Item B) exists on the same bib. 2. Log in as that patron and open the hold request page for the bib. 3. Set AllowHoldsOnPatronsPossessions = 'allow holds on any item'. Note that a hold on Item A can be placed. 4. Apply this patch and restart Plack. 5. Set AllowHoldsOnPatronsPossessions = 'allow holds on other items only'. 6. Verify that Item A is now blocked with 'Item is checked out to this patron'. 7. Verify that Item B can still be placed on hold. 8. Verify that AllowHoldsOnPatronsPossessions = 'allow holds on any item' still allows holds on Item A (no regression). 9. Verify that AllowHoldsOnPatronsPossessions = 'do not allow holds' still blocks all holds on the bib (no regression). Signed-off-by: Adolfo Rodríguez <adolfo.rodriguez@xercode.es> Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.