[Bug 7616] New: Remove unused template markup for css_libs, css_module, js_libs, etc.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Bug #: 7616 Summary: Remove unused template markup for css_libs, css_module, js_libs, etc. Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha.sekjal@gmail.com There was a time when it was planned that Koha would automatically load CSS and JS file based on certain contexts. Thus in Auth.pm: # load the template variables for stylesheets and JavaScript $template->param( css_libs => $in->{'css_libs'} ); $template->param( css_module => $in->{'css_module'} ); $template->param( css_page => $in->{'css_page'} ); $template->param( css_widgets => $in->{'css_widgets'} ); $template->param( js_libs => $in->{'js_libs'} ); $template->param( js_module => $in->{'js_module'} ); $template->param( js_page => $in->{'js_page'} ); $template->param( js_widgets => $in->{'js_widgets'} ); *_libs would be general libraries like jQuery and YUI. *_module would be files which were specific to "modules" like circulation or cataloging. *_page would be page-specific files, and *_widgets would be things like the calendar widget I suppose. This method of handling these assets was never implemented and the references to it should be removed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2012-02-28 20:24:20 UTC --- Created attachment 7934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7934 Bug 7616 - Remove unused template markup for css_libs, css_module, js_libs, etc. Removing references to unused template variables and markup. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7934|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 7988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7988&action=edit [Signed-off] Bug 7616 - Remove unused template markup for css_libs, css_module, js_libs, etc. Ok, after looking at the code I can confirm that those variables are not used at all. Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Marked as Passed QA. No regression with this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Will not be pushed to 3.6.x. Trivial patch, but with a small chance of causing a regression. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org