http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-11-23 19:30:48 UTC --- Created attachment 6383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6383 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-11-23 23:00:27 UTC --- Created attachment 6384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6384 [Signed Off] Bug 7259 - Show a count of items pending approval on staff client home and tools pages This patch adds count indicators on the staff client home page and the tools page for the number of items pending approval. On the home page this includes suggestions, comments, and tags. On the tools page a count of pending comments and tags is shown. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Counts appear for all types of actionable items listed, all are clickable through to the proper place. Nice work! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6383|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-07 13:42:07 UTC --- QA comments:

From the code, it appears that if a user can moderate tags, but not comments (or vice versa), they'll see both counts on the intranet-main page, rather than just the type they can moderate.

Changes input params for numberofreviews subroutine. While all usages of this subroutine are updated (just one), I would recommend adding a default value of 1 to the $status variable, so any code that calls the subroutine will continue to function as before. Introduces 3 new dependencies into intranet-main. Not sure there is anything that can be done about that, but it will increase page load time slightly (more just a note here than an actual QA request) While I cannot envision a situation where folks WOULDN'T want to know about these pending items, should the display of these counts be controlled by a system preference? This would prevent sudden, surprising change, which can really freak folks out. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-12-07 15:06:18 UTC --- Created attachment 6637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6637 Follow-up fix This follow-up, to be applied on top of the first, does the following: - Corrects permissions checks on the home page - Adds default parameter (1) to numberofreviews subroutine -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Passed QA --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-07 15:16:37 UTC --- Owen, Thank you for providing those fixes. I'm happy to sign off on your followup, and pass both patches through QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7875 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.