[Bug 10079] New: HomeOrHoldingBranch controlling who can delete when IndependantBranchess should
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Bug ID: 10079 Summary: HomeOrHoldingBranch controlling who can delete when IndependantBranchess should Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: kyle@bywatersolutions.com Reporter: nengard@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Read the conversation below - the short explanation for this bug is that HomeOrHoldingBranch controls who can delete things, but that shouldn't be the case. [09:54] <nengard> "If the HomeOrHoldingBranch (HOHB) is set to 'home' an item cannot be checked out from a different branch, even if it's holding it. HOHB also controls if the the holding or home library can delete an item when IndependantBranches (IB) is on." [09:54] <nengard> but that means if you wnat to allow ILLs within the system [09:55] <nengard> you can't check out items at diff branches if it's set to HOME? [09:55] <khall> yup [09:55] <nengard> but if you set it to holding then the holding branch can delete the item even if its' not theirs [09:55] <khall> so you can either have it so other libraries can check out your items AND delete them, or neither [09:55] <nengard> that's not good [09:56] <khall> nope! File me a bug ; ) [09:56] <nengard> that needs to be split [09:56] <nengard> will do [09:56] <khall> Yeah, I think the deleting should be hard coded to home library for IndependantBranches [09:57] <khall> the other part makes a bit more sense [09:57] <khall> so the bug report should just be "When ID is enabled, don't let ID control which library can delete an item" [09:57] <khall> does that make sense? [09:57] <nengard> No [09:58] <nengard> "When ID is enabled, don't let HOHB control which library can delete an item" [09:58] <nengard> right? [09:58] <khall> right, just make it home library [09:58] <nengard> right -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5159 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|HomeOrHoldingBranch |HomeOrHoldingBranch should |controlling who can delete |not control who can delete |when IndependantBranchess |when IndependantBranches is |should |enabled -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17554&action=edit Bug 10079 - HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled Test Plan: 1) Enable IndependantBranches 2) Set HomeOrHoldingBranch to holding branch 3) Delete an item whose holding branch is your logged in branch, and whose home branch is not 4) Apply this patch 5) Repeat step 3, it should fail 6) Try to delete another items whose home branch is your logged in branch, and whose holding branch is a different branch. This deletetion should succeed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17554|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18046&action=edit [SIGNED-OFF] Bug 10079 - HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled Test Plan: 1) Enable IndependantBranches 2) Set HomeOrHoldingBranch to holding branch 3) Delete an item whose holding branch is your logged in branch, and whose home branch is not 4) Apply this patch 5) Repeat step 3, it should fail 6) Try to delete another items whose home branch is your logged in branch, and whose holding branch is a different branch. This deletetion should succeed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18046|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18098&action=edit [PASSED QA] Bug 10079 - HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled Test Plan: 1) Enable IndependantBranches 2) Set HomeOrHoldingBranch to holding branch 3) Delete an item whose holding branch is your logged in branch, and whose home branch is not 4) Apply this patch 5) Repeat step 3, it should fail 6) Try to delete another items whose home branch is your logged in branch, and whose holding branch is a different branch. This deletetion should succeed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Change is logical, only homebranch should determine if the item can be deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org