[Bug 8840] New: ubuntu-pkg-check.sh script doesn't work on non englush setups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Priority: P5 - low Change sponsored?: --- Bug ID: 8840 Assignee: gmcharlt@gmail.com Summary: ubuntu-pkg-check.sh script doesn't work on non englush setups Severity: normal Classification: Unclassified OS: All Reporter: tomascohen@gmail.com Hardware: All Status: NEW Version: master Component: Command-line Utilities Product: Koha The script queries for the 'Installed:' string, which only appears on english setups. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Summary|ubuntu-pkg-check.sh script |ubuntu-pkg-check.sh script |doesn't work on non englush |doesn't work on non-english |setups |setups -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12566&action=edit Bug 8840 - ubuntu-pkg-check.sh script doesn't work on non englush setups Using dpkg -s to query for installed packages works in languages other than english. Added some switches (and checks for them) too. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12566|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12594&action=edit Bug 8840 - ubuntu-pkg-check.sh script doesn't work on non english setups Using dpkg to query for installed packages works in languages other than english. Added some switches to conveniently display the needed apt-get command for installing Koha's dependencies: -r | --report Report the status of Koha's dependencies -ic | --install-command Display the install command for the missing dependencies -h | --help Display this help message Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ubuntu-pkg-check.sh script |ubuntu-pkg-check.sh fix and |doesn't work on non-english |extend functionality |setups | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12594|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12599&action=edit Replaced ubuntu-pkg-check.sh with one that works properly. Test ------ Prove The Problem ================= 1) Fresh install of Ubuntu 12.04 (Spanish) 2) ./install_misc/ubuntu-pkg-check.sh -- This is to get the base output to compare. 3) sudo apt-get install libyaml-perl 4) ./install_misc/ubuntu-pkg-check.sh -- Identical output, even though we installed a dependency! 5) apply patch 6) ./install_misc/ubuntu-packages.sh -r -- Should be one line difference now! 5) Fresh install of Ubuntu 12.04 (English) 6) ./install_misc/ubuntu-pkg-check.sh -- Indentical to first output, no dependencies installed yet. 7) sudo apt-get install libyaml-perl 8) ./install_misc/ubuntu-pkg-check.sh -- It should match the one line difference output. 9) apply patch 10) ./install_misc/ubuntu-packages.sh -r -- It should match the one line difference output. Test New Features (Help) ======================== 11) ./install_misc/ubuntu-packages.sh -h 12) echo $? -- It should give a nice help screen. And the echo result of 0. 13) ./install_misc/ubuntu-packages.sh 14) echo $? -- It should give a nice help screen. And the echo result of 1 -- based you gave incorrect parameters. 15) ./install_misc/ubuntu-packages.sh -badparm 16) echo $? -- It should give a nice help screen. And the echo result of 1 -- based you gave incorrect parameters. Test New Features (Sudo apt-get command output) =============================================== 17) ./install_misc/ubuntu-packages.sh -ic -- It should output an appropriate sudo apt-get command to install the dependencies. 18) Cut and paste the command, then press enter! -- install everything! 19) ./install_misc/ubuntu-packages.sh -ic -- It should say it thinks everything is installed, and tell you to run a koha_perl_deps.pl -m -u. -- Yes, koha_perl_deps.pl may list outstanding items. That's a different bug report to come. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Revised/Clarified Test Plan --------------------------- Prove The Problem ================= 1) Fresh install of Ubuntu 12.04 (Spanish) 2) ./install_misc/ubuntu-pkg-check.sh -- This is to get the base output to compare. -- a whole bunch of library name = none. 3) sudo apt-get install libyaml-perl 4) ./install_misc/ubuntu-pkg-check.sh -- Identical output, even though we installed a dependency! 5) apply patch 6) ./install_misc/ubuntu-packages.sh -r -- libyaml-perl should show the correct version number. 7) Fresh install of Ubuntu 12.04 (English) 8) ./install_misc/ubuntu-pkg-check.sh -- Indentical to first output, no dependencies installed yet. 9) sudo apt-get install libyaml-perl 10) ./install_misc/ubuntu-pkg-check.sh -- libyaml-perl should show the correct version number. 11) apply patch 12) ./install_misc/ubuntu-packages.sh -r -- libyaml-perl should show the correct version number. Test New Features (Help) ======================== 13) ./install_misc/ubuntu-packages.sh -h 14) echo $? -- It should give a nice help screen. And the echo result of 0. 15) ./install_misc/ubuntu-packages.sh 16) echo $? -- It should give a nice help screen. And the echo result of 1 -- based you gave incorrect parameters. 17) ./install_misc/ubuntu-packages.sh -badparm 18) echo $? -- It should give a nice help screen. And the echo result of 1 -- based you gave incorrect parameters. Test New Features (Sudo apt-get command output) =============================================== 19) ./install_misc/ubuntu-packages.sh -ic -- It should output an appropriate sudo apt-get command to install the dependencies. 20) Cut and paste the command, then press enter! -- install everything! 21) ./install_misc/ubuntu-packages.sh -ic -- It should say it thinks everything is installed, and tell you to run a koha_perl_deps.pl -m -u. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12599|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12610&action=edit Bug 8840 - ubuntu-pkg-check.sh fix and extend functionality First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- I just noticed a minor typo in the comments. "dor" instead of "dot". I'll let you fix it, Tomás. And don't forget to set the status to "Needs Signoff" when you do. I don't think either of us should sign it off, since we both worked on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12610|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12613&action=edit Bug 8840 - ubuntu-pkg-check.sh fix and extend functionality Fixed a problem with package queries. First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12613|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13200&action=edit Bug 8840 - ubuntu-pkg-check.sh fix and extend functionality First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Small patch --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Tomas, I looked into your patch, testing on an Ubuntu 12.04 installation in German. -h -r and -ic seem to work nicely. On my system all dependencies were installed, so I took a look at the ubuntu.12.04.packages file and picked something to remove it. 'sudo apt-get remove libyaml-perl' After this step ./koha_perl_deps.pl -c -a reports missing packages: Test::YAML::Valid 0 0.04 No YAML 0 0.71 Yes Next I ran your script: ./install_misc/ubuntu-packages.sh -ic # Using the ./install_misc/ubuntu.12.04.packages file as source #............................................................................................................................................ # All dependencies installed! # Please confirm the version numbers are sufficient # By running koha_perl_deps.pl -m -u. So it doesn't seem to detect the missing package? Maybe I am doing something wrong, please take a look at the patch and my test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Greetings, Your testplan is flawed in that you didn't confirm there were no missing discrepancies between CheckDependencies.pm and the ubuntu[.blah].packages file. This patch should generate identical perl library output as koha_perl_deps *IF* all the perl dependencies listed in CheckDependencies.pm are also listed in the .packages file. Sadly, you can't just count, because sometimes multiple libraries are contained in a single package. For example, Blah::Blah might also be in Blah's libBlah-perl package. And the .packages files (ubuntu.12.04.packages and ubuntu.packages) should generally be identical, though I could see ubuntu.packages being larger as it also may have to deal with older installations. Though, I think we've been lazy and just copying the latest .packages file to it. :) What you have stumbled upon is the installation mess that needs cleaning up, and this is a tiny step towards it. GPML... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Assignee|tomascohen@gmail.com |mtompset@hotmail.com --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 14171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14171&action=edit Tweak to patch to solve false "All dependencies installed!" I re-read the code and noticed that it was not accumulating MISSING_PATCHES. I was also concerned that perhaps the != might not work properly. This needs to be applied on top of the other patch. Test Plan --------- 1) Installed perl libraries nicely for a git install. 2) ./koha_perl_deps.pl -m -u Only lists Data::Pagination missing and String::Random too low version. 3) sudo apt-get remove libyaml-syck-perl Triggers removal of yaml syck and date manip. 4) ./koha_perl_deps.pl -m -u Now four things listed. 5) ~/kohaclone/install_misc$ ./ubuntu-packages.sh -ic # Using the ./ubuntu.12.04.packages file as source #............................................................................................................................................ # Copy and paste the following command to install all Koha's dependencies on your system: # Note: this command will run with admin privileges. Make sure your user has sudo rights sudo apt-get install libyaml-syck-perl libdate-manip-perl 6) be happy that this is what was removed and needs to be added. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13200|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 14176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14176&action=edit Fix and extend script functionality Patch 1/2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14171|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 14177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14177&action=edit Correct incorrect reporting -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is almost signed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus@enger.priv.no --- Comment #15 from Magnus Enger <magnus@enger.priv.no> --- After applying the patches, I get: $ perl koha_perl_deps.pl -m -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- CHI 0 * 0.36 No CHI::Driver::Memcached 0 * 0.12 No Data::Pagination 0 * 0.44 No -------------------------------------------------------------------------------------------- Total modules reported: 3 * Module is missing or requires an upgrade. $ ./install_misc/ubuntu-packages.sh -ic # Using the ./install_misc/ubuntu.12.04.packages file as source #............................................................................................................................................ # Copy and paste the following command to install all Koha's dependencies on your system: # Note: this command will run with admin privileges. Make sure your user has sudo rights sudo apt-get install libchi-perl libchi-driver-memcached-perl So the two tools agree on CHI and CHI::Driver::Memcached, but ubuntu-packages.sh does not pick up the missing Data::Pagination. As this dependency is not listed in ubuntu.12.04.packages this is actually to be expected, and as far as I understand, fixing the lists of dependencies is beyond the scope of this bug. ubuntu-packages.sh -h gives the help message ubuntu-packages.sh -r prints dependencies and versions As far as I can tell ubuntu-packages.sh does what it is supposed to do so I'll sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14176|0 |1 is obsolete| | --- Comment #16 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 16539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16539&action=edit Bug 8840 - [SIGNED-OFF] ubuntu-pkg-check.sh fix and extend functionality First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised, see Bugzilla for details. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14177|0 |1 is obsolete| | --- Comment #17 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 16540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16540&action=edit Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!" Reordered logic to accumulate MISSING_PATCHES variable and tweak condition to be certain it was not failing. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised, see Bugzilla for details. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16539|0 |1 is obsolete| | Attachment #16540|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18096&action=edit Bug 8840 - [SIGNED-OFF] ubuntu-pkg-check.sh fix and extend functionality First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised, see Bugzilla for details. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18097&action=edit [PASSED QA] Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!" Reordered logic to accumulate MISSING_PATCHES variable and tweak condition to be certain it was not failing. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised, see Bugzilla for details. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org