[Bug 12615] New: Remove CGI::scrolling_list from marc_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Bug ID: 12615 Summary: Remove CGI::scrolling_list from marc_subfields_structure.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org Many instances to remove in this file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29897&action=edit Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Other options' box Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard@myacpl.org |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #1)
'Koha field' is new (for me at last)
Actually it should be in the "Advanced constraints" tab. With your patch, I get the "Koha field" in the last tab "Other options (choose one)" but I get "Koha link:HASH(0xc9b9ca8)" in the "Advanced constraints". Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29897|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30131&action=edit Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #2)
Actually it should be in the "Advanced constraints" tab. With your patch, I get the "Koha field" in the last tab "Other options (choose one)" but I get "Koha link:HASH(0xc9b9ca8)" in the "Advanced constraints".
Marked as Failed QA.
Oops, FQA is absolutely correct! Fixed now :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30131|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30260&action=edit Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30260|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30315&action=edit [PASSED QA] Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org