http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #3 from Srikanth Dhondi <srikanth@catalyst.net.nz> --- Created attachment 13472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13472&action=edit [SIGNED-OFF] Bug 8918: ILS-DI: Calculate rank when placing hold Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12810|0 |1 is obsolete| | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 12810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12810 Bug 8918: ILS-DI: Calculate rank when placing hold Srikanth Dhondi, thanks for your commit. When you upload a signed-off patch, don't forget to obsolete the initial one. If you use git bz, just use the -e flag = git bz attach -e 8918 HEAD for example If you don't use git bz, it's a little bit tricky to find, look at patch "Detail" (on the right of the patch), then click on "edit details", it's on the left -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to comment #5)

Have you checked that it works as expected in all cases ? (just asking, I haven't proved there's a problem)

Not in *all* cases because I just can't imagine *all* test cases here, but I tested different scenario. I agree that _get_reserve_next_rank should move from C4::ILSDI. About the syspref ReservesNeedReturns, I'm not sure of what it deserves, but the sure thing is that rank should not be calculated if ReservesNeedReturns = 0. I'll send the patch soon. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Julian: Could you provide a test plan please? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Test plan: - Get a valid biblionumber and two borrowernumbers that can hold this biblio record On master: - Go to http://opac.your-library/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER1&bib_id=BIBLIONUMBER&request_location=127.0.0.1 and to http://opac.your-library/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER2&bib_id=BIBLIONUMBER&request_location=127.0.0.1 - Then check the holds on your biblio record. Under column 'Priority', you should see 'Waiting' for both reserves. - Cancel these holds Apply the patch: - Go to http://opac.your-library/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER1&bib_id=BIBLIONUMBER&request_location=127.0.0.1 and to http://opac.your-library/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER2&bib_id=BIBLIONUMBER&request_location=127.0.0.1 - Then check the holds on your biblio record. Under column 'Priority', you should now see '1' for the first borrowernumber and '2' for the other. Apply the same test plan for HoldItem service. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin, according to syspref description, ReservesNeedReturns = 0 means "Automatically mark holds as found and waiting when a hold is placed specifically on them and they are already checked in." Marking a hold as found and waiting implies to set priority/rank to 0 and to set the flag 'found' to 'W'. That's why we don't have to calculate the next rank in this case. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I am including a QA followup patch, just sideways related to this report, but the pref description of ReservesNeedReturns could use the slightly clearer comment that it only works on item level holds. In the same run I update the description of ILS-DI:AuthorizedIPs. Note that I am not that enthusiastic about the ':' in pref names there. But the desc needs the comment that you should separate with , and not use spaces. Note that another report probably should widen that: allow spaces, commans and colons between those ip's and test with a regex [';\s] etc. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: This needs still some attention. Tested e.g. ilsdi.pl?service=HoldItem&patron_id=1&bib_id=196917&item_id=199724 with ReservesNeedReturns enabled. Result: reserves record includes rank 0 but found is NULL. This combination is not allowed. Note I stumbled over it by accident, the holding branch was different from home branch.. But you should handle this transit case also. I saw already some code moving from Services.pm to Reserves. Note that I still have the impressions that there is too much reserves code in HoldTitle and even more in HoldItem. Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 17882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17882&action=edit Bug 8918: Move $rank and $found calculation into AddReserve and update scripts that call it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13472|0 |1 is obsolete| | Attachment #15435|0 |1 is obsolete| | Attachment #17376|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 17888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17888&action=edit [SIGNED-OFF] Bug 8918: ILS-DI: Calculate rank when placing hold This is a squash of the 3 following patches Bug 8918: ILS-DI: Calculate rank when placing hold Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz> -- Bug 8918: QA fixes - Move C4::ILSDI::_get_reserve_next_rank to C4::Reserves::GetReserveNextRank - Do not calculate rank if ReservesNeedReturns = 0 Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- 8918 QA Followup for pref descriptions Updating pref descriptions for ReservesNeedReturns and ILS-DI:AuthorizedIPs. Just sideway related to this report, but not important enough to separate. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17882|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 17890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17890&action=edit Bug 8918: Move $rank and $found calculation into AddReserve and update scripts that call it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17888|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21328&action=edit [SIGNED-OFF] Bug 8918: ILS-DI: Calculate rank when placing hold This is a squash of the 3 following patches Bug 8918: ILS-DI: Calculate rank when placing hold Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz> -- Bug 8918: QA fixes - Move C4::ILSDI::_get_reserve_next_rank to C4::Reserves::GetReserveNextRank - Do not calculate rank if ReservesNeedReturns = 0 Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- 8918 QA Followup for pref descriptions Updating pref descriptions for ReservesNeedReturns and ILS-DI:AuthorizedIPs. Just sideway related to this report, but not important enough to separate. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17890|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 21330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21330&action=edit Bug 8918: Move $rank and $found calculation into AddReserve and update scripts that call it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-24 last check this| | --- Comment #28 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- In order to get these patches further, I would recommend adding a test plan to the commit messages of each individual patch. And please include some unit tests (in a followup) for the new or adjusted routines in modules to increase the chance of getting these patches pushed. Thank you very much. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21328|0 |1 is obsolete| | Attachment #21329|0 |1 is obsolete| | Attachment #21330|0 |1 is obsolete| | --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22731&action=edit Bug 8918: Calculate hold priority in AddReserve Priority was calculated outside of this sub, in separate places. Priority was not calculated when using ILS-DI. This patch factorize code by putting the priority calculation code into AddReserve. Test plan: 1/ Place multiple holds in staff interface and check the priority is incremented for each hold. 2/ Do the same in OPAC. 3/ Place multiple holds using ILS-DI HoldTitle service: /cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER and check the priority is incremented for each hold. 4/ Do the same using HoldItem service: /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&item_id=ITEMNUMBER Note: this is a squashed version of 3 previous patches -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22732|0 |1 is obsolete| | --- Comment #34 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24864&action=edit Bug 8918: Add a unit test for GetReserveNextRank Rebased on January 29, 2014 (marcelr) Added text on the two 'is'-statements. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |benjamin.rokseth@kul.oslo.k | |ommune.no -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. de Rooy from comment #36)

benjamin.rokseth@kul.oslo.kommune.no changed status to Signed off?

Could you please clarify?

I appreciate your interest in this report, Benjamin. But I take the liberty to reset the status to Needs Signoff in lack of evidence that these two patches have been tested and are ready for QA. Note that I was looking at them too and I will still continue with them. But the changes proposed are certainly not trivial and concern an area (Circulation/Holds) which is rather complex and not bug free. At this moment I actually feel that this report is not yet ready for signoff, but this needs some documentation too. To be continued.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #39 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Julian: Would you mind if I split this report into two pieces? I would rather make a distinction between 1) The original bug in HoldTitle and HoldItem for ILS-DI 2) Making changes in AddReserves -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17376|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24863|0 |1 is obsolete| | --- Comment #41 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24880&action=edit Bug 8918: Fix reserve priority in ILS-DI Priority was not calculated when using ILS-DI. A new routine is added to Reserves.pm that calculates it. A separate report will make the changes needed in Reserves in order to use this new routine more generally. This patch does therefore only affect ILS-DI. Note: ILS-DI already allows you to generate multiple holds on a biblio or item for the same patron. This patch does not change that behavior. Test plan: [1] Place multiple holds using ILS-DI HoldTitle service: /cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&request_location=test Check the priority. [2] Do the same using HoldItem service: /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&item_id=ITEMNUMBER Check the priority again. [3] Use a biblio with multiple items. Place item level holds on both. Check in one of these items in another branch. Confirm transfer. Check in the other item in the original branch. Confirm hold. Now you have a waiting and a transit hold. Test HoldTitle and HoldItem service again a few times. [4] Enable AllowHoldDateInFuture and add a future hold. Now test HoldTitle and HoldItem again and check if these holds are inserted before the future hold (lower priority). January 29, 2014: Rebased this patch and amended it to make a distinction between fixing the ILS-DI bug and using the new routine. Updated commit message and test plan (marcelr). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24882|0 |1 is obsolete| | --- Comment #44 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24883&action=edit Bug 8918: Add a unit test for CalculatePriority Rebased on January 29, 2014 (marcelr) Added text on the two 'is'-statements. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24881|0 |1 is obsolete| | --- Comment #46 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24885&action=edit 8918 QA Followup for pref descriptions Updating pref descriptions for ReservesNeedReturns and ILS-DI:AuthorizedIPs. Just sideway related to this report, but not important enough to separate. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #48 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Setting it back to Assigned for a short while since I stil want to add a few additional tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24887|0 |1 is obsolete| | --- Comment #50 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24888&action=edit Bug 8918: Follow-up for some more unit tests for CalculatePriority Adding a few unit tests, including the following situations: Placing a hold when there is a wait. Placing a hold when there is a future hold. Calculating priority with future date. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #51 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Julian, Do you agree with the amendments? Note that I also renamed GetReserveNextRank to CalculatePriority. In the context of the Reserves module priority is used more often than rank. Hopefully, this will create less confusion. I also noted some points for adjustment in HoldTitle and HoldItem on report 11641. Using the new routine in AddReserves is moved to report 11640. This makes testing this report much easier and chances of getting it pushed much higher. All by all, I will sign off on this report now. And give some attention to 11640 later. I leave 11641 for you :) If you would still see something here that blocks this report, please feel free to change the status again. Hopefully this will give this report a push in the right direction now.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #52 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Still see something. Please wait :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24888|0 |1 is obsolete| | --- Comment #53 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24920&action=edit Bug 8918: Follow-up for some more unit tests for CalculatePriority Adding a few unit tests, including the following situations: Placing a hold when there is a wait. Placing a hold when there is a future hold. Calculating priority with future date. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24884|0 |1 is obsolete| | --- Comment #55 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25080&action=edit Bug 8918: Fix reserve priority in ILS-DI Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24886|0 |1 is obsolete| | --- Comment #57 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25082&action=edit Bug 8918: Add a unit test for CalculatePriority Rebased on master and signed off Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #59 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25084&action=edit Bug 8918: t/db_dependant/Reserves.t fails if marcflavour is UNIMARC Set marcflavour to MARC21 to make tests pass. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #62 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25119&action=edit Bug 8918: Follow-up for use of AddBiblio in Reserves.t with UNIMARC Changed title and author field for UNIMARC. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested for MARC21, NORMARC and UNIMARC by adding temporary set_preference.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25080|0 |1 is obsolete| | --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25139&action=edit Bug 8918: Fix reserve priority in ILS-DI Priority was not calculated when using ILS-DI. A new routine is added to Reserves.pm that calculates it. A separate report will make the changes needed in Reserves in order to use this new routine more generally. This patch does therefore only affect ILS-DI. Note: ILS-DI already allows you to generate multiple holds on a biblio or item for the same patron. This patch does not change that behavior. Test plan: [1] Place multiple holds using ILS-DI HoldTitle service: /cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&request_location=test Check the priority. [2] Do the same using HoldItem service: /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&item_id=ITEMNUMBER Check the priority again. [3] Use a biblio with multiple items. Place item level holds on both. Check in one of these items in another branch. Confirm transfer. Check in the other item in the original branch. Confirm hold. Now you have a waiting and a transit hold. Test HoldTitle and HoldItem service again a few times. [4] Enable AllowHoldDateInFuture and add a future hold. Now test HoldTitle and HoldItem again and check if these holds are inserted before the future hold (lower priority). January 29, 2014: Rebased this patch and amended it to make a distinction between fixing the ILS-DI bug and using the new routine. Updated commit message and test plan (marcelr). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25082|0 |1 is obsolete| | --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25141&action=edit Bug 8918: Add a unit test for CalculatePriority Rebased on January 29, 2014 (marcelr) Added text on the two 'is'-statements. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25118|0 |1 is obsolete| | --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25143&action=edit Bug 8918: t/db_dependent/Reserves.t fails if marcflavour is UNIMARC Set marcflavour to MARC21 to make tests pass. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Works for MARC21. But I would prefer a better fix for UNIMARC. Will send a follow-up for that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi Depends on| |12630 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.