[Bug 29145] New: Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Bug ID: 29145 Summary: Allow patrons to have overdue items that would not result in debarment when removing overdue debarments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The default behavior when returning an item, is to check if a patron is debarred, in that case check if the patron has any other overdue items left, and if not to lift the debarment. One might argue that it would be more logical to lift the debarment on the same conditions on which the Patron was debarred, so if the patron is in a state that would not cause debarment, the patron should not be debarred. That is: only if the patron has items that are overdue enough to cause restriction/debarment the debarment should be maintained. This patch provides a system preference, that if set instead of checking for any delayed items on returning an item, uses the delay used for restrictions to check for items exceeding that limit, and if none are found lifts the debarment. (Stefan Berndtsson at Gothenburg University library is the original author of this patch). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 125495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125495&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David and Stefan, looking into this and trying to rephrase what I think this does: If an item is returned, we check if the patron is still restricted by an OVERDUES restriction. If that's the case, we check if they have any remaining checkouts that have triggered an OVERDUES restriction (are overdue long enough). If there are no such remaining checkouts, we undebar. Is that about right? 1) Could you please add a test plan and some description to the commit message? 2) You are missing the sysprefs.sql change for adding a new system preference in your patch. And in the pref file, don't use yes/no, but 0/1. 3) The new pref is named: ODueDebarmentRemovalAllowUnrestricted I wonder if instead of using a new pref, it might be nicer to change the existing pref AutoRemoveOverduesRestrictions to have 3 options: * Don't lift restriction * Lift restriction if no more overdues * Lift restriction if remaining overdues didn't trigger a restriction (some native speaker might be able to help with a more elegant phrasing) If we go with 2 separate preferences, they should be linked to each other in the .pref (there are a lot of examples for this in the files). Also a bit different name might be nice... but I have to admit, I don't have a good idea right now. I think I'd really prefer not to have them separate. 4) Missing unit tests for the changes in Circulation.pm and Patron.pm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 16882 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Michael Spagnuolo <mspagnuolo@nrhtx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo@nrhtx.com --- Comment #4 from Michael Spagnuolo <mspagnuolo@nrhtx.com> --- Hi, I would like to see movement on this. We currently allow a three day grace period after the due date, so we would like the restriction to be removed even if a patron still has overdues. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125495|0 |1 is obsolete| | --- Comment #5 from David Gustafsson <glasklas@gmail.com> --- Created attachment 140819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140819&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #6 from David Gustafsson <glasklas@gmail.com> --- Created attachment 140820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140820&action=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from David Gustafsson <glasklas@gmail.com> --- Hi! Thanks for the review, good points. Have now added tests and changed AutoRemoveOverduesRestrictions to have three different options instead of using two system preferences. I think all issues should now be resolved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #8 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- David, how's this for a test plan? 1: define overdue notice & status triggers such that a notice and restriction are generated at 2 days overdue 2: prepare 3 patrons with 1 item overdue by 1 day and 1 item overdue by 2 days. We'll call these Patron Group A 3: prepare 3 patrons with 2 items 2 days overdue. We'll call these Patron Group B 4: Run the overdues cron, confirm that notices and restrictions have generated on all of your patrons as desired 5: set AutoRemoveOverduesRestrictions to Don't. 6: Check in all items for a Group A patron. Confirm no restrictions are lifted. 7: Check in all items for a Group B patron. Confirm no restrictions are lifted. 8: set AutoRemoveOverduesRestrictions to "if patron has no remaining overdue items" 9: On a Group A patron, check in the 2 day overdue item. Confirm no restrictions are lifted. 10: On the same patron, check in the 1 day overdue item. Confirm the restriction is lifted 11: On a Group B patron, check in both items. Confirm the restriction is not lifted until both are returned. 12: set AutoRemoveOverduesRestrictions to "if patron has no remaining items that is cause for debarment" 13: On a Group A patron, check in the 2 day overdue item. Confirm the restriction is lifted. 14: On a Group B patron, check in both items. Confirm the restriction is not lifted until both are returned. 15: prove t/db_dependent/Circulation/MarkIssueReturned.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I went through the test plan I posted above, but hit an issue at step 14. I have a patron with two items both 2 days overdue. My overdue notice triggers generate a notice and a restriction at 2 days overdue. When I run the overdues cron, the notice and restriction generate as expected. I have AutoRemoveOverduesRestrictions set to when_no_overdue_causing_debarment. My restriction gets removed when I check in the first of the two items. This is incorrect; I should have to check in both items for the restriction to be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #10 from David Gustafsson <glasklas@gmail.com> --- Created attachment 141822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141822&action=edit Bug 29145: Fix conditions for patron debarring overdues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #9)
I went through the test plan I posted above, but hit an issue at step 14. I have a patron with two items both 2 days overdue. My overdue notice triggers generate a notice and a restriction at 2 days overdue. When I run the overdues cron, the notice and restriction generate as expected. I have AutoRemoveOverduesRestrictions set to when_no_overdue_causing_debarment. My restriction gets removed when I check in the first of the two items. This is incorrect; I should have to check in both items for the restriction to be removed.
Hi! Thanks for the feedback and the test plan. Without it would not have discovered the edge-case where overdue items should trigger debarments when are delayed the same number of days that would trigger debarment. Have also updated the tests to reflect your test plan and result in the same error with the previous code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141822|0 |1 is obsolete| | --- Comment #12 from David Gustafsson <glasklas@gmail.com> --- Created attachment 141823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141823&action=edit Bug 29145: Fix conditions for patron debarring overdues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Lukas Koszyk <lukasz.koszyk@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lukasz.koszyk@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Michaela Sieber <michaela.sieber@kit.edu> --- Thanks a lot for the patches and the test plan! We can confirm that it works as expected :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140819|0 |1 is obsolete| | --- Comment #14 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 142394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142394&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140820|0 |1 is obsolete| | --- Comment #15 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 142395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142395&action=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141823|0 |1 is obsolete| | --- Comment #16 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 142396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142396&action=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #17 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Michaela Sieber from comment #13)
Thanks a lot for the patches and the test plan! We can confirm that it works as expected :-)
Superb! I think this open source thing might just work :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to fill in the Assignee field when taking on a bug, thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, 1) QA scipt Please run the QA tests on your patches before submitting, they are catching lots of the tiny stuff that can otherwise hold things up unnecessarily. If you are using ktd for development, you can just run: qa -v 2 from kshell. OK C4/Circulation.pm FAIL Koha/Patron.pm FAIL critic # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). FAIL pod coverage POD is missing for has_debarring_overdues POD is missing for trim_whitespaces FAIL installer/data/mysql/atomicupdate/bug_29145-modify_AutoRemoveOverduesRestrictions-syspref.pl FAIL file permissions File must have the exec flag FAIL spelling prefernce ==> preference OK installer/data/mysql/atomicupdate/odue-debarment-removal-allow-unrestricted.pl OK installer/data/mysql/mandatory/sysprefs.sql OK misc/cronjobs/overdue_notices.pl FAIL t/db_dependent/Circulation/MarkIssueReturned.t FAIL spelling remaning ==> remaining remaning ==> remaining I am providing a follow-up for the typos, but I'll need you to have a look at the missing POD for has_overdues (trim_whitespace is a false one) and especially the Perlcritic violation. I see that you have written a long comment on has_overdues, so this is about reformatting this into a proper POD entry. 2) Bug number was missing from database update. Fixed together with the typos in a follow-up patch. 3) Changes to Patron.pm We don't have a hard rule here yet, but we should always avoid using SQL. I am not sure if this qualifies as blocker right now as we don't have a written rule, so leaving as a note. Please fix 1)! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142394|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142814&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142395|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142815&action=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142396|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142816&action=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142817&action=edit Bug 29145: (QA follow-up) Fix missing bug number in database update and typos Fixes some typos in test and update message that were highlighted by the QA tools. Adds missing bug number to the atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #24 from David Gustafsson <glasklas@gmail.com> --- Created attachment 143213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143213&action=edit Bug 29145: (QA follow-up) Add missing POD and don't return undef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from David Gustafsson <glasklas@gmail.com> --- Thanks for the feedback, will be sure to run qa-tools next time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After QA feedback it's usually ok to set back to signed off directly :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142814|0 |1 is obsolete| | --- Comment #27 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144773&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142815|0 |1 is obsolete| | --- Comment #28 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144774&action=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142816|0 |1 is obsolete| | --- Comment #29 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144775&action=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142817|0 |1 is obsolete| | --- Comment #30 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144776&action=edit Bug 29145: (QA follow-up) Fix missing bug number in database update and typos Fixes some typos in test and update message that were highlighted by the QA tools. Adds missing bug number to the atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143213|0 |1 is obsolete| | --- Comment #31 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144777&action=edit Bug 29145: (QA follow-up) Add missing POD and don't return undef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #32 from David Gustafsson <glasklas@gmail.com> --- Ok! Got some weird error trying to apply the current patch, so reconstructed the patch set using our local branch. Should now apply to the current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144773|0 |1 is obsolete| | --- Comment #33 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144778&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144774|0 |1 is obsolete| | --- Comment #34 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144779&action=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144775|0 |1 is obsolete| | --- Comment #35 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144780&action=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144776|0 |1 is obsolete| | --- Comment #36 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144781&action=edit Bug 29145: (QA follow-up) Fix missing bug number in database update and typos Fixes some typos in test and update message that were highlighted by the QA tools. Add missing bug number to the atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144777|0 |1 is obsolete| | --- Comment #37 from David Gustafsson <glasklas@gmail.com> --- Created attachment 144782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144782&action=edit Bug 29145: (QA follow-up) Add missing POD and don't return undef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #38 from David Gustafsson <glasklas@gmail.com> --- Forgot to add the signed-off lines for the recreacted commits (which should be identical to the previously signed-off ones). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145720&action=edit Bug 29145: (QA follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31095 CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145749&action=edit Bug 29145: (QA follow-up) Rename has_debarring_overdues to has_restricting_overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145750&action=edit Bug 29145: (QA follow-up) Use objects instead of straight SQL queries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145751&action=edit Bug 29145: (QA follow-up) Remove debugging line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #44 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Hi all! What's the current status of this patch? Is "Patch doesn't apply" accurate? David, will you be working on rebasing it? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #45 from Michaela Sieber <michaela.sieber@kit.edu> --- This bug had status Passed QA , what happened? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Koha's codebase moved on and this needs to be rebased. Rebasing means that conflicts with the now changed files in master need to be resolved, because this code doesn't 'fit' any more. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #47 from Tomás Cohen Arazi <tomascohen@gmail.com> --- DAvid, Kyle, can we rebase this ASAP please? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31095 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- And please check the changes introduced by bug 31095. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #49 from Michaela Sieber <michaela.sieber@kit.edu> --- Good Morning David, we are very interested in this enhancement! It would be great if you could do a rebase. I could test your patches and sign off ASAP so we have a chance to bring it into 23.11 . greetings from Germany :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This has actually already passed qa.. it just needs a rebase to get it pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144778|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153804&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144779|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153805&action=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144780|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153806&action=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144781|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153807&action=edit Bug 29145: (QA follow-up) Fix missing bug number in database update and typos Fixes some typos in test and update message that were highlighted by the QA tools. Add missing bug number to the atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144782|0 |1 is obsolete| | --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153808&action=edit Bug 29145: (QA follow-up) Add missing POD and don't return undef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145720|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153809&action=edit Bug 29145: (QA follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145749|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153810&action=edit Bug 29145: (QA follow-up) Rename has_debarring_overdues to has_restricting_overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145750|0 |1 is obsolete| | --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153811&action=edit Bug 29145: (QA follow-up) Use objects instead of straight SQL queries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145751|0 |1 is obsolete| | --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153812&action=edit Bug 29145: (QA follow-up) Remove debugging line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153813&action=edit Bug 29145: Replace GetDebarments in unit tests GetDebarments was removed and replaced by $patron->restrictions. The tests needed some adjustments to reflect that change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153814&action=edit Bug 29145: Perltidy files and added code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This was ultimately not a bad rebase. The trouble came from bug 31095 removing GetDebarments. The only conflicts where in C4/Circulation.pm MarkIssueReturned in the last paragraph: # Possibly remove any OVERDUES related debarment my $overdue_restrictions = $patron->restrictions->search( { type => 'OVERDUES' } ); if ( C4::Context->preference('AutoRemoveOverduesRestrictions') ne 'no' && $patron->is_debarred ) { my $remove_restrictions = C4::Context->preference('AutoRemoveOverduesRestrictions') eq 'when_no_overdue_causing_debarment' ? !$patron->has_restricting_overdues( { issue_branchcode => $issue_branchcode } ) : !$patron->has_overdues; if ( $remove_restrictions && $overdue_restrictions->count ) { DelUniqueDebarment( { borrowernumber => $borrowernumber, type => 'OVERDUES' } ); } } Once I got it rebased, I rewrote the tests to use $patron->restrictions instead of GetDebarments. Tests pass now again! I fixed some "John Doe" commit authorships from Kyle - realizing that our mailmap already resolves "John Doe" to Kyle automatically, which is a little confusing when tig, git log and the QA test show different things. Should be all nice now :) And last but not least: I applied some perltidy to the files. I didn't get a perfect result sticking to the changed paragraphs, but it's very close. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153804|0 |1 is obsolete| | --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156392&action=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153805|0 |1 is obsolete| | --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156393&action=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153806|0 |1 is obsolete| | --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156394&action=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153807|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156395&action=edit Bug 29145: (QA follow-up) Fix missing bug number in database update and typos Fixes some typos in test and update message that were highlighted by the QA tools. Add missing bug number to the atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153808|0 |1 is obsolete| | --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156396&action=edit Bug 29145: (QA follow-up) Add missing POD and don't return undef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153809|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156397&action=edit Bug 29145: (QA follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153810|0 |1 is obsolete| | --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156398&action=edit Bug 29145: (QA follow-up) Rename has_debarring_overdues to has_restricting_overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153811|0 |1 is obsolete| | --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156399&action=edit Bug 29145: (QA follow-up) Use objects instead of straight SQL queries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153812|0 |1 is obsolete| | --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156400&action=edit Bug 29145: (QA follow-up) Remove debugging line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153813|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156401&action=edit Bug 29145: Replace GetDebarments in unit tests GetDebarments was removed and replaced by $patron->restrictions. The tests needed some adjustments to reflect that change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153814|0 |1 is obsolete| | --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156402&action=edit Bug 29145: Perltidy files and added code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156403&action=edit Bug 29145: (QA follow-up) Fix tests removing 'unblessed' This fixes issues with the tests caused by: Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156404&action=edit Bug 29145: (QA follow-up) Add +x to atomicupdate file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Conflict was only in the test file, caused by bug 32496. Tests pass now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #77 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Mike Barrette <mbarrette@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbarrette@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/909 Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41123 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41123 [Bug 41123] Remove useless dbh statement from Patron -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org