[Bug 35635] New: Expand Patron attribute type mandatory field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Bug ID: 35635 Summary: Expand Patron attribute type mandatory field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Within Patron attribute types there is a checkbox to make the attribute mandatory. Some libraries need to be able to make patron attribute types mandatory on the OPAC but not the staff interface, or vise versa. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167500&action=edit Bug 35635: DB Updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167501&action=edit Bug 35635: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167502&action=edit Bug 35635: Split mandatory field into mandatory and opac_mandatory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167546&action=edit Bug 35635: Add opac_mandatory to patron attribute table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167546|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167548&action=edit Bug 35635: Add opac_mandatory to patron attribute table To test: 1. Before applying the patch go to Adminstration > Patron attribute types 2. Create or modify some attributes to be mandatory and some to not be mandatory. 3. APPLY PATCH, updatedatabase, restart_all 4. Go back to Adminstration > Patron attribute types. The patron attributes that were made mandatory should now also have the opac_mandatory field checked. 5. Make sure that you can change the correctly save the new "OPAC mandatory:" field. 6. If the 'Display in OPAC:' field is unchecked the 'OPAC mandatory:' checkbox should be disabled. 7. Mark some patron attributes as 'OPAC mandatory:'. 8. Go to the OPAC self reg page, the field should be required. 9. BAck on Adminstration > Patron attribute types check some attributes as 'OPAC mandatory:' and 'Editable in OPAC:'. 10. As a logged in OPAC user go to "Personal details" and make sure the attribute is required. 11. For the same attriubute as step 9-10 , mark as NOT 'Editable in OPAC:'. Make sure you can still save the form on the OPAC "Personal details" page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167500|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 167643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167643&action=edit Bug 35635: DB Updates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167501|0 |1 is obsolete| | --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 167644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167644&action=edit Bug 35635: DO NOT PUSH - Schema updates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167502|0 |1 is obsolete| | --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 167645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167645&action=edit Bug 35635: Split mandatory field into mandatory and opac_mandatory Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167548|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 167646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167646&action=edit Bug 35635: Add opac_mandatory to patron attribute table To test: 1. Before applying the patch go to Adminstration > Patron attribute types 2. Create or modify some attributes to be mandatory and some to not be mandatory. 3. APPLY PATCH, updatedatabase, restart_all 4. Go back to Adminstration > Patron attribute types. The patron attributes that were made mandatory should now also have the opac_mandatory field checked. 5. Make sure that you can change the correctly save the new "OPAC mandatory:" field. 6. If the 'Display in OPAC:' field is unchecked the 'OPAC mandatory:' checkbox should be disabled. 7. Mark some patron attributes as 'OPAC mandatory:'. 8. Go to the OPAC self reg page, the field should be required. 9. BAck on Adminstration > Patron attribute types check some attributes as 'OPAC mandatory:' and 'Editable in OPAC:'. 10. As a logged in OPAC user go to "Personal details" and make sure the attribute is required. 11. For the same attriubute as step 9-10 , mark as NOT 'Editable in OPAC:'. Make sure you can still save the form on the OPAC "Personal details" page. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Testing notes: Everything worked according to the test plan, but one small clarification for steps #7 and 8 is that for the attributes to be on the self reg page I also had to check 'Editable in OPAC' for the attribute to appear on the self reg page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 174962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174962&action=edit Bug 35635: (QA follow-up): fix terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 167646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167646 Bug 35635: Add opac_mandatory to patron attribute table Review of attachment 167646: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35635&attachment=167646) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt @@ +333,3 @@
<th>Library limitation</th> <th>Authorized value category</th> <th>Mandatory</th>
Looks like this should be changed to say it's about the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |victor@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- db rev isn't updating the COMMENT for the "mandatory" column when in the kohastructure, it is changed. That comment ends up in Koha/Schema/Result so depending if the RM and RMaint runs dbic after a doing a databaseupdate or starting KTD they will end up with different POD in the schema files and a different checksum. Which will raise a warning latter for them or someone else. So even COMMENTs need to be in sync between a clean install and an upgraded install. About clean install vs upgraded install the column opac_mandatory has a divergence on it's COMMENT too: "on the OPAC" vs "in the OPAC" And "NOT NULL" is only present on of the two scenarios. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
and a different checksum. Which will raise a warning latter for them or someone else.
The checksum check won't trip actually. It's ok in this scenario. There will still be unexpected schema class changes when running dbic later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175059&action=edit Bug 35635: (follow-up) Fix DBRev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174962|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 175635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175635&action=edit Bug 35635: (QA follow-up): fix terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks for the follow-up. Sorry there is still this remaining:
And "NOT NULL" is only present on one of the two scenarios.
And comment 12 but it was confusing: <th>Mandatory - OPAC</th> was added. But just above there is <th>Mandatory</th> Which looks like it should be changed to say it's about the staff interface. To avoid confusion which in the worst case could raise doubts about "Mandatory" being about both staff interface and OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Follow-up updated for another terminology issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175858&action=edit Bug 35635: (follow-up): Mark madatory field as staff interface/OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. You need that in Koha/Schema/Result/BorrowerAttributeType.pm '+mandatory' => { is_boolean => 1 }, + '+opac_mandatory' => { is_boolean => 1 }, The QA script caught it 2. It does not work at all, if mandatory staff-side but not opac-side, opac-memberentry displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167643|0 |1 is obsolete| | Attachment #167644|0 |1 is obsolete| | Attachment #167645|0 |1 is obsolete| | Attachment #167646|0 |1 is obsolete| | Attachment #175059|0 |1 is obsolete| | Attachment #175635|0 |1 is obsolete| | Attachment #175858|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176595&action=edit Bug 35635: DB Updates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176596&action=edit Bug 35635: DO NOT PUSH - Schema updates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176597&action=edit Bug 35635: Split mandatory field into mandatory and opac_mandatory Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176598&action=edit Bug 35635: Add opac_mandatory to patron attribute table To test: 1. Before applying the patch go to Adminstration > Patron attribute types 2. Create or modify some attributes to be mandatory and some to not be mandatory. 3. APPLY PATCH, updatedatabase, restart_all 4. Go back to Adminstration > Patron attribute types. The patron attributes that were made mandatory should now also have the opac_mandatory field checked. 5. Make sure that you can change the correctly save the new "OPAC mandatory:" field. 6. If the 'Display in OPAC:' field is unchecked the 'OPAC mandatory:' checkbox should be disabled. 7. Mark some patron attributes as 'OPAC mandatory:'. 8. Go to the OPAC self reg page, the field should be required. 9. BAck on Adminstration > Patron attribute types check some attributes as 'OPAC mandatory:' and 'Editable in OPAC:'. 10. As a logged in OPAC user go to "Personal details" and make sure the attribute is required. 11. For the same attriubute as step 9-10 , mark as NOT 'Editable in OPAC:'. Make sure you can still save the form on the OPAC "Personal details" page. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176599&action=edit Bug 35635: (follow-up) Fix DBRev Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176600&action=edit Bug 35635: (QA follow-up): fix terminology Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176601&action=edit Bug 35635: (follow-up): Mark madatory field as staff interface/OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176602&action=edit Bug 35635: Flag opac_mandatory as boolean Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176603&action=edit Bug 35635: Fix server-side check Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176604&action=edit Bug 35635: Adjust atomic update So that we don't do anything if the new column exists already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement expands release notes| |the patron attribute type | |"Mandatory" field, allowing | |for different | |configurations for the OPAC | |and the staff client. QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement expands |This enhancement expands release notes|the patron attribute type |the patron attribute type |"Mandatory" field, allowing |"Mandatory" field, allowing |for different |for different |configurations for the OPAC |configurations for the OPAC |and the staff client. |and the staff interface. Summary|Expand Patron attribute |Expand patron attribute |type mandatory field |type mandatory field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176595|0 |1 is obsolete| | --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177803&action=edit Bug 35635: DB Updates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176596|0 |1 is obsolete| | --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177804&action=edit Bug 35635: DO NOT PUSH - Schema updates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176597|0 |1 is obsolete| | --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177805&action=edit Bug 35635: Split mandatory field into mandatory and opac_mandatory Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176598|0 |1 is obsolete| | --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177806&action=edit Bug 35635: Add opac_mandatory to patron attribute table To test: 1. Before applying the patch go to Adminstration > Patron attribute types 2. Create or modify some attributes to be mandatory and some to not be mandatory. 3. APPLY PATCH, updatedatabase, restart_all 4. Go back to Adminstration > Patron attribute types. The patron attributes that were made mandatory should now also have the opac_mandatory field checked. 5. Make sure that you can change the correctly save the new "OPAC mandatory:" field. 6. If the 'Display in OPAC:' field is unchecked the 'OPAC mandatory:' checkbox should be disabled. 7. Mark some patron attributes as 'OPAC mandatory:'. 8. Go to the OPAC self reg page, the field should be required. 9. BAck on Adminstration > Patron attribute types check some attributes as 'OPAC mandatory:' and 'Editable in OPAC:'. 10. As a logged in OPAC user go to "Personal details" and make sure the attribute is required. 11. For the same attriubute as step 9-10 , mark as NOT 'Editable in OPAC:'. Make sure you can still save the form on the OPAC "Personal details" page. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176599|0 |1 is obsolete| | --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177807&action=edit Bug 35635: (follow-up) Fix DBRev Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176600|0 |1 is obsolete| | --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177808&action=edit Bug 35635: (QA follow-up): fix terminology Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176601|0 |1 is obsolete| | --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177809&action=edit Bug 35635: (follow-up): Mark madatory field as staff interface/OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176602|0 |1 is obsolete| | --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177810&action=edit Bug 35635: Flag opac_mandatory as boolean Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176603|0 |1 is obsolete| | --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177811&action=edit Bug 35635: Fix server-side check Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176604|0 |1 is obsolete| | --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177812&action=edit Bug 35635: Adjust atomic update So that we don't do anything if the new column exists already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177803|0 |1 is obsolete| | --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177814&action=edit Bug 35635: DB Updates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177805|0 |1 is obsolete| | --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177815&action=edit Bug 35635: Split mandatory field into mandatory and opac_mandatory Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177806|0 |1 is obsolete| | --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177816&action=edit Bug 35635: Add opac_mandatory to patron attribute table To test: 1. Before applying the patch go to Adminstration > Patron attribute types 2. Create or modify some attributes to be mandatory and some to not be mandatory. 3. APPLY PATCH, updatedatabase, restart_all 4. Go back to Adminstration > Patron attribute types. The patron attributes that were made mandatory should now also have the opac_mandatory field checked. 5. Make sure that you can change the correctly save the new "OPAC mandatory:" field. 6. If the 'Display in OPAC:' field is unchecked the 'OPAC mandatory:' checkbox should be disabled. 7. Mark some patron attributes as 'OPAC mandatory:'. 8. Go to the OPAC self reg page, the field should be required. 9. BAck on Adminstration > Patron attribute types check some attributes as 'OPAC mandatory:' and 'Editable in OPAC:'. 10. As a logged in OPAC user go to "Personal details" and make sure the attribute is required. 11. For the same attriubute as step 9-10 , mark as NOT 'Editable in OPAC:'. Make sure you can still save the form on the OPAC "Personal details" page. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177807|0 |1 is obsolete| | --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177817&action=edit Bug 35635: (follow-up) Fix DBRev Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177808|0 |1 is obsolete| | --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177818&action=edit Bug 35635: (QA follow-up): fix terminology Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177809|0 |1 is obsolete| | --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177819&action=edit Bug 35635: (follow-up): Mark madatory field as staff interface/OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177810|0 |1 is obsolete| | --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177820&action=edit Bug 35635: Flag opac_mandatory as boolean Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177811|0 |1 is obsolete| | --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177821&action=edit Bug 35635: Fix server-side check Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177812|0 |1 is obsolete| | --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177822&action=edit Bug 35635: Adjust atomic update So that we don't do anything if the new column exists already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177804|0 |1 is obsolete| | --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177823&action=edit Bug 35635: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expand patron attribute |Expand patron attribute |type mandatory field |type mandatory field to | |allow different settings | |for OPAC and staff | |interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 --- Comment #52 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179165&action=edit Bug 35635: Add missing NOT NULL clause in db rev Jenkins job testing the update DB was failing: 18:11:48 koha_1 | +++ b/Koha/Schema/Result/BorrowerAttributeType.pm 18:11:48 koha_1 | @@ -141,7 +141,7 @@ defines if this field is copied to anonymized_borrower_attributes (1 for yes, 0 18:11:48 koha_1 | 18:11:48 koha_1 | data_type: 'tinyint' 18:11:48 koha_1 | default_value: 0 18:11:48 koha_1 | - is_nullable: 0 18:11:48 koha_1 | + is_nullable: 1 18:11:48 koha_1 | 18:11:48 koha_1 | defines if the attribute is mandatory or not in the staff interface 18:11:48 koha_1 | 18:11:48 koha_1 | @@ -149,7 +149,7 @@ defines if the attribute is mandatory or not in the staff interface 18:11:48 koha_1 | 18:11:48 koha_1 | data_type: 'tinyint' 18:11:48 koha_1 | default_value: 0 18:11:48 koha_1 | - is_nullable: 0 18:11:48 koha_1 | + is_nullable: 1 18:11:48 koha_1 | 18:11:48 koha_1 | defines if the attribute is mandatory or not in the OPAC 18:11:48 koha_1 | 18:11:48 koha_1 | @@ -185,9 +185,9 @@ __PACKAGE__->add_columns( 18:11:48 koha_1 | "keep_for_pseudonymization", 18:11:48 koha_1 | { data_type => "tinyint", default_value => 0, is_nullable => 0 }, 18:11:48 koha_1 | "mandatory", 18:11:48 koha_1 | - { data_type => "tinyint", default_value => 0, is_nullable => 0 }, 18:11:48 koha_1 | + { data_type => "tinyint", default_value => 0, is_nullable => 1 }, 18:11:48 koha_1 | "opac_mandatory", 18:11:48 koha_1 | - { data_type => "tinyint", default_value => 0, is_nullable => 0 }, 18:11:49 koha_1 | + { data_type => "tinyint", default_value => 0, is_nullable => 1 }, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40219 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #54 from Christopher Brannon <cbrannon@cdalibrary.org> --- I'm not sure this accomplishes everything. Yes, it is great that now we can distinguish what is mandatory for the patron or the staff to fill in - if the patron is using the OPAC. However, with the use of systems like Aspen, self registration is mocked up via API - which behaves like staff. There will be times we want API to behave like the staff interface - and there are times we want API to behave like the OPAC. API does not respect that aspect. Unless there is some switch in the API URL or commands to indicate which way to behave, things like self registration through API is going to behave like staff and require patron attributes that should not be required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40220 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40506 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #55 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35635 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41067 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41067 [Bug 41067] 'OPAC mandatory' attribute setting requires 'Editable in OPAC' to work -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org