[Bug 16529] New: Clean up and improve upload template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Bug ID: 16529 Summary: Clean up and improve upload template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/upload.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The file upload template has a few issues to be fixed: - use of 'onclick' should be corrected - markup errors should be fixed - layout should be adjusted based on whether the page is displaying in a popup or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51539&action=edit Bug 16529 - Clean up and improve upload template This patch makes some fixes and improvements to the template for Tools -> Upload, including markup corrections, removal of 'onclick,' and conversion of some links to styled buttons. To test, apply the patch and go to Tools -> Upload. - Confirm that uploading a file works correctly. - Confirm that clicking 'Cancel' during a file upload works correctly. - Search existing uploads. - Confirm that the 'Download' and 'Delete' buttons look correct and work correctly. - In Administration -> MARC bibliographic framework, choose a framework and configure a tag subfield to use the upload plugin. - Create or edit a bibliographic record using the framework you modified. - Click the tag editor icon next to your modified subfield to trigger the pop-up window with the upload form. - Confirm that this window has a layout which is adjusted for the size of the window. - Confirm that uploading and selecting files from this window works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 [Bug 16538] Improve the style of progress bars -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Owen Leonard from comment #1)
- Confirm that this window has a layout which is adjusted for the size of the window.
What 'adjusted' means? Fieldset's width is fixed, always centered. If that's Ok I'll sign Comment: 'Close' button on page bottom looks different from the others: rounded corners and bold font. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Rocio Dressler <rocio@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Rocio Dressler <rocio@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51539|0 |1 is obsolete| | --- Comment #3 from Rocio Dressler <rocio@bywatersolutions.com> --- Created attachment 52002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52002&action=edit Bug 16529 - Clean up and improve upload template This patch makes some fixes and improvements to the template for Tools -> Upload, including markup corrections, removal of 'onclick,' and conversion of some links to styled buttons. To test, apply the patch and go to Tools -> Upload. - Confirm that uploading a file works correctly. - Confirm that clicking 'Cancel' during a file upload works correctly. - Search existing uploads. - Confirm that the 'Download' and 'Delete' buttons look correct and work correctly. - In Administration -> MARC bibliographic framework, choose a framework and configure a tag subfield to use the upload plugin. - Create or edit a bibliographic record using the framework you modified. - Click the tag editor icon next to your modified subfield to trigger the pop-up window with the upload form. - Confirm that this window has a layout which is adjusted for the size of the window. - Confirm that uploading and selecting files from this window works correctly. Signed-off-by: Rocio Dressler <rocio@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this one now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52002|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 52011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52011&action=edit Bug 16529 - Clean up and improve upload template This patch makes some fixes and improvements to the template for Tools -> Upload, including markup corrections, removal of 'onclick,' and conversion of some links to styled buttons. To test, apply the patch and go to Tools -> Upload. - Confirm that uploading a file works correctly. - Confirm that clicking 'Cancel' during a file upload works correctly. - Search existing uploads. - Confirm that the 'Download' and 'Delete' buttons look correct and work correctly. - In Administration -> MARC bibliographic framework, choose a framework and configure a tag subfield to use the upload plugin. - Create or edit a bibliographic record using the framework you modified. - Click the tag editor icon next to your modified subfield to trigger the pop-up window with the upload form. - Confirm that this window has a layout which is adjusted for the size of the window. - Confirm that uploading and selecting files from this window works correctly. Signed-off-by: Rocio Dressler <rocio@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14686 CC| |julian.maurice@biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 [Bug 14686] New menu option and permission for file uploading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 Bug 16529 depends on bug 14686, which changed state. Bug 14686 Summary: New menu option and permission for file uploading https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org