[Bug 17663] New: Forgotten userpermissions from bug 14686
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Bug ID: 17663 Summary: Forgotten userpermissions from bug 14686 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57662&action=edit Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [2] Check if you see Tools/Upload (with sufficient perms). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14686 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57662|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 57664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57664&action=edit [SIGNED OFF] Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [2] Check if you see Tools/Upload (with sufficient perms). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #2)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Great!
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57664|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57675&action=edit Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [3] Check if you see Tools/Upload (with sufficient perms). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57675|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57676&action=edit Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [3] Check if you see Tools/Upload (with sufficient perms). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57676|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57677&action=edit Bug 17663: Forgotten userpermissions from bug 14686 Bug 14686 added in a dbrev: (13, 'upload_general_files', 'Upload any file'), (13, 'upload_manage', 'Manage uploaded files'); But these were not added in userpermissions.sql somehow :) So, what now? This patch: [1] adds them to userpermissions.sql as should have been done, [2] adds a dbrev to add them for newer installs that did not run the 14686 dbrev. Test plan: [1] Run this sql statement: DELETE FROM permissions WHERE code = 'upload_general_files' OR code = 'upload_manage' [2] Run the db rev. [3] Check if you see Tools/Upload (with sufficient perms). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Has been pushed by Kyle on November 21, 2016. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14294 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, will be in 16.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17663 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org