https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 --- Comment #1 from didier <didier.gautheron@biblibre.com> --- Created attachment 99695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99695&action=edit BUG 24740: Use biblio title rather than biblio number in OPAC search result cover images tooltips In OPAC biblionum doesn't mean much to patrons, use biblio title field if not empty. Test plan: OPAC search 1) Apply the patch 2) For each cover images providers available to tester in: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=Cover OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets, Coce provider. 3) Enable the provider. 4) Search a Library Catalog for a book with a cover image. 6) test mouse over cover image display biblio title. OPAC Shelves 1) Enable OPAC virtualshelves preference 2) Create a list. 3) For each covers providers available. 4) Search the List 5) test mouse over cover image display biblio title. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr Status|Needs Signoff |In Discussion --- Comment #2 from Andreas Roussos <a.roussos@dataly.gr> --- Indeed, the biblio number doesn't mean much when used as a cover tooltip. I'm keen to Sign Off on your patch and have the following points to make: 1) "Author: Didier GAutheron" <- unless you want to be credited this way in the Koha release notes and in the About page timeline you may want to redo your git config and make a small change to your surname. 2) "BUG 24740: [...]": as per the official guidelines in the Koha wiki (https://wiki.koha-community.org/wiki/Commit_messages#Subject_line) the word "Bug" should be capitalised, and not be in all uppercase, otherwise the QA tools will complain. 3) The QA tools will also flag the missing filters at the lines where you've added [% img_title %], this is due to the coding guidelines' requirement that _all_ template variables must be filtered: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_Filter_all_tem... You should probably remove the filters from the assignments inside the IF-ELSE blocks and use the "html" filter whenever the img_title variable is used later on in the TT code: [% IF ( SEARCH_RESULT.title ) %] [% img_title = SEARCH_RESULT.title %] [% ELSE %] [% img_title = SEARCH_RESULT.biblionumber %] [% END %] [% IF ( itemsloo.title ) %] [% img_title = itemsloo.title %] [% ELSE %] [% img_title = itemsloo.biblionumber %] [% END %] <span title="[% img_title | html %]" ... ></span> 4) You have used hard tabs to indent some of the code in your patch, the QA tools will notice this. I suggest you change them to soft tabs (spaces). The offending lines are: 254 and 256 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt 327 and 329 in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt 5) Should we take this opportunity and fix the cover tooltip in the biblio details page as well? And the shelf browser, too? The relevant TT files are: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc -- You are receiving this mail because: You are watching all bug changes.

Hi Andreas, please use "Failed QA" if you run into problems when testing - the developers will usually check and reply. In Discussion should be used only if there is a disagreement that cannot be resolved without getting more people involved. Hi Katrin, thanks for the clarification! I've taken the opportunity to include

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 --- Comment #4 from Andreas Roussos <a.roussos@dataly.gr> --- (In reply to Katrin Fischer from comment #3) the gist of your comment in the relevant page on the Wiki: https://wiki.koha-community.org/wiki/Development_workflow#Failure_cases -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |didier.gautheron@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 --- Comment #7 from didier <didier.gautheron@biblibre.com> --- Created attachment 102096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102096&action=edit Bug 24740: Use biblio title rather than biblio number in OPAC search result cover images tooltips In OPAC biblionum doesn't mean much to patrons, use biblio title field if not empty. Test plan: OPAC search 1) Apply the patch 2) For each cover images providers available to tester in: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=Cover OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets, Coce provider. 3) Enable the provider. 4) Search a Library Catalog for a book with a cover image. 6) test mouse over cover image display biblio title. OPAC Shelves 1) Enable OPAC virtualshelves preference 2) Create a list. 3) For each covers providers available. 4) Search the List 5) test mouse over cover image display biblio title. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin@ub.lu.se Status|Needs Signoff |Signed Off --- Comment #9 from Stina Hallin <stina.hallin@ub.lu.se> --- Worked fine with books. Didn't get either title or biblionumber for e-books and films. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 --- Comment #11 from Stina Hallin <stina.hallin@ub.lu.se> --- Hi, yes I'm using Bywaters sandbox. I used it with my library's account with syndetics to display covers. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 --- Comment #13 from Stina Hallin <stina.hallin@ub.lu.se> --- When I test it again, I can see the titles for different kinds of materials. So now it looks great. Everything I looked at showed tips. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.