https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104090&action=edit Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104090|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 104130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104130&action=edit Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104130|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104136&action=edit Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.