http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24747|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 24747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24747 Bug 11619: Duplicate key in QueryParser config Still yaml warnings.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I saw some 'suspect' lines around author too. But I do not seem to get rid of the YAML warnings from koha-qa.pl I am leaving this to the experts for now :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #4)

I saw some 'suspect' lines around author too. But I do not seem to get rid of the YAML warnings from koha-qa.pl I am leaving this to the experts for now :)

I think your first patch is right. The warning from koha-qa is normal. The tests are done before the patch AND after the patch. The warnings only appears 1 time, so before applying the patch. After the patch, it does not appear anymore. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- This test plan is nonsense ('stupid') by the way :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24746|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24752&action=edit Bug 11619: Duplicate key in QueryParser config Corrects a double entry for language in yaml file. Language should have been language-original. Test plan: Copy changes in yaml file to your zebra folder. Reindex, or change a few records and update zebra. Search something with index language-original. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619

--- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #9)
> I have problems in getting the search to work:
> 
> Tested with MARC21:
> - Applied patch and copied file
> - Cataloged record Language-original = 041$h
> - Activated QueryParser
> - Waited for Zebra to reindex my newly added record
> - Searched for the unique content of 041$h as keyword search
>   > Record was found
> - Searched for language-original:<041$h>
>   > Record was not found
> 
> I have no success in using the index explicitly.

Thanks for testing, Katrin.
I have to admit that my test plan should be reworded (see comment 7). Will do
that in a minute. Sorry for any confusion about that..
Note that this report is about fixing the QueryParser config and it is not
about searching on language-original. As long as this specific index is not in
the field set of C4::Search::getIndexes, you will have no results (without
QueryParser). But that is true for many more indexes in record.abs. Just
mentioning a few indexes with the same behavior from the first few control
fields: Microform-generation, Identifier-standard, BNB-card-number, BGF-number,
Number-db, Number-natl-biblio, etc.
So I feel that since this fixes QP, it should not be a reason to fail this
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24752|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24996&action=edit Bug 11619: Duplicate key in QueryParser config Corrects a double entry for language in yaml file. Language should have been language-original. Test plan: Check that you have language-original in your zebra install. Specifically, this index should cover MARC21 041$h. Enable QueryParser and search for a record with this index. Note that this patch does not enable searching on this index without QueryParser. This is true for many more indexes in record.abs that are not included in the getIndexes routine. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #12)

Hi Jonathan, I understand that we have to list the index in Search.pm when not using the QueryParser. But now I am more confused as to why it didn't work in my test?

Katrin, I retested. If I enable QP and search on the index, I find the record with the search term in 041$h. If I disable QP, I do not find it. So please retest. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #14)

Can you add the search term/query you used?

I just simply added dut in 041$h and search for language-original: dut -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #16)

Hm weird, I will retest. Jonathan, did you make any changes to the new patch?

No, I always mention when I amend a patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It still doesn't work in my test installation: - Checked that the file was copied correctly - Checked my koha-conf.xml for the QueryParser line. <queryparser_config>/home/katrin/koha-dev/etc/searchengine/queryparser.yaml</queryparser_config> - Checked QueryParser is activated. - Keyword search finds my 041$h result. - language-original:dedede doesn't. - Changed the record to have 'dut' instead. - Reindexed with -z - Keyword search finds dut. - language-original:dut gives no result. - No errors in my koha-opac-error_log. Marcel, does the space make a difference for you? language-original: dut vs. language-original:dut? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #20)

*sigh* outdated index configuration... works alright now :)

Thanks for your perseverance :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11619 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10544 | --- Comment #24 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Galen Charlton from comment #23)

Pushed to master, along with a follow-up fixing a test case that the main patch broke.

Thanks, Galen. I remove the non-mandatory dependency for 10544. It can also be applied on top of this.. -- You are receiving this mail because: You are watching all bug changes.