[Bug 6273] New: SIP2 Fee Paid and Fee Paid Response support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Bug #: 6273 Summary: SIP2 Fee Paid and Fee Paid Response support Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: SIP2 AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org Depends on: 5605 Enable Koha to accept, process and respond to SIP2 'Fee Paid' messages, as per the SIP2 protocol specification defined by 3M. See osdir.com/ml/attachments/pdfLa2ukLu5d7.pdf for full details. Processing 'Fee Paid' messages Koha shall parse the 'Fee Paid' message to extract the following mandatory information: • Transaction date • Fee type • Payment type • Currency • Amount • Institution ID • Patron identifier (barcode) Koha shall also be able to parse the following optional information: • terminal password • patron password • fee identifier (the ID of the fine to which the payment is applied) • Transaction ID (as assigned by the SIP client) Once the message is parsed, a payment line shall be added to Koha's accountlines table. This line shall include the borrowernumber, amount (as a negative), the transaction date, the payment type, and the account against which the payment is made. A note shall also be made to indicate that the payment was made from SIP client, rather than through the Koha staff client. Payments shall be accepted if the borrowernumber and account against which the payment is made are both valid. Otherwise, the payment shall not be accepted, and return an error message (see next section). Responding to 'Fee Paid' messages The Screen Message attribute of the 'Fee Paid Response' Message shall be used to display the details of any error that prevented the payment from being accepted. If the payment is accepted, this attribute shall contain a friendly “thank you for your payment” message. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-02 15:57:37 UTC --- Created attachment 6539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6539 SIP2 Fee Paid Pay Type support Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Lori Ayre <loriayre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |loriayre@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Bug 6273 depends on bug 5605, which changed state. Bug 5605 Summary: Add Support for SIP Fee Paid Message http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5605 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6539|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11476&action=edit Bug 6273: Add support for recording SIP2 Fee Paid Payment Type Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- I had to rebase and fix a conflict, not sure I got it right. So I would like someone else to sign off please. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Medium patch Version|3.6 |master --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Resetting version to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- The rebased patch no longer applies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11476|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22834&action=edit Bug 6273: Add support for recording SIP2 Fee Paid Payment Type Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #7 from Deichman Digital Development <digitalutvikling@gmail.com> --- Created attachment 24889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24889&action=edit Rebased against master 2014-01-30 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #8 from Deichman Digital Development <digitalutvikling@gmail.com> --- Created attachment 24890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24890&action=edit Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Rebased against master 2014-01-30 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@kul.oslo.k | |ommune.no --- Comment #9 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- FYI, this was tested using SIP2 through telnet. 1. sent SIP2 Fee paid command after successful login:
3720140130 0900010401NOKBV333.33|AOFilleinstitusjon|AA1003|BKbbs001|
got successful SIP2 response: << 38Y20140130 154751AOFilleinstitusjon|AA1003|BKbbs001| 2. checked patron info in koha admin. Payment was added, with Payment, thanks msg. 3. Printed slip, where payment showed ok. Benjamin Rokseth (In reply to Deichman Digital Development from comment #8)
Created attachment 24890 [details] [review] Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Rebased against master 2014-01-30
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Thanks for signing off Benjamin A few things though Please mark the bug signed off when you are done Please obsolete the old patches and In the rebase the original commit message has been killed, can we get that back? So amend the signed off patch, add back the original commit message, attach it, and obsolete all the others. And finally switch to signed off. Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Deichman Digital Development <digitalutvikling@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22834|0 |1 is obsolete| | Attachment #24889|0 |1 is obsolete| | Attachment #24890|0 |1 is obsolete| | --- Comment #11 from Deichman Digital Development <digitalutvikling@gmail.com> --- Created attachment 24935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24935&action=edit Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Benjamin: Please adjust subject line and add your signoff at the end of the commit message. Examples enough on another report :) You are almost there. Hang on.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24935|0 |1 is obsolete| | --- Comment #13 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 25167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25167&action=edit Bug 6273 - SIP2 Fee Paid and Fee Paid Response support Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected http://bugs.koha-community.org/show_bug.cgi?id=6273 Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Benjamin Rokseth from comment #13)
Created attachment 25167 [details] [review] Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Thanks, Benjamin. Please update the status to Signed off again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #15 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Benjamin Rokseth from comment #13)
The payment descriptin is also appended with " (via SIP2)" if this is present.
That should be made translatable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- All the SIP messages are currently in English and untranslatable. I think this is something for a more general bug and should not be a blocker here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #17 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Katrin Fischer from comment #16)
All the SIP messages are currently in English and untranslatable. I think this is something for a more general bug and should not be a blocker here.
Except this is added to the payment description, it's not a SIP message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, thx for clarifying. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25167|0 |1 is obsolete| | --- Comment #19 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 26463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26463&action=edit [passed-qa] Bug 6273 - SIP2 Fee Paid and Fee Paid Response support Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected http://bugs.koha-community.org/show_bug.cgi?id=6273 Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #20 from Brendan Gallagher <brendan@bywatersolutions.com> --- Two notes 1) The string that is present in this patch has been addressed with bug 2546 - So I leave it up to the RM to decided about removing the 2 lines that have "Payment, Thanks" + "(via SIP)"... 2) I would like to see some message that does include a (via SIP) in a translatable string and perhaps we can create that as a another bug once this has been pushed. Otherwise this works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that fixes various issues preventing the payment type from being recording correctly and avoiding a regression on bug 2546. Thanks, Ian! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org