https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Christopher Brannon from comment #0)

change cancel links to buttons.

"Cancel" is a link throughout the staff client. I think the only place where there is inconsistency is some modals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Christopher Brannon from comment #2)

Is there a reason we want to keep these links?

The intention is to make the "cancel" option less visible. The primary action is always going to be "Submit," and having a cancel link makes it very clear which is which. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Withdrawing this patch because it's missing columns settings configuration. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82851&action=edit Bug 21918: Update buttons on fines to match newer buttons This patch makes a number of changes to the "Pay fines" template, the goal of which is to make the interface look better in general. Changes include: - Styling the "Pay" and "Write off" buttons as Bootstrap buttons. - Adding DataTables sorting, searching, and filtering. - Adding a column showing the fine date. - Hide the "Add note" input, add a link to show it. - Add some missing "preventDefault" methods from events. - Add "Writeoff selected" to the buttons which are disabled when there is no checkbox selection. - The <tfoot> tag is now expected by the HTML validator to be after <tbody>, so this section has been moved to suppress validator errors. To test, apply the patch and locate a patron who has multiple outstanding fines. - Go to Fines -> Pay fines - Confirm that the table of fines is shown as a DataTable, with sorting on columns which have data. - Test columns settings in Administration -> Columns settings. - Confirm that fine dates are shown, and that sorting by this column works correctly. - Click an "Add note" link to show a note input field. Focus should be in the newly-displayed input. - Confirm that notes are still saved correctly when paying or writing off single or multiple fines. - Confirm that when the "add note" input is hidden, its contents are erased. - Uncheck all checkboxes by clicking the "Clear all" link at the top. The "Pay selected" and "Write off selected" buttons should become disabled. - Checking any checkbox should re-enable those buttons. - Test that the relocated "Apply" button (for outstanding credits) still works as expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hickeyhe@wgc.school.nz --- Comment #9 from helene <hickeyhe@wgc.school.nz> --- This is really good, but the column settings in administration are not having any effect. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82851|0 |1 is obsolete| | Attachment #84155|0 |1 is obsolete| | --- Comment #12 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 84213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84213&action=edit Bug 21918: Update buttons on fines to match newer buttons This patch makes a number of changes to the "Pay fines" template, the goal of which is to make the interface look better in general. Changes include: - Styling the "Pay" and "Write off" buttons as Bootstrap buttons. - Adding DataTables sorting, searching, and filtering. - Adding a column showing the fine date. - Hide the "Add note" input, add a link to show it. - Add some missing "preventDefault" methods from events. - Add "Writeoff selected" to the buttons which are disabled when there is no checkbox selection. - The <tfoot> tag is now expected by the HTML validator to be after <tbody>, so this section has been moved to suppress validator errors. To test, apply the patch and locate a patron who has multiple outstanding fines. - Go to Fines -> Pay fines - Confirm that the table of fines is shown as a DataTable, with sorting on columns which have data. - Test columns settings in Administration -> Columns settings. - Confirm that fine dates are shown, and that sorting by this column works correctly. - Click an "Add note" link to show a note input field. Focus should be in the newly-displayed input. - Confirm that notes are still saved correctly when paying or writing off single or multiple fines. - Confirm that when the "add note" input is hidden, its contents are erased. - Uncheck all checkboxes by clicking the "Clear all" link at the top. The "Pay selected" and "Write off selected" buttons should become disabled. - Checking any checkbox should re-enable those buttons. - Test that the relocated "Apply" button (for outstanding credits) still works as expected. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84213|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84248&action=edit Bug 21918: Update buttons on fines to match newer buttons This patch makes a number of changes to the "Pay fines" template, the goal of which is to make the interface look better in general. Changes include: - Styling the "Pay" and "Write off" buttons as Bootstrap buttons. - Adding DataTables sorting, searching, and filtering. - Adding a column showing the fine date. - Hide the "Add note" input, add a link to show it. - Add some missing "preventDefault" methods from events. - Add "Writeoff selected" to the buttons which are disabled when there is no checkbox selection. - The <tfoot> tag is now expected by the HTML validator to be after <tbody>, so this section has been moved to suppress validator errors. To test, apply the patch and locate a patron who has multiple outstanding fines. - Go to Fines -> Pay fines - Confirm that the table of fines is shown as a DataTable, with sorting on columns which have data. - Test columns settings in Administration -> Columns settings. - Confirm that fine dates are shown, and that sorting by this column works correctly. - Click an "Add note" link to show a note input field. Focus should be in the newly-displayed input. - Confirm that notes are still saved correctly when paying or writing off single or multiple fines. - Confirm that when the "add note" input is hidden, its contents are erased. - Uncheck all checkboxes by clicking the "Clear all" link at the top. The "Pay selected" and "Write off selected" buttons should become disabled. - Checking any checkbox should re-enable those buttons. - Test that the relocated "Apply" button (for outstanding credits) still works as expected. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #14)

Testing this I got confused about the payment note feature. I am wondering, do we need it to be on the payments table? It seems a little confusing as you seem to only be able to save it actually paying a fine. Wouldn't it be enough if the field appeared editable on the actual form? Maybe I am missing something!

I agree that this is a little wonky. It would also be helpful if notes could be updated or edited after the fact, but this is a topic for another ticket. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Aleihsa! Also thx Christopher for weighing in! (not just me :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21918 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.