https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41071 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188296&action=edit Bug 41071: Fix missing space in cash register classes It seems we dropped a space somewhere so the class for default registers had become: "{Branchcode}default" instead of "{Branchcode} default" This broke the JS for selecting To test: 1 - Enable UseCashRegisters system preference 2 - Create three registers for three different branches 3 - Make each register the default 4 - Click on username in top right 5 - Select 'Set library and cash register' 6 - Choose on of the three branches 7 - Note the dropdown does not populate with the default 8 - Note no registers can be selected 9 - Apply patch 10 - Reload the page 11 - Change libraries and verify all works as expected Current status: Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41071 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188296|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188297&action=edit Bug 41071: Fix missing space in cash register classes It seems we dropped a space somewhere so the class for default registers had become: "{Branchcode}default" instead of "{Branchcode} default" This broke the JS for selecting To test: 1 - Enable UseCashRegisters system preference 2 - Create three registers for three different branches 3 - Make each register the default 4 - Click on username in top right 5 - Select 'Set library and cash register' 6 - Choose on of the three branches 7 - Note the dropdown does not populate with the default 8 - Note no registers can be selected 9 - Apply patch 10 - Reload the page 11 - Change libraries and verify all works as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41071 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41071 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38664 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- There is one thing: if you go to the form and there is a default, it's not selected automatically. I guess it is not regression from bug 38664 and it was an existing bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41071 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188297|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188308&action=edit Bug 41071: Fix missing space in cash register classes It seems we dropped a space somewhere so the class for default registers had become: "{Branchcode}default" instead of "{Branchcode} default" This broke the JS for selecting To test: 1 - Enable UseCashRegisters system preference 2 - Create three registers for three different branches 3 - Make each register the default 4 - Click on username in top right 5 - Select 'Set library and cash register' 6 - Choose on of the three branches 7 - Note the dropdown does not populate with the default 8 - Note no registers can be selected 9 - Apply patch 10 - Reload the page 11 - Change libraries and verify all works as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41071 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41071 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41071 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38664 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.