[Bug 5981] New: OPAC: Add limits to search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Bug #: 5981 Summary: OPAC: Add limits to search history Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org Blocks: 5584 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-28 23:55:35 UTC --- Created attachment 3485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3485 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> 2011-04-05 10:00:16 UTC --- Created attachment 3657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3657 Followup - change Location to Shelving Location -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3657|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@enger.priv.no> 2011-04-05 10:03:15 UTC --- Comment on attachment 3657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3657 Followup - change Location to Shelving Location Attached the patch to the wrong bug, sorry! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Patch Status|Needs Signoff |Failed QA --- Comment #4 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-04-05 13:46:18 UTC --- Patch applies but I have: Missing right curly or square bracket at /home/koha/versions/koha_community/opac/opac-search.pl line 759, at end of line syntax error at /home/koha/versions/koha_community/opac/opac-search.pl line 759, at EOF Execution of /home/koha/versions/koha_community/opac/opac-search.pl aborted due to compilation errors. ~/cgi-bin/koha/opac-search.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3485|0 |1 is obsolete| | --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-01 16:17:43 UTC --- Created attachment 4798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4798 proposed patch for T::TT + fix for missing bracket The patch contained some duplicated lines, probably the result of a split/rebase Problem reported by Claire fixed by removing the 4 duplicated lines + patch updated for T::T -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-08-02 23:55:13 UTC --- Can someone provide an explanation of what this patch does and a test plan? What am I looking for when I apply this patch? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 07:53:36 UTC --- Nicole : before this patch, if you do an advanced search, with limits like branch/itemtype, it was not saved correctly in the search history, so if you re-do a search from there you won't get the same results. After this patch = it works correctly Updating severity, it's a bug not an ENH ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-08-03 16:11:09 UTC --- This patch should not have a number in the updatedatabse: +$DBversion = "3.05.00.005"; It should be +$DBversion = "3.05.00.XXX"; The RM is the one who chooses the next number. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4798|0 |1 is obsolete| | --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-05 10:05:24 UTC --- Created attachment 4860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4860 proposed patch (updated for Nicole comment about updatedatabase XXX) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Needs Signoff --- Comment #10 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-12 17:18:49 UTC --- The current iteration of the patch is not signed off... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2011-08-12 19:23:54 UTC --- Yes it was, I signed off on it as soon as Paul sent in the updated patch. http://lists.koha-community.org/pipermail/koha-patches/2011-August/015586.ht... Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #12 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-12 19:37:43 UTC --- Changes in C4/Auth.pm include references to system preferences that do not exist (TemplateEncoding, IntranetXSLTResultsDisplay and IntranetXSLTDetailsDisplay) and are not used anywhere else in the patch. Also defines a subroutine, enabled_opac_search_views, that is not used in the patch. There is also something in here about Tags, which appears to be outside the scope of this patch. Because of all this unnecessary inclusion, I'm marking this as Failed QA. Please strip this patch down to only deal with the issue presented in this bug report, and file separate bug reports and patches for separate issues. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-01 16:40:13 UTC --- I've checked the patches on biblibre/master (2), they are much smaller than this one. That should be a merge/split mistake, will submit a fixed version asap -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4860|0 |1 is obsolete| | --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-02 08:55:37 UTC --- Created attachment 5277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5277 proposed patch, rebased, with QA problems fixed This patch is smaller than the previous one because a lot of code had nothing to do in this patch. (some lines with a TAB have been changed to spaces) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-02 09:12:20 UTC --- GBSD#4 Looking at this one. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-02 09:47:10 UTC --- If I search (coming from Advanced Search) with a limit on year: cgi-bin/koha/opac-search.pl?idx=kw&q=vermeer&idx=kw&idx=kw&do=Zoek&limit-yr=-2005&sort_by=pubdate_dsc the limit is saved in the database (looking via sql), but is not applied to the search when I run it again from the search history form, giving different results: cgi-bin/koha/opac-search.pl?idx=kw&q=vermeer I would expect something with: kw,wrdl: vermeer yr,st-numeric=-2005 Changing status -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |alex.arnaud@biblibre.com --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-05 15:36:30 UTC --- Alex has worked on this and should send an updated patch soon -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #18 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-09-14 08:38:09 UTC --- Created attachment 5422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5422 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-28 14:21:19 UTC --- *** Bug 4029 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5277|0 |1 is obsolete| | Attachment #5422|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard@myacpl.org> 2011-09-30 12:46:26 UTC --- Created attachment 5659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5659 Signed-off patches, squashed Tested several combinations of advanced searches including keyword types, publication date ranges, itemtype limits, location, and sort. All search history results matched the results of the original search. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Does not apply --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-14 11:33:08 UTC --- This patch is already SIGNED, but unfortunately does not apply. Please rebase. Applying: Bug 5981 : (MT 4231) Adds limits to search history /usr/share/koha/testclone/.git/rebase-apply/patch:101: trailing whitespace. ADD `limit_cgi` VARCHAR( 255 ) NULL DEFAULT NULL AFTER `limit_desc` warning: C4/Auth.pm has type 100755, expected 100644 error: patch failed: C4/Auth.pm:130 error: C4/Auth.pm: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:4446 error: installer/data/mysql/updatedatabase.pl: patch does not apply Using index info to reconstruct a base tree... <stdin>:101: trailing whitespace. ADD `limit_cgi` VARCHAR( 255 ) NULL DEFAULT NULL AFTER `limit_desc` warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merged C4/Auth.pm CONFLICT (content): Merge conflict in C4/Auth.pm Auto-merged C4/Search.pm Auto-merged installer/data/mysql/kohastructure.sql Auto-merged installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merged koha-tmpl/opac-tmpl/prog/en/modules/opac-search-history.tt Auto-merged opac/opac-search.pl Failed to merge in the changes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5659|0 |1 is obsolete| | --- Comment #22 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 10087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10087&action=edit Bug 5981 - OPAC: Add limits to search history -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #23 from Alex Arnaud <alex.arnaud@biblibre.com> --- This patch does the same thing than the previous one but it should apply. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10087|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10316&action=edit [SIGNED-OFF] Bug 5981 - OPAC: Add limits to search history Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a conflict in updatedatabase and removed kohaversion.pl from the patch. Patch works nicely, tested with different searches and limits. Note: Sort options don't get into the history still. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10316|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10632&action=edit [SIGNED-OFF] Bug 5981 - OPAC: Add limits to search history Rebased patch + reindentation (replaces \t with 4 spaces) Works as expected. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #26 from Chris Cormack <chris@bigballofwax.co.nz> --- Bugfix, pushed to 3.8.x will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Reverted out of 3.8.x this breaks the opac search navigation, see bug 8381. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some strange side effects of this patch on master too. It all resumes to working normally as soon as I turn opacsearchhistory off or revert this patch out. Symptoms: - Every search seems to freeze the browser, but after a minute or so the search result page appears - Paging works for me, but at a 1 page/minute speed I tried lots of different things before I figured out it was this patch making the difference: - rebuilt my indexes several times - ran Makefile to make sure I have all current zebra files - changed from grs to dom indexing - changed to icu None of that worked. I have no idea what's going on here, but I think reverting out of master would be good until we figure it out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #28)
There are some strange side effects of this patch on master too. It all resumes to working normally as soon as I turn opacsearchhistory off or revert this patch out.
Symptoms: - Every search seems to freeze the browser, but after a minute or so the search result page appears - Paging works for me, but at a 1 page/minute speed Katrin,
I can't reproduce your problem, it works well for me, I just tested again. Is it still relevant for you and do you have something in your setup (plack or no ? zebra DOM or GRS1 ? how many records indexed ?adv search is working or also very slow ? anything in your logs ? (I'm also Investigating 8381) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Paul, nothing in the logs - I know, there should probably be something. I started with grs, switched to DOM and ICU. The problem remained. I did a keyword search for "der" (German article). Staff search worked without any problems (no search history), the problem only occured in OPAC and vanished after deactivating the search history or reverting the patch. I did sign off on this patch and I am sure it was not there when I initially tested it - but it's a big problem now. I suspect something changed in between that is causing the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #31 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #30)
I did sign off on this patch and I am sure it was not there when I initially tested it - but it's a big problem now. I suspect something changed in between that is causing the problem.
really weird... let's wait until Alex find a fix for bug 8381, maybe they are related ? (even if I don't see how they could be) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No Plack, but memcache - restarted it several times. Maybe that is it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #33 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #32)
No Plack, but memcache - restarted it several times. Maybe that is it?
Should not be memcache, but I have no memcache by default. Could you try after shutting down memcache server ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can try that tonight. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Paul and Jonathan, I checked the search worked for me on current master with search history deactivated. Next I stopped the memcache server and reactivated the search history using the system preference. I still see the same systems - the browser seems to freeze, it takes over a minute, then I get to see a result list. I noticed something else, that is weird: on the result list the first line with the title of the first result on the result list is missing. It's also missing on other the other pages of the same search. XSLT results list is activated and used. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8381 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Version|master |rel_3_8 Resolution|--- |FIXED --- Comment #36 from Paul Poulain <paul.poulain@biblibre.com> --- Pushed to master, follow-up in bug 8381 also pushed, resolving this one, chris_c, you can push both on 3.8.x I think -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|RESOLVED |REOPENED Version|rel_3_8 |master Resolution|FIXED |--- Severity|normal |blocker --- Comment #37 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Either this patch or the patch to bug 8381 has broken the OPAC search in Chrome. With EnableOPACSearchHistory enabled, Chrome crashes on a regular keyword search (q=smith), and hangs on searches using idx=kw&q=smith. Disabling EnableOPACSearchHistory fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #37)
Either this patch or the patch to bug 8381 has broken the OPAC search in Chrome. With EnableOPACSearchHistory enabled, Chrome crashes on a regular keyword search (q=smith), and hangs on searches using idx=kw&q=smith. Disabling EnableOPACSearchHistory fixes the problem.
mmm... strange, I can't reproduce this problem. I use chromium shipped with Ubuntu: 18.0.1025.168 (Build de développement 134367 Linux) Ubuntu 12.04 I don't think i've any plugin installed (I don't use chrome daily) I played with some searches, history page, running a search from history,... Could you describe exactly what you were doing ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 --- Comment #39 from Chris Cormack <chris@bigballofwax.co.nz> --- Jared could you add some more information or, close this if the problem has gone away in master please. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #40 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The hanging is no longer an issue on Master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Bug 5981 depends on bug 8381, which changed state. Bug 8381 Summary: Paging broken in OPAC search results http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org